fluids: Convert IFunction_Advection to state structs

fluids: Minor stabilization refactor

fluids: Change skew advection threshold

3rd order requires a 20 CEED_EPSILON instead of just 5

fluids: Refactor diagonal tau calculation

Also correct documentation of tau calculation

fluids: Cleanup misc math

fluids: Change bubble_type to advection_ic_type

Since cosine_hill and skew aren't bubbles

fluids: Add in cosine hill and skew advection ICs

fluids: Ensure all outputs are set in QFunctions

- In support of #1420

fluids: Add SGS DD training QFunctions

- Returns training data

fluids: Move diff filter enums to separate header file

- So that other QFunctions can use them for indexing into differential
filtered fields

fluids: Agnosticize VeloGradient projection setup

- It can now setup more than just user->grad_velo_proj

fix(fluids): Remove BUBBLE_COSINE

- left over from new feature

Merge pull request #1399 from CEED/jrwrigh/advection_cleanup

fluids: Cleanup advection problems

Merge pull request #1381 from CEED/jrwrigh/fixup_coords

fluids: Remove coordinates from IFunction_NodalSgs

fluids: Use enums in advection

Drop Coordinate Basis from IJacobian (without breaking IDL) (#1380)

* compute IDL coefficient in IFunction that has access to coordinates, append this to jac_data so that IJacobian can avoid pulling

Drop Coordinate Basis from IJacobian (without breaking IDL) (#1380)

* compute IDL coefficient in IFunction that has access to coordinates, append this to jac_data so that IJacobian can avoid pulling coordinates through basis to apply IDL

Co-authored-by: James Wright <james@jameswright.xyz>

show more ...

fluids: Remove coordinates from IFunction_NodalSgs

- Stragler from previous PR

style errors induced by dropping coordinates where not used

deleted all the unused coordinate references that were throwing warnings

reverting the change to IC that caused divergence on first step...guess I was too sleepy to drive last night

quick attempt at taking potential out of the initial condition makes the error norm much smaller but still probably cannot compare solutions with different Etot variables

adding body force term to energy equation...for now the b vector is using what is put into gravity

last one maybe

more style edits

style cleanup