fixes from recent linter change
chkerr and friends wrapped
Remove many PetscCheckFalse() from tsCommit-type: style-fix/spend 1hThanks-to: Jose E. Roman <jroman@dsic.upv.es>
Doc: Trying to remove all reported errors - Since it reports as an error, and only occurs a very few times, I have removed the Imput/Output Parameters sections and replaced them by Output Parameters
Doc: Trying to remove all reported errors - Since it reports as an error, and only occurs a very few times, I have removed the Imput/Output Parameters sections and replaced them by Output Parameters with documentation
show more ...
rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()
add PetscAssert() and PetscAssertFalse()
SETERRQ[1-9]+ begone
Style: replace "!rank" with "rank == 0"In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds les
Style: replace "!rank" with "rank == 0"In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds lesstightly, so the result of the computation would otherwise change.
Fix manpages: Argument --> Parameter (required to enable sowing checks)
Fix manpages: mismatching number of parameters
Fix manpages: Input/Output Parameter --> Parameters
Add event for TSTrajSetUp
Merge remote-tracking branch 'origin/release'
petscviewer: fix the fortran bindings of XXXViewFromOptions when called with obj=PETSC_NULL_XXX
Convert MPI error type to PETSc error with string message for all MPI callsNow PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-pro
Convert MPI error type to PETSc error with string message for all MPI callsNow PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-process their errors better.The test harness will now automatically retry tests that fail with MPI, this may help with Intel MPI that produces seemingly random failures.Commit-type: error-checking/spend 30m
Updated the use of sizeof() when possible instead of using hardwired sizes for functions whose string argumentsneed sizes. In particular done for PetscOptionsGetString(), PetscOptionsString(), and a
Updated the use of sizeof() when possible instead of using hardwired sizes for functions whose string argumentsneed sizes. In particular done for PetscOptionsGetString(), PetscOptionsString(), and a few other utilitiesCommit-type: style-fixDevelopment Tools: Vim, Emacs, Eclipse
TS: Replace 0 -> NULL for pointers
Remove usage of PETSC_HAVE_FORTRAN_STDCALL, PETSC_BLASLAPACK_STDCALL, HAVE_FORTRAN_MIXED_STR_ARG flags - as Compaq f90 compiler is no longer supported
Fix item list in manpages of XXXViewFromOptions
prototype for ViewFromOptions macro-->functions
Update the use of Collective on in the manual pages to reflect the new styleCommit-type: style-fix, documentationThanks-to: Patrick Sanan <patrick.sanan@gmail.com>
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be unif
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be uniformly used or maintained.Thus, remove all .keywords: fields, and a following blank line, if present.This is accomplished with GNU sed (gsed on OS X), with the following commands.*Warning* that this type of command can corrupt a .git directory,so be cautious in reusing or modifying these commands. They first lookfor and delete matching lines with a following line consisting of only whitespace,and then delete any remaining matching lines. find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find src/ -type f -exec gsed -i '/keywords:/d' {} + find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find include/ -type f -exec gsed -i '/keywords:/d' {} +Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed
Generate unique folder names for TSTrajectory- Added PetscMkdtemp()- Removed -ts_trajectory_dirname in tests- The changes are also applied to trajmemory.cFunded-by:Project: FASTMATH adjointTi
Generate unique folder names for TSTrajectory- Added PetscMkdtemp()- Removed -ts_trajectory_dirname in tests- The changes are also applied to trajmemory.cFunded-by:Project: FASTMATH adjointTime: 6.5 hoursReported-by:Thanks-to:
TSAdjoint: set TSTrajectory not to use TSHistoryFunded-by:Project: FASTMath adjointTime: 0.5 hoursReported-by:Thanks-to:
TSAdjoint: add check for checkpointing settings- Error out when -ts_trajectory_type basic and -ts_trajectory_solution_only are used together- The basic type simply saves everything to disk and doe
TSAdjoint: add check for checkpointing settings- Error out when -ts_trajectory_type basic and -ts_trajectory_solution_only are used together- The basic type simply saves everything to disk and does not recompute stage values needed by TSAdjoint- Ugly workaround. Erroring out from TSTrajectory could be betterFunded-by:Project: FASTMath adjointTime: 2.0 hoursReported-by:Thanks-to:
123456