xref: /petsc/doc/developers/mrmanagement.md (revision 5d8720fa41fb4169420198de95a3fb9ffc339d07)
1(mr_management)=
2
3# Merge request management
4
5At any given time, at least one of the {any}`sec_core_developers` is an
6"MR Shepherd" and ensures that open merge
7requests progress through the {any}`review process <sec_mr_reviewing>`,
8examining open merge requests and taking appropriate action.
9
10```{eval-rst}
11.. list-table:: MR Shepherd Checks
12      :widths: 50 50
13      :align: left
14      :header-rows: 1
15
16      * - MR State
17        - Action
18      * - Missing a :any:`workflow label <sec_workflow_labels>` and other labels
19        - Add an appropriate label, or label ``workflow::Waiting-on-Submitter`` and ask the submitter/assignee to update
20      * - Without an assignee
21        - Assign the submitter (if the MR is from a fork, also list an appropriate developer)
22      * - Without reviewers
23        - Assign reviewers
24```
25
26If MRs are inactive for too long, remind the submitter/assignee, reviewer(s), or integrator(s) of actions to take.
27If the submitter/assignee must take action, change the label to `workflow::Waiting-on-Submitter`.
28
29```{eval-rst}
30.. list-table:: MR Inactivity Thresholds
31      :widths: 50 50
32      :align: left
33      :header-rows: 1
34
35      * - MR state
36        - Inactivity threshold
37      * - ``workflow:Pipeline-Testing``
38        - One week
39      * - ``workflow::Review``
40        - One week
41      * - ``workflow::Ready-for-Merge``
42        - Three days
43      * - ``workflow::Waiting-on-Submitter``
44        - One month
45      * - ``workflow::Request-for-Comment``
46        - One month
47      * - ``workflow::Requires-Discussion``
48        - One month
49      * - All others
50        - One year
51```
52
53If a submitter has been unresponsive for a year,
54close the MR, label `workflow::Inactive-closed`,
55and let the submitter know that they may reopen if desired.
56