Merge pull request #1234 from CEED/jrwrigh/fluids_64int

fluids: Compatability for PETSc w/ 64bit ints

fluids: Remove problem->bc function pointers

- Not needed, as essential boundary conditions go through
`DMPlexInsertBoundaryValues_NS` or
`DMPlexInsertBoundaryValues_StrongBC`

Merge pull request #1237 from CEED/jrwrigh/petsc-success

examples: Use PETSC_SUCCESS in PetscFunctionReturn

examples: Use PetscFunctionReturn in PETSC_SUCCESS

Merge pull request #1185 from CEED/jrwrigh/fluids-cleanup

fluids: Move to local Vec storage and petsc-ops

fluids: Move setup function calls to better locations

- Move libCEED operator setup functions to SetupLibceed
- Rename turbulence statistics functions to match naming convention

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc heade

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc headers

* iwyu - ceed/ceed.h -> ceed.h

* iwyu - cuda/hip include fixes

show more ...

Lift, Drag, Heat Transfer (#1130)

* add functions for surface forces

* function for surface forces

* reaction forces

* add points to label

* WIP: examples/fluids: sketch surface force ca

Lift, Drag, Heat Transfer (#1130)

* add functions for surface forces

* function for surface forces

* reaction forces

* add points to label

* WIP: examples/fluids: sketch surface force calculations

* examples/fluids: fix for parallel, when there are no such points on a process

* add TSMonitor_FaceForce function

* update on TSMonitor FaceForce

* create .csv file

* cleanup TS Monitor FaceForce function

* include surface forces viewer to header file

* include ts monitor surface force viewer to cloptions

* update where TSMonitor FaceForce are called

* examples/fluids: update wall forces to write csv

mpiexec -n 5 build/fluids-navierstokes -options_file examples/fluids/vortexshedding.yaml -{ts,snes}_monitor -degree 1 -ts_monitor_wall_forces ascii:force.csv:ascii_csv

* update documentation

* reaction force data

* plotting script

* examples/fluids: seaborn plotting with twinx and colors

* delete data file

* tuck away csv file

* place python script in subdirectory

* examples/fluids/postprocess: put shedding period in title

* examples/fluids: document wall force and shedding postprocess

---------

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - re

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - remove stray newline

* make - simpler 'make format' target

* ci - use newer libxsmm

* doc - minor release note claification

* minor - minor fix

* minor - minor fix

* minor - minor fix

* minor - minor fix

* make format

* format - less aggressive alignment rules

* tidy - check for argument name mismatches

* fix newline

* format - mirror Ratel update to .clang-format

* fix merge error

* fix merge conflict

* fix merge error

* drop style in .phony list

* Update .clang-format

Co-authored-by: Jed Brown <jed@jedbrown.org>

* apply updated format

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

fluids: Switch to StateVar enum

fluids: Rename primitive booleans, misc formatting

Merge pull request #1029 from CEED/jrwrigh/stg-primitive

fluids: Make Strong STG compatible with primitive variables.

fluids: Make stg components dependent on primitive

Fluids - Newtonian with Primitive variables (#1011)

* Fluids - Initial commit for Newtonian primitive variables

* Fluids - include A0 (dU/dY) in the output

* Fluids - added ICs for IG in primi

Fluids - Newtonian with Primitive variables (#1011)

* Fluids - Initial commit for Newtonian primitive variables

* Fluids - include A0 (dU/dY) in the output

* Fluids - added ICs for IG in primitive variables

* Fluids - added Jacobean QFunction for primitive variables

* Fluids - added RHS QFunction for primitive variables

* Fluids - fixed compilation errors and warnings

* Fluids - added ICs for density_current with primitive variables

* Fluids - In/OutFlow BCs for channel in primitive variables

* Adding the missing parts after rebasing onto main

* Fluids - Use correct component names for primitive variables

* Fluids - Primitive variables supported only with implicit scheme

* Fluids - drop in/outflow for channel flow and call Exact_Channel_Prim() in Exact_Channel()

* Fluids - Set solver's QFunction data in an if-else statement

* Fluids - style

* Fluids - add a comment to explain why the the gravity body force is excluded from the potential energy.

* Fluids - Exact_Channel return State

* Fluids - density_current: some style and cleanup

* Fluids - DC: refactor & cleanup

* Fluids - Singel QFunction for prim&cons

* Fluids - Use absolute temperature

* Fluids - DC: Fix pressure

show more ...

examples/fluids: skip legacy preallocation (we use COO)

When using -snes_fd_color or running a model that doesn't provide a
Jacobian (in which case coloring will be used automatically), we still
nee

examples/fluids: skip legacy preallocation (we use COO)

When using -snes_fd_color or running a model that doesn't provide a
Jacobian (in which case coloring will be used automatically), we still
need to preallocate.

show more ...

Merge pull request #1016 from CEED/jed/plex-cell-coordinates

examples/fluids: use DMGetCellCoordinateDM to handle periodicity

examples/fluids: use DMGetCellCoordinateDM to handle periodicity

Note that without -dm_sparse_localize 0 (default=1), the cell DM will
only have cells with localized coordinates (and there is no vec

examples/fluids: use DMGetCellCoordinateDM to handle periodicity

Note that without -dm_sparse_localize 0 (default=1), the cell DM will
only have cells with localized coordinates (and there is no vector
representation that contains both).

show more ...

examples/fluids: Move StrongSTGbcFunc to newtonian.h

- Requires significant changes to how the stg_context is passed to the
the strong bc

Merge pull request #962 from CEED/jed/fluids-jacobian

examples/fluids: add analytic Jacobian

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids: Add option for BC from ICs
examples/fluids: Correct for non-origin domains
examples/fluids: Implement Strong STG BC
examples/fluids: Minor stg improvements/style
examples/fluids: Add Strong STG functions
examples/fluids: Fix memory leak in STG
GPU assembly: fix potential basis loading offset error
tests - more complex source include testing
pc - fix qf fallback cloning
restr - relax comp_stride check for num_comp == 1
make style
pc - avoid direct access of basis data in multigrid creation
ceed - refactor fallback Ceed creation into separate fn
minor - homogonize int vs CeedInt
basis - add input checks
restr - add input checks on element restrictions
examples/fluids: Update STG test for new mesh feats
...

show more ...

examples/fluids: Implement Strong STG BC

examples/fluids: select GPU matrix and vector types

Mark viscous implicit examples to use -snes_fd_color because GPU
assembly is corrupt for unknown reasons. It's correct when running on
device with

examples/fluids: select GPU matrix and vector types

Mark viscous implicit examples to use -snes_fd_color because GPU
assembly is corrupt for unknown reasons. It's correct when running on
device with shell matrices.

show more ...

Merge pull request #958 from CEED/jed/fluids-cleaning

examples/fluids cleaning

examples/fluids: reduce prevalance of top-level setup_ctx

feat: Add blasius boundary layer and channel flow examples to examples/fluids (#942)

* examples/fluids: Upload current case for collaboration

* examples/fluids: Replace developing BL with duct

feat: Add blasius boundary layer and channel flow examples to examples/fluids (#942)

* examples/fluids: Upload current case for collaboration

* examples/fluids: Replace developing BL with duct

* examples/fluids: Allow density to "float" at inflow

* fix: Add u_normal

* examples/fluids: bug fix in density flux

* examples/fluids: implement "floating" pressure; prescribed u, T

* examples/fluids: fixing initialization

We need has_neumann=true to get the weak boundary integrals called. It
is initialized in problem->setup_ctx and used in SetupLibceed(). This is
a hack to always apply.

* examples/fluids: include kinetic energy in Blasius IC

* examples/fluids: Blasius quasi-2D (slip in z planes)

* feat: Add Exact_Channel function

* feat: Use Exact_Channel for IC and Inflow

* examples/fluids: Add channel example

* examples/fluids: Define mu in blasius.c, cleanup

* examples/fluid: Add Blasius solution calculator

* examples/fluids: Add blasius IC and BCs

* Convert to implicit TS

* examples/fluids: Update blasius.yaml

* Move to ChannelContext, refactor DC and newtonian

- Added a dedicated ChannelContext, which allows for user setting of
flow parameters and consistent sharing of parameters between
QFunctions (instead of hardcoding)
- Moved density current (DC) specific settings from newtonian.c
densitycurrent.c

* Make gravity into vector quantity

* Add in body force for channel

* examples/fluids: remove explicitly setting coordinate field

This is created automatically now by DMPlex and DMProjectCoordinates
breaks (localized) periodicity, resulting in a tangled mesh.

* examples/fluids: transpose flux Jacobian in SUPG stabilization

* examples/fluids: update docs commensurate with flux Jacobian transpose fix

* examples/fluids: work on docs for tau

* examples/fluids: Increase blasius Re, implement Xi to SUPG

- Increased the Uinf and mu by 4x for the blasius problem
- Implemented the calculation of Xi for the SUPG term in newtonian.h

* examples/fluids: Remove flux jacobian transpose

- Removed for both eulervortex.h and newtonian.h

* examples/fluids: Reset Newtonian unit scaling to neutral

- Note that this resets the scaling for the densitycurrent problem,
thus the examples (and possibly tests) will probably need to be
changed

* examples/fluids: fix PetscOptionsBegin for new PETSc

* feat: Add slanted domain top surface

* feat: Add graded mesh option for blasius

* fix: Correct inflow boundary condition handling

* feat: Move to blasius_context, add CLI options

* feat: Move Blasius to physical air properties

* fix: Blasius profile and mesh generation

- Add the correct float->int rounding
- Fix eta to a value after exceeding the table's bounds

fix: Add fix eta after exceeding table

* examples/fluids: Move to physical mu default, fix tests

* doc: Add minimum documentation for channel and blasius

* examples/fluids: Add primitive jacobian and tau

- Also add misc comments

* examples/fluids: propose alternative flux Jacobian via prim-to-conservative

* examples/fluids: Add PHASTA diagonal tau

* fix: Add back in timestep obtaining

* examples/fluids: Add analytic tractions to inflow and outflow

- This is a stop-gap until viscous flux can be computed properly on the
boundary from current solution.
- Tau constants in a state of flux still but this produced a decent v at
inflow and outflow, removing the steep dive caused by forcing
dv/dx=-du/dy from a zero traction of omission.

* examples/fluids: CLI options for diagonal c_tau's

* examples/fluids: Update dt via context labels

* feat: Add more blasius table points

* examples/fluids: Cleanup stab and adjust Ctau_E

* examples/fluids: Replace spatial tau with diagonal

* examples/fluids: Fix stab in Euler

- Initialize `stab` to zero, add sum over loop

* examples/fluids: Document diagonal tau formulation

* examples/fluids: Fix compiler warnings

* examples/fluids: check error codes and elide unused header

* examples/fluids: Correct blasius example CLI

- Also add mention of the `blasius.yaml` file

* examples/fluids: Add supg to default blasius.yaml

* examples/fluids: Use yaml for channel and blasius

- Instead of long CLI options
- Also cleaned up the yaml formatting
- Added Cartesian directions to the faceMarker names

* examples/fluids: Show example yamls in README

Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Kenneth E. Jansen <Kenneth.Jansen@colorado.edu>

show more ...