Ken/idl (#1138)

* inflow sponge pushing p towards P0 compiles and runs but unknown yet whether it is effective or not

* looks like my first attempt at this is missing something as there is neglig

Ken/idl (#1138)

* inflow sponge pushing p towards P0 compiles and runs but unknown yet whether it is effective or not

* looks like my first attempt at this is missing something as there is negligible effect from Jacobian addition

* examples/fluids: IDL fixes and demo

* Fix IDL sign error and rename variables/clang-format
* Let newtonianwave.yaml use -reference_pressure and temperature
* Propagate P0 = reference.pressure

* Small tweak to add IDL to the 3 ramp parameters.

* fluids: Extract fluids binary vector load function

- Needs to be used in multiple places (for ICs and for testing data)

* fluids: Correct typo in previous commits

* fluids: Add IDL and newtonian wave test

* fluids: Rename Newtonian Wave --> Gaussian Wave

* fluids: Move RampCoefficient into utils

- Also change name to LinearRampCoefficient, as we may have different
kinds of ramps in the future

* fluids: Change IDL commandline options

* docs(fluids): Document internal damping layer

Co-authored-by: Jed Brown <jed@jedbrown.org>

* fluids: Add ScaleN QF utility

* fluids: Extract InternalDampingLayer QFunction helper

---------

Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: KennethEJansen <jansenke@colorado.edu>
Co-authored-by: James Wright <james@jameswright.xyz>

show more ...

Lift, Drag, Heat Transfer (#1130)

* add functions for surface forces

* function for surface forces

* reaction forces

* add points to label

* WIP: examples/fluids: sketch surface force ca

Lift, Drag, Heat Transfer (#1130)

* add functions for surface forces

* function for surface forces

* reaction forces

* add points to label

* WIP: examples/fluids: sketch surface force calculations

* examples/fluids: fix for parallel, when there are no such points on a process

* add TSMonitor_FaceForce function

* update on TSMonitor FaceForce

* create .csv file

* cleanup TS Monitor FaceForce function

* include surface forces viewer to header file

* include ts monitor surface force viewer to cloptions

* update where TSMonitor FaceForce are called

* examples/fluids: update wall forces to write csv

mpiexec -n 5 build/fluids-navierstokes -options_file examples/fluids/vortexshedding.yaml -{ts,snes}_monitor -degree 1 -ts_monitor_wall_forces ascii:force.csv:ascii_csv

* update documentation

* reaction force data

* plotting script

* examples/fluids: seaborn plotting with twinx and colors

* delete data file

* tuck away csv file

* place python script in subdirectory

* examples/fluids/postprocess: put shedding period in title

* examples/fluids: document wall force and shedding postprocess

---------

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #1133 from CEED/jed/fluids-riemann-outflow

Switch outflow from pressure to Riemann pressure + temperature

examples/fluids: document outflow and add to demos

examples/fluids: Riemann outflow using pressure and temperature

* This allows stable sustained and transient recirculation.

* short-wake domain recirculation behind cylinder has sustained
rec

examples/fluids: Riemann outflow using pressure and temperature

* This allows stable sustained and transient recirculation.

* short-wake domain recirculation behind cylinder has sustained
recirculation. If the exterior temperature is different, the
recirculation will bring in the wrong temperature, but at least
it's stable.
* nwave with slow background causes transient flow reversal when
strong acoustic hits boundary.
* Clean outflow and lid for Blasius

* I tried the 2 P_ext - P_int strategy from Mengaldo (constant density)
and with specified exterior temperature, but they disrupted the interior
flow and were not significantly less reflective.

* The methods I tried for extrapolating interior temperature were not
stable. Simple extrapolation of velocity worked best, and did not show
signs of instability, perhaps because the neighboring flow and implicit
solve ties it together.

* This commit adds support for softmax control of recirculation, but the
parameters were finnicky, solver nonlinearity was a concern, and I'm not
convinced it's ever better than just allowing recirculation.

show more ...

Vortex shedding / flow past cylinder (#1082)

* add vortex shedding problem

* add file for the Qfunctions

* add yaml file

* update problem setup

* update IC qfunc

* update problem set

Vortex shedding / flow past cylinder (#1082)

* add vortex shedding problem

* add file for the Qfunctions

* add yaml file

* update problem setup

* update IC qfunc

* update problem setup

* update initial condition

* update yaml file

* add mesh file

* add vortexshedding to navierstokes.h

* register vortexshedding to cloptions.c

* update configuration/yaml file

* fix Min function

* examples/fluids: fix boundary condition labels for cylinder

$PhysicalNames
6
2 1 "inlet"
2 2 "outlet"
2 3 "top"
2 4 "bottom"
2 5 "cylinderwalls"
2 6 "frontandback"
$EndPhysicalNames

* update QFunctions in navierstokes.c

* update data and BC structs in navierstokes.h

* update vortexshedding.c

* update states

* update IC in vortexshedding.h

* add freestream BC to cloptions

* updates in setuplibceed.c

* include freestream BC in example

* cleanup duplicate variable names

* rename variables as freestream

* clean-up some warning messages

* clean up example

* add cylinder.geo

* label physical volume

* examples/fluids: fix cylinder mesh and add vortexshedding defaults

* update gravity vector

* examples/fluids: match domain to Shakib, get vortex street

* update to quadratic mesh

* clean up yaml file

* delete vortexshedding.c and vortexshedding.h

* remove vortexshedding from register

* update yaml file

* examples/fluids: Newtonian "still" initial condition

Reinstate outflow boundaries that were previously removed so that
existing tests can pass.

* examples/fluids: freestream inherits reference state

Fix freestream context reference counting bug.

* examples/fluids: avoid designated initializer in kernel code (breaks CUDA)

* add Shakib91 to references

* remove cylinder.geo and cylinder.msh

* wip:add documentation for vortex shedding

* update path to cylinder.msh

* add subdirectory for meshes

* parameterize cylinder.geo

* some fixes in cylinder.geo

* Fix cylinder.geo file

* examples/fluids: fix up mesh parametrization

Fix cylinder size (the function is Sqrt, not sqrt) and parametrize
resolution and aspect.

* examples/fluids: fix build after broken merge from main

* update Shakib1991 in references

* wip:docs for vortex shedding

* remove TODO comment

* reformulate docs

* fix docs

* delete cylinder.msh file

* work on documentation

* add vortex runtime options

* examples/fluids: update vortex shedding docs and mesh

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #1124 from CEED/jed/release-0.11

Release 0.11

examples/fluids doc: update description of SUPG

The old description is a relic from earlier comparisons of the GLS
versus VMS justifications. We now describe the version that is
implemented and work

examples/fluids doc: update description of SUPG

The old description is a relic from earlier comparisons of the GLS
versus VMS justifications. We now describe the version that is
implemented and works well.

show more ...

Merge pull request #1093 from CEED/ade/hllc-bcs

examples/fluids: upgrade to HLLC

examples/fluids: freestream options and documentation

* Collect options under -freestream_ prefix and use HLLC by default.
* newtonianwave.yaml: equal aspect, monitoring options

Merge pull request #1080 from CEED/ade/riemann-bcs

HLL Flux for Riemann BCs

doc(fluids): Add Newtonian Wave, bc_freestream

- Also fix citation in the Shock Tube documentation.

Co-authored-by: Jed Brown <jed@jedbrown.org>

Merge pull request #980 from CEED/jrwrigh/fluids_tractionbc

doc: Update blasius BC description

Merge pull request #962 from CEED/jed/fluids-jacobian

examples/fluids: add analytic Jacobian

examples/fluids: document developer options

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids: Add option for BC from ICs
examples/fluids: Correct for non-origin domains
examples/fluids: Implement Strong STG BC
examples/fluids: Minor stg improvements/style
examples/fluids: Add Strong STG functions
examples/fluids: Fix memory leak in STG
GPU assembly: fix potential basis loading offset error
tests - more complex source include testing
pc - fix qf fallback cloning
restr - relax comp_stride check for num_comp == 1
make style
pc - avoid direct access of basis data in multigrid creation
ceed - refactor fallback Ceed creation into separate fn
minor - homogonize int vs CeedInt
basis - add input checks
restr - add input checks on element restrictions
examples/fluids: Update STG test for new mesh feats
...

show more ...

Merge pull request #964 from CEED/jrwrigh/mesh_from_file

examples/fluids: Create mesh from file distribution

examples/fluids: Update docs for meshing from file

Merge branch 'main' into jed/fluids-jacobian

* main:
Fluids - Add STG inflow (#868)
ci - fix Nek5000 testing

Fluids - Add STG inflow (#868)

* doc(fluids): Add STG equations

* doc(fluids): Add basic data flow for STG

* doc(fluids): Add Shur et al. 2014 STG paper to bib

* doc(fluids): Specify STG in

Fluids - Add STG inflow (#868)

* doc(fluids): Add STG equations

* doc(fluids): Add basic data flow for STG

* doc(fluids): Add Shur et al. 2014 STG paper to bib

* doc(fluids): Specify STG inputs files, misc additions

* doc(fluids): Add intro for STG section

* fix(fluids): Add #include ceed.h for qfunctions

- In the spirit of "include what you use"

* feat(fluids): Start work on stg_shur14.h

* doc-fix: Correct kappa_min definition

* Move STG setup functions to problems/stg_shur14

* feat: Add cholesky decomposition function

* fix: Correct stg_ctx malloc, reorganize creation

Co-authored-by: Jed Brown <jed@jedbrown.org>

* fix(fluids): Correct return values of functions

* style: Fix up style

* feat(fluids): Get file paths from PetscOptions

- Also convert SetupSTGContext to return PetscErrorCode

* fix(fluids): Correct stg_ctx dereferencing

- Also move to size_t for type of the offsets

* feat(fluids): Add funcs for processing STG*.dat files

* feat(fluids): Move to PetscOptions* for STG flags

* feat: Use `PetscMax` instead of macro

* fix(fluids): Correct/Refactor file reading functions

- Move to `PetscSynchronizedFGets`
- Remove `inline`
- Pass `comm` between functions
- Add `OpenPHASTADatFile` to DRY

* docs(fluids): Fix equation typo

* fix(fluids): Correct calculation of kappa

* feat(fluids): Complete STGShur14_Calc

* feat(fluids): Add InterpolateProfile helper func

* feat(fluids): Add CalcSpectrum helper func

* feat(fluids): Add to STGShur14_Calc qfunction

* fix: Add M_PI, Update SETERRQ functions

- Also update style

* fix: Correct interpolation outside of datarange

* fix: Add missing definition for ke in CalcSpectrum

* feat: Migrate context and func signatures, Misc

- Create SetupSTGContext to be run in another Setup_____Context
function
- Migrate STGShur14Context, CreateSTGContext, and SetupSTGContext
signatures to navierstokes.h
- Add STG contexts to Physics and CeedData
- Add missing CHKERRQ to PetscFClose
- Move to SPDX license headers

* examples/fluids: Pass solution time via context label

* feat: Implement STG boundary integral

- Add theta0 and implicit members to STGShur14Context
- Tested via implementation to the blasius BL problem (though this will
probably go against the code history)

* feat: Fix STG Stuff

* feat: Implement STG inflow for blasius BL

- Note that fluctuations are turned off in this case

* examples/fluids: Add stg_mean_only flag

* examples/fluids: Check cholesky decomp for nans

- Also correct locaiton of cholesky decomposition in ReadSTGInflow()

* examples/fluids: Correct STG documentation

- Missing a 2 sqrt(3/2) factor and didn't take square root of q

* examples/fluids: Fix STGShur14_Calc

- Given the calculated spectrum, calculation of v' and u' verified
against python implementation (which was validated previously against
PHASTA)

* examples/fluids: Calc dXdx for boundary QFunctions

- Also calculate h from the dXdx in STGShur14_Inflow
- Replace h[0] result with constant dx spacing

* examples/fluids: Fix STG Spectra calcualtion

* examples/fluids: Fix build errors

- Ran into an include cycle collision that resulted in over-defining
SetupContext in advection.c
- newtonian_types.h (which has SetupContext defined) ->
stg_shur14_type.h -> navierstokes.h -> advection.c

* examples/fluids: Update and fix documentation

* examples/fluids: Correct dXdx comment, leave TODO

Co-authored-by: Jed Brown <jed@jedbrown.org>

* examples/fluids: Minor bib citation edits

Co-authored-by: Jed Brown <jed@jedbrown.org>

* examples/fluids: Add STGInflow.dat, fix blasius.yaml

* examples/fluids: int -> PetscInt | CeedInt

* examples/fluids: Style

* examples/fluids: Make Boolean names verb_noun format

- Also changes the stg flag to `-stg_use`

* examples/fluids: Add STG test

* examples/fluids: Style fix up

* examples/fluids: Update docs

* examples/fluids: Implement weakT option for STG

* examples/fluids: Fix casting for ROCm

* examples/fluids: avoid PETSc dependency in qfunctions

* examples/fluids: header cleanup

* backends/hip: avoid redundant inline

* examples/fluids: avoid VLA in qfunctions

GPUs don't like VLA and some compilers reject it when targeting GPUs.

* examples/fluids: Create STG_NMODES_MAX

* examples/fluids: Refactor stg setup out of blasius.c

* examples/fluids: Fix misc GPU bugs

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Shock Tube + YZB Discontinuity Capturing (#851)

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the

Shock Tube + YZB Discontinuity Capturing (#851)

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Changed variable name midpt to mid_point, removed redundant slip BC declarations.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Rebased with main

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Implemented fixes to the flux jacobians

* Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian.

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Missed a style fix

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixes to style and documentation.

* Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density.

* Added warnings for incompatible user input combinations.

* Added comments on beta to documentation, fixed j_gradn style issues.

* Compilation errors on my end. Committing to see if it's local or not.

* Style fixes

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Changed variable name midpt to mid_point, removed redundant slip BC declarations.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Rebased with main

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Implemented fixes to the flux jacobians

* Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian.

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Missed a style fix

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixes to style and documentation.

* Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density.

* Added warnings for incompatible user input combinations.

* Added comments on beta to documentation, fixed j_gradn style issues.

* Compilation errors on my end. Committing to see if it's local or not.

* Fluids: SETERRQ1 -> SETERRQ to be compatible with PETSc 3.17

* Fluids - Update shock-tube with #881

* Small fix to mid_point definition and removed repeat entries for Shock Tube problem in README.md.

* Including test output.

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Changed variable name midpt to mid_point, removed redundant slip BC declarations.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Rebased with main

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixed style error, made variable names clearer, and removed dead code.

* Missed a style fix

* Implemented fixes to the flux jacobians

* Updated documentation, tau definition in SU, and recommended fixes to the flux Jacobian.

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Missed a style fix

* Implemented the Sod Shock Tube problem with YZB discontinuity capturing. for the explicit formulation. SU stabilization is also implemented for the explicit formulation.

* Fixes to style and documentation.

* Fixing unnecessary problem->dim declaration and missing field in comment describing initial condition density.

* Added warnings for incompatible user input combinations.

* Added comments on beta to documentation, fixed j_gradn style issues.

* Compilation errors on my end. Committing to see if it's local or not.

* Fluids: SETERRQ1 -> SETERRQ to be compatible with PETSc 3.17

* Fluids - Update shock-tube with #881

* Fluids - added test output file for shocktube

* Small fix to mid_point definition and removed repeat entries for Shock Tube problem in README.md.

* Including test output.

* Update doc/sphinx/source/references.bib

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update examples/fluids/README.md

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update examples/fluids/index.md

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update examples/fluids/navierstokes.h

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update examples/fluids/problems/shocktube.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update examples/fluids/qfunctions/shocktube.h

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Removed unused IFunction

* Added shocktube variables to SetupContext in advection.h, advection2d.h, and densitycurrent.h

* Missed some merge conflicts that have now been cleared up.

* Added helper function for covariant element length along a given vector.

* Added SetupContext to shocktube.h

* Fix to regression test path

* remove variable transpose of the Jacobian

* Fix index swap in implicit SUPG

* examples/fluids shocktube: fix stab summation and transpose

* delete IFunction

* example/fluids- updates reference solution

Co-authored-by: Timothy Aiken <timothyaiken@Timothys-MacBook-Pro.local>
Co-authored-by: Timothy Aiken <timothyaiken@cu-biot-10-10.203.167.69.int.colorado.edu>
Co-authored-by: Leila Ghaffari <Leila.Ghaffari@colorado.edu>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Timothy Aiken <timothyaiken@cu-genvpn-tcom-10.180.164.177.int.colorado.edu>
Co-authored-by: AdelekeBankole <adeleke.bankole@colorado.edu>

show more ...

feat: Add blasius boundary layer and channel flow examples to examples/fluids (#942)

* examples/fluids: Upload current case for collaboration

* examples/fluids: Replace developing BL with duct

feat: Add blasius boundary layer and channel flow examples to examples/fluids (#942)

* examples/fluids: Upload current case for collaboration

* examples/fluids: Replace developing BL with duct

* examples/fluids: Allow density to "float" at inflow

* fix: Add u_normal

* examples/fluids: bug fix in density flux

* examples/fluids: implement "floating" pressure; prescribed u, T

* examples/fluids: fixing initialization

We need has_neumann=true to get the weak boundary integrals called. It
is initialized in problem->setup_ctx and used in SetupLibceed(). This is
a hack to always apply.

* examples/fluids: include kinetic energy in Blasius IC

* examples/fluids: Blasius quasi-2D (slip in z planes)

* feat: Add Exact_Channel function

* feat: Use Exact_Channel for IC and Inflow

* examples/fluids: Add channel example

* examples/fluids: Define mu in blasius.c, cleanup

* examples/fluid: Add Blasius solution calculator

* examples/fluids: Add blasius IC and BCs

* Convert to implicit TS

* examples/fluids: Update blasius.yaml

* Move to ChannelContext, refactor DC and newtonian

- Added a dedicated ChannelContext, which allows for user setting of
flow parameters and consistent sharing of parameters between
QFunctions (instead of hardcoding)
- Moved density current (DC) specific settings from newtonian.c
densitycurrent.c

* Make gravity into vector quantity

* Add in body force for channel

* examples/fluids: remove explicitly setting coordinate field

This is created automatically now by DMPlex and DMProjectCoordinates
breaks (localized) periodicity, resulting in a tangled mesh.

* examples/fluids: transpose flux Jacobian in SUPG stabilization

* examples/fluids: update docs commensurate with flux Jacobian transpose fix

* examples/fluids: work on docs for tau

* examples/fluids: Increase blasius Re, implement Xi to SUPG

- Increased the Uinf and mu by 4x for the blasius problem
- Implemented the calculation of Xi for the SUPG term in newtonian.h

* examples/fluids: Remove flux jacobian transpose

- Removed for both eulervortex.h and newtonian.h

* examples/fluids: Reset Newtonian unit scaling to neutral

- Note that this resets the scaling for the densitycurrent problem,
thus the examples (and possibly tests) will probably need to be
changed

* examples/fluids: fix PetscOptionsBegin for new PETSc

* feat: Add slanted domain top surface

* feat: Add graded mesh option for blasius

* fix: Correct inflow boundary condition handling

* feat: Move to blasius_context, add CLI options

* feat: Move Blasius to physical air properties

* fix: Blasius profile and mesh generation

- Add the correct float->int rounding
- Fix eta to a value after exceeding the table's bounds

fix: Add fix eta after exceeding table

* examples/fluids: Move to physical mu default, fix tests

* doc: Add minimum documentation for channel and blasius

* examples/fluids: Add primitive jacobian and tau

- Also add misc comments

* examples/fluids: propose alternative flux Jacobian via prim-to-conservative

* examples/fluids: Add PHASTA diagonal tau

* fix: Add back in timestep obtaining

* examples/fluids: Add analytic tractions to inflow and outflow

- This is a stop-gap until viscous flux can be computed properly on the
boundary from current solution.
- Tau constants in a state of flux still but this produced a decent v at
inflow and outflow, removing the steep dive caused by forcing
dv/dx=-du/dy from a zero traction of omission.

* examples/fluids: CLI options for diagonal c_tau's

* examples/fluids: Update dt via context labels

* feat: Add more blasius table points

* examples/fluids: Cleanup stab and adjust Ctau_E

* examples/fluids: Replace spatial tau with diagonal

* examples/fluids: Fix stab in Euler

- Initialize `stab` to zero, add sum over loop

* examples/fluids: Document diagonal tau formulation

* examples/fluids: Fix compiler warnings

* examples/fluids: check error codes and elide unused header

* examples/fluids: Correct blasius example CLI

- Also add mention of the `blasius.yaml` file

* examples/fluids: Add supg to default blasius.yaml

* examples/fluids: Use yaml for channel and blasius

- Instead of long CLI options
- Also cleaned up the yaml formatting
- Added Cartesian directions to the faceMarker names

* examples/fluids: Show example yamls in README

Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Kenneth E. Jansen <Kenneth.Jansen@colorado.edu>

show more ...

Merge pull request #880 from CEED/jrwrigh/doc-fluids

doc(fluids): Correct vector name in Tau dropdown

doc(fluids): Correct vector name in Tau dropdown

Otherwise $$\hat{\bm{n}}$$ is never defined.