fluids: Switch to StateVar enum

fluids: Unify Newtonian Primitive functions #1035

Merge separate IFunction and IJacobian routines into a single helper function and
separate wrappers for each state variable option.

fluids: Rename primitive booleans, misc formatting

Fluids - Newtonian with Primitive variables (#1011)

* Fluids - Initial commit for Newtonian primitive variables

* Fluids - include A0 (dU/dY) in the output

* Fluids - added ICs for IG in primi

Fluids - Newtonian with Primitive variables (#1011)

* Fluids - Initial commit for Newtonian primitive variables

* Fluids - include A0 (dU/dY) in the output

* Fluids - added ICs for IG in primitive variables

* Fluids - added Jacobean QFunction for primitive variables

* Fluids - added RHS QFunction for primitive variables

* Fluids - fixed compilation errors and warnings

* Fluids - added ICs for density_current with primitive variables

* Fluids - In/OutFlow BCs for channel in primitive variables

* Adding the missing parts after rebasing onto main

* Fluids - Use correct component names for primitive variables

* Fluids - Primitive variables supported only with implicit scheme

* Fluids - drop in/outflow for channel flow and call Exact_Channel_Prim() in Exact_Channel()

* Fluids - Set solver's QFunction data in an if-else statement

* Fluids - style

* Fluids - add a comment to explain why the the gravity body force is excluded from the potential energy.

* Fluids - Exact_Channel return State

* Fluids - density_current: some style and cleanup

* Fluids - DC: refactor & cleanup

* Fluids - Singel QFunction for prim&cons

* Fluids - Use absolute temperature

* Fluids - DC: Fix pressure

show more ...

Merge pull request #994 from CEED/fluids-block-diagonal

Fluids block diagonal

examples/fluids: use shell for Amat, block diagonal aij* for Pmat

This adds two independent options for tuning solves.

-amat_type shell: causes Amat and Pmat to be different matrices, with shell
us

examples/fluids: use shell for Amat, block diagonal aij* for Pmat

This adds two independent options for tuning solves.

-amat_type shell: causes Amat and Pmat to be different matrices, with shell
used for Amat. It's technically possible to use other matrix formats
here.

-pmat_pbdiagonal: causes Pmat to be assembled as point-block diagonal.
Note that this usually only makes sense in addition to -amat_type shell
because otherwise your KSP is only working with the point-block diagonal.

show more ...

Merge pull request #1009 from CEED/jrwrigh/dirichlet_with_libceed

Fluids - Use libCEED to compute Dirichlet boundary conditions

fix(fluids): Create and use basis_xc_sur for dirichlet bcs

fluids: Implement dirichlet bcs via libCEED

Merge branch 'main' into jeremy/assembly-fix

Merge branch 'main' into jeremy/memcheck-qf-ctx

Merge pull request #993 from CEED/jeremy/fluids-bcs

Fluids BCs performance updates

fluids - cache boundary conditions in separate vecs

Merge pull request #962 from CEED/jed/fluids-jacobian

examples/fluids: add analytic Jacobian

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids

Merge branch 'main' into jed/fluids-jacobian

* main: (24 commits)
op - more data in view
examples/fluids: Test for strong STG
examples/fluids: Add strong STG to documentation
examples/fluids: Add option for BC from ICs
examples/fluids: Correct for non-origin domains
examples/fluids: Implement Strong STG BC
examples/fluids: Minor stg improvements/style
examples/fluids: Add Strong STG functions
examples/fluids: Fix memory leak in STG
GPU assembly: fix potential basis loading offset error
tests - more complex source include testing
pc - fix qf fallback cloning
restr - relax comp_stride check for num_comp == 1
make style
pc - avoid direct access of basis data in multigrid creation
ceed - refactor fallback Ceed creation into separate fn
minor - homogonize int vs CeedInt
basis - add input checks
restr - add input checks on element restrictions
examples/fluids: Update STG test for new mesh feats
...

show more ...

Merge pull request #967 from CEED/jrwrigh/strong-stg

Fluids: Strongly enforced STG

examples/fluids: Add option for BC from ICs

- Instead of hard coded if statement, add option on whether to set the
boundary conditions based on their initial condition values
- Default set to

examples/fluids: Add option for BC from ICs

- Instead of hard coded if statement, add option on whether to set the
boundary conditions based on their initial condition values
- Default set to True

show more ...

examples/fluids: select GPU matrix and vector types

Mark viscous implicit examples to use -snes_fd_color because GPU
assembly is corrupt for unknown reasons. It's correct when running on
device with

examples/fluids: select GPU matrix and vector types

Mark viscous implicit examples to use -snes_fd_color because GPU
assembly is corrupt for unknown reasons. It's correct when running on
device with shell matrices.

show more ...

examples/fluids: add IJacobian for SUPG

I think this is exact for Galerkin on channel.yaml and blasius.yaml.
Specifically, SNES converges almost perfectly in this test than when
-snes_mf_operator is

examples/fluids: add IJacobian for SUPG

I think this is exact for Galerkin on channel.yaml and blasius.yaml.
Specifically, SNES converges almost perfectly in this test than when
-snes_mf_operator is added.

-options_file examples/fluids/channel.yaml -snes_monitor -ksp_converged_reason -stab none -ts_max_steps 3 -newtonian_unit_tests -ksp_rtol 1e-10 -order 2 -ts_dt 3e-6 -pc_type lu

I say "think" because something is fishy with the viscous energy term
velocity*stress. If I disable that term, then convergence is clearly
better with the analytic Jacobian (makes sense because it's accuracy is
machine epsilon) than with -snes_mf_operator. This is unexpected, but
the difference is near the limit of numerical stability so I'm not
confident it's wrong. Also, the term itself is so simple.

The Jacobian is inexact for SUPG in that Tau_d is frozen.

WIP: examples/fluids: support MatShell and Blasius_Inflow_Jacobian

show more ...

Merge pull request #958 from CEED/jed/fluids-cleaning

examples/fluids cleaning

examples/fluids: make setup contexts independent

These are now private to each example and can be developed independently.

examples/fluids: remove setup_ctx from printing

examples/fluids: reduce prevalance of top-level setup_ctx

examples/fluids: consolidate two-step setup

Contexts are created in one place now and we have removed duplicate
struct definitions for physics.

examples/fluids: create struct in Problem for each qfunction + related

This is a cosmetic step toward better modularity.