Whitespace, style, and formatting updates for consistency between CUDA and HIP backends

Adds include guards in JiT header files, even if not strictly necessary, to match the precedent set in cuda-sh

Whitespace, style, and formatting updates for consistency between CUDA and HIP backends

Adds include guards in JiT header files, even if not strictly necessary, to match the precedent set in cuda-shared and hip-shared as well as sycl.

show more ...

Consistency in 'does not support' vs 'does not implement' (#1205)

* interface - consistency in 'does not support' vs 'does not implement'

* minor - consistency fixes

* minor - style consistency

Merge pull request #1197 from sebastiangrimberg/sjg/style-whitespace-fix

Minor style consistency updates

Merge pull request #1198 from CEED/jeremy/CeedCheck

Add CeedCheck macro to reduce repetition

internal - add CeedCheck macro to reduce repetition

Miscellaneous whitespace consistency

Merge pull request #1156 from sebastiangrimberg/sjg/hcurl-basis-dev

H(curl) basis and `CEED_EVAL_CURL`

Add H(curl) basis and CEED_EVAL_CURL operations

This refactors basis application to use common code between CEED_EVAL_GRAD for H^1 and CEED_EVAL_INTERP for H(curl)/H(div). It should ideally expose a

Add H(curl) basis and CEED_EVAL_CURL operations

This refactors basis application to use common code between CEED_EVAL_GRAD for H^1 and CEED_EVAL_INTERP for H(curl)/H(div). It should ideally expose an easy way to get non-tensor backends to work for H(div) and H(curl).

show more ...

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc heade

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc headers

* iwyu - ceed/ceed.h -> ceed.h

* iwyu - cuda/hip include fixes

show more ...

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - re

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - remove stray newline

* make - simpler 'make format' target

* ci - use newer libxsmm

* doc - minor release note claification

* minor - minor fix

* minor - minor fix

* minor - minor fix

* minor - minor fix

* make format

* format - less aggressive alignment rules

* tidy - check for argument name mismatches

* fix newline

* format - mirror Ratel update to .clang-format

* fix merge error

* fix merge conflict

* fix merge error

* drop style in .phony list

* Update .clang-format

Co-authored-by: Jed Brown <jed@jedbrown.org>

* apply updated format

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #858 from CEED/jeremy/dump-copy-stuff

Strip redundant/outdated license info duplication

minor - update copyright headers

H(div) basis constructor (#878)

* backends/interface: added H(div) basis constructor

* tests: CEED_EVAL_INTERP/DIV tested for H(div) basis.

* Update interface/ceed-basis.c

Co-authored-by:

H(div) basis constructor (#878)

* backends/interface: added H(div) basis constructor

* tests: CEED_EVAL_INTERP/DIV tested for H(div) basis.

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* interface/ceed-basis.c: delete [-1,1] for non-tensor basis constructor

* Update interface/ceed-basis.c

Co-authored-by: Jed Brown <jed@jedbrown.org>

* include/ceed: added CEEDFESpace enum and used it at ceed-basis.c

* tests: added t330-basis.out and changed xhat-->x_hat

* Changed name convention for CeedElemTopology and CeedFESpace enum.

* make style

* interface/ceed-basis.c: Added FE space/topology of the basis to CeedBasisView function

* tests/output: update ...basis.out file

* Changed CEED_FE_TOPO_ ==> CEED_TOPOLOGY_

* backends/ref: delete CeedBasisApplyHdiv_Ref

* Update interface/ceed-basis.c

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update interface/ceed-basis.c

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* Update include/ceed-impl.h

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* interface/ceed-bassi.c: update CeedBasisView

* deleted L2 and H(curl) FE spaces

* minor - update output file

* minor - update output file

* style - consistency with main

Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

show more ...

vec/qf - initial valid/borrowed/owned split for data (#853)

* vec/qf - initial valid/borrowed/owned split for data

* vec/qf - tidy logic for checking active/stale data

* minor - add missing NU

vec/qf - initial valid/borrowed/owned split for data (#853)

* vec/qf - initial valid/borrowed/owned split for data

* vec/qf - tidy logic for checking active/stale data

* minor - add missing NULL

* doc - explain VectorTakeArray update

* minor - update error messages

* test - update error message in junit/tap

* gpu - fix stray CeedScalar vs void for QFunctionContext

* vec/qf - clarify/simplify access logic

* vec - calloc host arrays when no value set to make empty

* style - minor

* style - minor

* minor - fix error messages

* vec/qf - move data validity checking to backend interface

* gpu - add missing sync error checking for qfcontext

* gpu - homogonize use of impl for backend data to reduce confusion

* vec - clarify access conditions

* python - update test for stricter vector access

* vec - minor fixes

* minor - fix ipython change

* vec - add missing declarations in ceed/backend.h

* ctx - mirror vector borrowed data check in ctx interface

* vec - add CeedVectorGetArrayWrite

* vec - consistent use of CeedVectorGetArray vs CeedVectorGetArrayWrite

* python - small vec fixes

* doc - describe vector data semantics

* magma - update restriction

* gpu - fix restr bug I added, need to sum into target

* magma - fix restriction bug

* cpu - fix restriction bug here too

* op - fix evec allocations

* julia - fix ElemRestriction for new vector access rules

* op - double check GetArray vs Read vs Write usage

* doc - small fix

* restr - clean up read/write logic for restr

* python - add vec.array_write

* magma - typo fix

show more ...

Merge pull request #855 from CEED/jeremy/drop-oper-e-data

Remove magic number 16

cpu - additional minor name updates

Merge pull request #739 from CEED/jeremy/copy-ptr

Copy Ceed Object References

interface - add Ceed*Reference functions

Merge pull request #735 from CEED/jeremy/style-guide

Style Unification

style - updating C variable style

Merge pull request #716 from CEED/jed/install-backend.h

Jed/install backend.h

Install install backend headers under include/ceed/

This makes it possible to distribute source plugins that provide
additional backends. It's also used in MFEM, perhaps temporarily.

Deprecate ceed

Install install backend headers under include/ceed/

This makes it possible to distribute source plugins that provide
additional backends. It's also used in MFEM, perhaps temporarily.

Deprecate ceed-backend.h, which was not previously installed, but some
users accessed it from an in-place build.

Also install CUDA and HIP headers that allow users to provide CUfunction
and hipFunction_t.

Co-authored-by: Jeremy L. Thompson <jeremy.thompson@colorado.edu>
Requested-by: Andrew T. Barker <barker29@llnl.gov>

show more ...

Error Handling Improvement [fix #696] (#691)

* Operator - add operator/qfunction field compatibility checks

* QFunction - do not allow adding fields to QFunction in use with an operator

* Exam

Error Handling Improvement [fix #696] (#691)

* Operator - add operator/qfunction field compatibility checks

* QFunction - do not allow adding fields to QFunction in use with an operator

* Examples - add some extra exclusion markers in ceed example

* error - add error enum

* error - update error enum names and numbering

* error - use CEED_ERROR_BACKEND in all backend errors

* error - begin classifying interface errors

* error - update backends to use CEED_ERROR_SUCCESS and CeedChkBackend

* error - use new errors in gallery

* error - add some unsaved modifications

* error - improve documentation

* error - define CEED_ERROR_SUCCESS in GPU JiT; we really should have a common header to pipe defines to the JiT code

* error - more error code editing

* error - fix error string

* operator - fix setting field qpts

* basis - add input/output dimension error checking

* python - move basis utility methods to ceed object, no basis required or used

* python - force exit with negative error code

* make style-py

* rust - initial work to add error handling logic

* rust - add ceed.resource method

* rust - add results for methods that may fail

* rust - also format doctests

* minor - drop unused CeedChk()

* error - rename terminal/nonterminal to major/minor

* rust - set ErrorStore as default errorhandler

* python - revert error handing change for python

* python - use success error code from C bindings

* error - only upgrade error code in backend if positive

show more ...

headers - clearify includes to not rely on transitive includes (#701)

* headers - clearify includes to not rely on transitive includes

* style - add header recommendations from 'include-what-you-

headers - clearify includes to not rely on transitive includes (#701)

* headers - clearify includes to not rely on transitive includes

* style - add header recommendations from 'include-what-you-use'

* style - apply 'include-what-you-use' changes to CUDA backends

* style - 'include-what-you-use' for hip backends

* style - drop ceed.h includes in gallery qf source

* docs - add dev notes for header files

* style - header style and alphabetize

show more ...

QFunction Context Data Object (#596)

* Ctx - create context object for QFunction context data

* Context - rename UserContext -> QFunctionContext

* Ctx - add lcov markers

* Ctx - fix leak in

QFunction Context Data Object (#596)

* Ctx - create context object for QFunction context data

* Context - rename UserContext -> QFunctionContext

* Ctx - add lcov markers

* Ctx - fix leak in identity QFunctions

* Hip/Cuda - rename sync functions for vector/context

* Tests - lcov marker update

* QFunction - drop unused function

* Python - fix copy-paste errors

* Ctx - update notes for Fortran usage

* Fortran - drop unneeded cast

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Interface - use void* for SetData interfaces

* Make - use call quiet for NVCC

* Interface - use void* for GetData interfaces

* Make - add quiet call option for examples

* Makefile - create common makefile to reduce duplication/complexity in example makefiles

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...