Fix source location for methods moved from internal to backend

Handle case where a CeedBasis does not have an associated CeedTensorContract object

Revise previous approach to work with levels of operator fallback and delegation (for AVX and XSMM backends)

Use backend tensor contraction for CPU-based operator full assembly in place of naiive matrix-matrix multiplication implementation

Merge pull request #1363 from CEED/sjg/preconditioning-definitions-fix

Fix definition locations for `CeedOperatorGetFallback*` methods

Fix definition locations for CeedOperatorGetFallback* methods which are part of the backend API

Merge pull request #1310 from CEED/jeremy/drop-set-num-qpts

Remove CeedOperatorSetNumQuadraturePoints

op - remove CeedOperatorSetNumQuadraturePoints

Merge pull request #1344 from CEED/sjg/multiple-bases-diag-fix

Fix regression in multiple active bases diagonal assembly (alternative to #1343)

Fix regression in multiple active bases diagonal assembly

In particular, diagonal assembly of operators with different numbers of active input and output bases is supported, where the diagonal contr

Fix regression in multiple active bases diagonal assembly

In particular, diagonal assembly of operators with different numbers of active input and output bases is supported, where the diagonal contribution comes from matching pairs of input and output bases.

show more ...

Merge pull request #1341 from CEED/sjg/assembly-heap-alloc

Avoid VLA for assembled element matrices in `CeedSingleOperatorAssemble`

Avoid potentially very large stack allocation with VLA for CPU-based full assembly

Non-square operator full assembly (#1316)

* Consistency formatting for operator tests

* Add (failing) test for non-square operator full assembly

* Add support for CPU-based full assembly of no

Non-square operator full assembly (#1316)

* Consistency formatting for operator tests

* Add (failing) test for non-square operator full assembly

* Add support for CPU-based full assembly of non-square CeedOperators

* Fix full assembly of identity quadrature functions and operators with CEED_BASIS_NONE

Also adds a unit test for full assembly which fails prior to the changes in this commit.

* Minor refactor to improve coverage

show more ...

Merge pull request #1335 from CEED/sjg/backend-consistency-continued

Fix some missing backend consistency from #1315

Fix missed is_pointblock -> is_point_block

Fix another unintended change from #1315

Merge pull request #1315 from CEED/jeremy/queep

Backend Consistency Fixes

style - spell rstr consistently

Merge pull request #1233 from CEED/jrwrigh/pbdiagonal_symbolic

Add CeedOperatorLinearAssemblePointBlockDiagonalSymbolic

Add CeedOperatorLinearAssemblePointBlockDiagonalSymbolic

Merge pull request #1314 from CEED/jed/fix-realloc

preconditioning: fix realloc use-after-free bug

preconditioning: fix realloc use-after-free bug

realloc(&p, size) may change the value of p. In this function, we stored
the local variable into a struct, then call realloc again on
the (untrue) ass

preconditioning: fix realloc use-after-free bug

realloc(&p, size) may change the value of p. In this function, we stored
the local variable into a struct, then call realloc again on
the (untrue) assumption that the value would not change.

==31299== Invalid read of size 4
==31299== at 0x65A38F5: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:329)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x5960EF4: PCSetUp_Jacobi (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x59611C1: PCApply_Jacobi (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x5936522: PCApply (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x58F1BE5: KSPSolve_PREONLY (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== Address 0xaf09f20 is 0 bytes inside a block of size 4 free'd
==31299== at 0x484DCD3: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31299== by 0x6595067: CeedReallocArray (ceed.c:252)
==31299== by 0x65A2217: CeedOperatorAssemblyDataCreate (ceed-preconditioning.c:1265)
==31299== by 0x65A2628: CeedOperatorGetOperatorAssemblyData (ceed-preconditioning.c:1129)
==31299== by 0x65A3526: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:295)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== Block was alloc'd at
==31299== at 0x48487A9: malloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31299== by 0x6595067: CeedReallocArray (ceed.c:252)
==31299== by 0x65A1D24: CeedOperatorAssemblyDataCreate (ceed-preconditioning.c:1201)
==31299== by 0x65A2628: CeedOperatorGetOperatorAssemblyData (ceed-preconditioning.c:1129)
==31299== by 0x65A3526: CeedSingleOperatorAssembleAddDiagonal_Core (ceed-preconditioning.c:295)
==31299== by 0x65A5321: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1751)
==31299== by 0x65A529E: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1743)
==31299== by 0x65A52F8: CeedCompositeOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:433)
==31299== by 0x65A52F8: CeedOperatorLinearAssembleAddDiagonal (ceed-preconditioning.c:1749)
==31299== by 0x65A54B8: CeedOperatorLinearAssembleDiagonal (ceed-preconditioning.c:1694)
==31299== by 0x48C6437: RatelGetDiagonal (ratel-petsc-ops.c:71)
==31299== by 0x558FA59: MatGetDiagonal_Shell (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)
==31299== by 0x55A20A7: MatGetDiagonal (in /home/rezgar/petsc/mpich_arch/lib/libpetsc.so.3.019.4)

Reported-by: Rezgar Shakeri

show more ...

Merge pull request #1270 from CEED/jeremy/constantinople

Rename CEED_BASIS_COLLOCATED to CEED_BASIS_NONE

interface - rename CEED_BASIS_COLLOCATED to CEED_BASIS_NONE

Merge pull request #1281 from CEED/jeremy/simplify-parent

Clarify op fallback parent interface