Revert a550dd66

Formatting fixes for tests including consistent include order

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc heade

IWYU fixes (#1182)

* iwyu - include fixes

* iwyu - silence some iwyu output

* minor - clearer macro names

* iwyu - fix suggestion of "ceed/ceed.h" externally

* iwyu - lighter petsc headers

* iwyu - ceed/ceed.h -> ceed.h

* iwyu - cuda/hip include fixes

show more ...

Merge pull request #1167 from CEED/jeremy/drop-i

Consistency in c tests

style - consistency in c tests

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - re

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - remove stray newline

* make - simpler 'make format' target

* ci - use newer libxsmm

* doc - minor release note claification

* minor - minor fix

* minor - minor fix

* minor - minor fix

* minor - minor fix

* make format

* format - less aggressive alignment rules

* tidy - check for argument name mismatches

* fix newline

* format - mirror Ratel update to .clang-format

* fix merge error

* fix merge conflict

* fix merge error

* drop style in .phony list

* Update .clang-format

Co-authored-by: Jed Brown <jed@jedbrown.org>

* apply updated format

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #1002 from CEED/jeremy/format-ceed-types

Add CeedInt_FMT

test - update tests to use CeedInt_FMT

Merge pull request #898 from CEED/jeremy/qf-ctx-read

Read-only access for QFContext

style - minor consistency

Allow CeedScalar to be single precision (#788)

One can modify `ceed.h` to include `ceed-f32.h` and then use single precision. This is tested for C in CI and has been tested by developers with Rust,

Allow CeedScalar to be single precision (#788)

One can modify `ceed.h` to include `ceed-f32.h` and then use single precision. This is tested for C in CI and has been tested by developers with Rust, Julia, and Python. This interface is evolving and should be considered experimental at this time (thus lack of automated build support).

* Introduce CeedScalarType enum

* WIP changes to allow different definitions of CeedScalar

* Introduce new header files for float and double

* Only use avx tensor contract and MAGMA non-tensor basis if CeedScalar is double

* WIP changes to allow CeedScalar to be float

* WIP start trying to adjust test tolerances for float or double

* fix typos in comments

* install ceed-f32/64 headers

* Fix missing casts for hipMAGMA element restrictions

* make CeedQFunctionContextGetContextSize available for Python bindings

* Changes to Python bindings to allow CeedScalar to be float

* WIP adjust Python tests for float or double

* make style

* remove QFunctionContextGetContextSize from backend header

* Use quotes instead of <> in include statement

* Remove unncessary includes

* Update tolerances for tests

* [Julia] allow CeedScalar to be Float32

* [Julia] Use Preferences instead of custom build configuration

# Conflicts:
# julia/LibCEED.jl/src/C.jl

* [Makefile] Change definition of CC_VENDOR so it works with cross-compilation

* [Julia] Use Preferences in CI

# Conflicts:
# .github/workflows/julia-test-with-style.yml

* [Julia] Update docs about preferences

* [Julia] Add test/Project.toml workaround for Preferences

* Add CeedGetScalarType to get the type of CeedScalar at runtime

* [Julia] Move functions from Ceed.jl to LibCEED.jl

* [Julia] Add support for getting library path and scalar type at runtime

* [Julia] Minor change to checking if CUDA is loaded

* [Julia] Check correct CeedScalar types in basis functions

* [Julia] Fix tests comparing with output file

* [Julia] Change devtests to use CeedScalar instead of Float64

* Update test 402 so context will be same size in double or float

* Update tolerances for ceed examples

* [Julia] CUDA fixes

* remove unused variable in t208

* SchurDecomposition: do not compute tau on final iteration

* Update tolerances for some basis tests (for single precision)

* Make style

* Python style fixes for basis test

* Add single precision output for t300 and t320 and adjust checks; skip t541 in single

* Add LCOV exclusions after moving to new line

* fix spacing

* Python: make CEED_EPSILON available as libceed.EPSILON

* Python: optional parameter to specify different output file for test comparison

* Python: update tests' use of EPSILON and change test_300 output file for single precision

* Python: add convenience function for getting dtype corresponding to CeedScalar

* rust - add single precision support

* [Julia] Fall back on Float64 if CeedGetScalarType is not available

* [Julia] style

* Adjust tolerance for t301

* xsmm - add single precision support

* avx - add single precision support

* Add initial single precision support for MAGMA non-tensor basis

* Skip t300 and t320 in single precision; revert Python t300 changes

* Revert output changes for t300 and t320 in junit

* [Julia] Changes to autogenerated bindings for mixed precision

* [Julia] style

* [Julia] Check scalar type when changing libceed library path

The check is also performed when the package is loaded. This prevents having to
restart the Julia session twice

* [Julia] Require JLLWrappers version 1.3

This is needed to use Preferences to change the library path

* Add documentation page for precision development

Co-authored-by: Will Pazner <will.e.p@gmail.com>

* Cleanup from merge: remove old README

* Return CEED_ALIGN to backend.h

* Make Fortran compiler (FC) optional; empty skips Fortran tests

Use in Python and Rust builds, which may not have a Fortran compiler
installed and thus would produce confusing output.

* Add single precision CI test for Noether

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

Co-authored-by: Will Pazner <will.e.p@gmail.com>
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>
Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #735 from CEED/jeremy/style-guide

Style Unification

style - updating C variable style

Merge pull request #716 from CEED/jed/install-backend.h

Jed/install backend.h

Install install backend headers under include/ceed/

This makes it possible to distribute source plugins that provide
additional backends. It's also used in MFEM, perhaps temporarily.

Deprecate ceed

Install install backend headers under include/ceed/

This makes it possible to distribute source plugins that provide
additional backends. It's also used in MFEM, perhaps temporarily.

Deprecate ceed-backend.h, which was not previously installed, but some
users accessed it from an in-place build.

Also install CUDA and HIP headers that allow users to provide CUfunction
and hipFunction_t.

Co-authored-by: Jeremy L. Thompson <jeremy.thompson@colorado.edu>
Requested-by: Andrew T. Barker <barker29@llnl.gov>

show more ...

QFunction Context Data Object (#596)

* Ctx - create context object for QFunction context data

* Context - rename UserContext -> QFunctionContext

* Ctx - add lcov markers

* Ctx - fix leak in

QFunction Context Data Object (#596)

* Ctx - create context object for QFunction context data

* Context - rename UserContext -> QFunctionContext

* Ctx - add lcov markers

* Ctx - fix leak in identity QFunctions

* Hip/Cuda - rename sync functions for vector/context

* Tests - lcov marker update

* QFunction - drop unused function

* Python - fix copy-paste errors

* Ctx - update notes for Fortran usage

* Fortran - drop unneeded cast

Co-authored-by: Jed Brown <jed@jedbrown.org>

* Interface - use void* for SetData interfaces

* Make - use call quiet for NVCC

* Interface - use void* for GetData interfaces

* Make - add quiet call option for examples

* Makefile - create common makefile to reduce duplication/complexity in example makefiles

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #423 from CEED/jeremy/small-fixes

Small fixes from Python Work

Tests - fix eval modes in t40* for clarity

QFunction Create by Name (#311)

This PR adds a QFunction gallery to libCEED with 1D, 2D, and 3D mass and Poisson operators.

Closes issue #37, issue #340

* Add QFunction gallery, rename focca

QFunction Create by Name (#311)

This PR adds a QFunction gallery to libCEED with 1D, 2D, and 3D mass and Poisson operators.

Closes issue #37, issue #340

* Add QFunction gallery, rename focca

* Gallery - add initial QFunctions

* Add a test for using the QF gallery

* Modify ex1 to use gallery

* Add multiple test configs to tap

* Move output to test directory

* Update junit

* Add OCCA galley exception

* Add ex2

* Update ex2 for dim->ncompx

* Gallery - modify to work for CUDA as is

* Update Documentation

* Gallery - typo fix

* Gallery - convention change, postappend qfunction family variant

* Gallery - update template with new name checking convention

* Gallery - condense diff3DBuild QFunction

* Gallery - rename diff -> poisson

* Gallery - clarify poisson3DBuild comment

* Gallery - use Pragma SIMD, store Qdata in Voigt convention

* Examples - Convert BP3-6 to Voigt convention

* Examples - add cl option to switch between header and gallery qfs in CEED examples

* Examples - clean up construction of QF name

* Gallery - Switch to PascalCase for gallery names

* Doc - fix function type page

* Interface - Make sure strncpy result is null terminated

* Gallery - Update Poisson 2/3D Apply to new QF body

* make style

* make style - fix worst style problems

* make style - add gallery to make style

* Doc - update documentation errors and inconsistencies

* Examples - test ex1 ex2 with and without gallary

* Examples - reduce testing of ex1/ex2 without gallery, clean up non-gallery qfunctions

* MFEM - revert another make style mistake

* Manual make style updates

* Doc - update function documentation page

* Style updates, document test numbering conventions

* doc: resolve ambiguous image location warning, allow more Dot nodes

* Tests - style and cast cleanup

* Tests - fix README indentation

show more ...

Single Source QFunction (#304)

Introduce a new macro CEED_QFUNCTION that allows to define qFunctions in a single source code independently of the targeted backend.

Thanks-to: Jeremy Thompson
Tha

Single Source QFunction (#304)

Introduce a new macro CEED_QFUNCTION that allows to define qFunctions in a single source code independently of the targeted backend.

Thanks-to: Jeremy Thompson
Thanks-to: Jed Brown
This work is the result of a fruitful discussion between Jed Brown, Jeremy Thompson and Yohann Dudouit. Jeremy Thompson also implemented important features in this commit and was very active and helpful all along the progress of this work.

[NEWS] Breaking change: QFunctionField parameter 'ncomp' changed to 'size'. This change requires setting the previous value of 'ncomp' to 'ncomp*dim' when adding a QFunctionField with eval mode 'CEED_EVAL_GRAD'.

* First steps toward cuda-gen backend!

* Closer to real code generation.

* Generated code should be ready for nvrtc.

* The code generation skeleton is ready.

* Hack with the qfunction to make the operator kernel compile.

* Some tweaks in the makefile + Input fields structure change.

* Remove using cout.

* 1d interp and grad device functions.

* 1d readDofs, readQuads, writeDofs, writeQuads.

* Remove dead code.

* readDofs, readQuads, writeDofs, writeQuads for 2d and 3d

* 2d interp and grad

* 3d interp and grad

* - weight functions for 1d,2d,3d
- link the indices to the kernel
- link the fields to the kernel
- link the basis to the kernel

* Add the qFunction reader + inlining

* Add qf files for the tests.

* Add qf file for ceed/ex1

* Add qf file for mfem/bp1

* All tests pass.

* Add qFunction for mfem/bp3, petsc/bp1, and petsc/bp3.

* mfem/bp1 passes + remove dead code

* Fix a bug in n_quads_out for writeQuads

* mfem/bp3 passes.

* All tests all examples pass.

* Temporary tweaks for mfem benchmarking

* Add Context management.

* Modify .qf files to take into account the context.

* Enable optimizations.

* First set of optimization for 2D and 3D.

* double pointer format for the qFunction.

* Change the .qf files to have the same code as the C functions.

* Make previous Cuda backends use .qf files.

* Add a return value to qFunctions.

* Make cpu backends use .qf files.

* Minor: clean commented code.

* Add guarded math.h for petsc examples.

* Remove previous nek qf files.

* Remove .cu files.

* Remove .qf files.

* Remove dead code in the tests.

* make style

* Make style fix.

* more make style fixes.

* CEED_QFUNCTION - improve macro for CPU filenames

* Add CEED_QFUNCTION macro to navierstokes.c

* Fix PETSc gitignore

* Change default NS problemtype to density_current (#307) in navierstokes.c

* Fix petsc bp1.h

* Real Fix for petsc bp1.h...

* fix

* README - Add /gpu/cuda/gen

* PETSc - Update dmplex example to use *_loc

* cuda/reg - fix typo

* Revert a couple of small changes

* Fix a bug in mfem bp3 similar to the previous bug in petsc bp3.

* Make PETSc qfunctions look closer to master, and minor style for debugging.

* More uniformity changes

* Fix a strange CUDA_OUT_OF_RESSOURCE bug.

* NS - fix fname variables

* Use a different convention for qFunction ncomp.

* update cuda-gen backend and bpsdmplex.

* PETSc - style update

* update mfem bp1 and bp3.

* Interface - Use size instead of ncomp for QFunction fields

* update ceed example and tests.

* Tests - Update ncomp to size

* CPU Backends - Update ncomp to size

* CPU Backends - style

* Nek - Update ncomp to size

* Opt - fix style

* CUDA - update ncomp to size

* Doc - Update API documentation for QFunction \ncomp->size

* OCCA - Patch QFunction ncomp -> size, work but revamp will be better

* OCCA - assert dim>0 for clang-tidy

* CUDA - Change GetNumComp to GetSize

* Basis - Shift check for dim > 0 to interface

* Doc update

* Update NS field size

* NS - Fix problem options

show more ...

Merge pull request #316 from CEED/jeremy/codecov

Update Codecov

Change EXCL_END -> EXCL_STOP

Add additional LCOV_EXCL tags

Merge pull request #185 from CEED/fortran-ctx

Improve QFunction ctx for Fortran interface

Add t401 to test QFunction with context