Merge branch 'jolivet/fix-gcc16-warnings' into 'main'

Fix -Wunused-but-set-variable

See merge request petsc/petsc!8887

Fix -Wunused-but-set-variable

src/dm/dt/fe/interface/fe.c:2420:41: warning: variable ‘g’ set but not used [-Wunused-but-set-variable=]
2420 | PetscInt dOffset = 0, fOffset = 0, f, g;
|

Fix -Wunused-but-set-variable

src/dm/dt/fe/interface/fe.c:2420:41: warning: variable ‘g’ set but not used [-Wunused-but-set-variable=]
2420 | PetscInt dOffset = 0, fOffset = 0, f, g;
| ^
src/dm/field/impls/da/dmfieldda.c:31:17: warning: variable ‘c’ set but not used [-Wunused-but-set-variable=]
31 | PetscInt i, c, dim;
| ^
src/dm/impls/plex/plex.c:8007:28: warning: variable ‘newP’ set but not used [-Wunused-but-set-variable=]
8007 | for (PetscInt p = 0, newP = 0, o = fStart, oNew = fNewStart; p < numPoints; p++) {
| ^~~~
src/ts/utils/dmplexlandau/plexland.c:351:39: warning: variable ‘loc_fdf_idx’ set but not used [-Wunused-but-set-variable=]
351 | for (PetscInt ei_r = 0, loc_fdf_idx = 0; ei_r < numCells[grid_r]; ++ei_r) {
| ^~~~~~~~~~~

show more ...

Merge branch 'jolivet/clang-format-21' into 'main'

clang-format-21

See merge request petsc/petsc!8202

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'

show more ...

Merge branch 'MarDiehl/fix-typo' into 'main'

missing "s" for isascii and issundials

See merge request petsc/petsc!8559

missing "s" for isascii and issundials

Merge branch 'jolivet/clang-format-20' into 'main'

clang-format-20

See merge request petsc/petsc!7849

Update to clang-format-20

Merge branch 'jolivet/remove-unneeded-mpicast' into 'main'

Remove unneeded PetscMPIIntCast() for routines using PetscCount

Closes #1661

See merge request petsc/petsc!8099

Remove unneeded PetscMPIIntCast() for routines using PetscCount

Fix #1661

Merge branch 'stefanozampini/useless-cast' into 'main'

Remove useless cast

See merge request petsc/petsc!7894

Brain dead fixes for useless casts

Merge branch 'jolivet/clang-format-19' into 'main'

clang-format-19

See merge request petsc/petsc!7644

Remove unneeded parentheses

Merge branch 'barry/2024-09-02/rebased-fix-conversion-warnings' into 'main'

Compiler finds (and forbid) casts from higher precision integers to lower

See merge request petsc/petsc!7806

Fix MPIU_* routines to always return MPI error codes and thus be usable with PetscCallMPI()

Introduce MPIU_Count to be used when MPI_Count is not available

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in th

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in the CI

show more ...

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

CI: update to clang-format-18

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...

checkbadSource: rules for PetscFunctionBegin and derivatives

Merge branch 'jolivet/fix-ubsan' into 'main'

Pacify UBSan

See merge request petsc/petsc!7158

Sys: add PetscSafePointerPlusOffset() to pacify UBSan

Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'

Feature: Non-discardable PetscErrorCode

See merge request petsc/petsc!5923

Make PetscErrorCode a non-discardable enum