Fix warnings in NVIDIA compilers (formerly PGI): unreachable statement

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge branch 'master' into jpusztay/feature-swarm-symplectic-example

Merge branch 'master' into jpustay/feature-swarm-example

Merged petsc/petsc into master

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (393 commits)
Bib: Update reference
Mat: Doc fix
Bib: Updated ref
PetscDS: Doc fixes
PC+LU: Do not try to refactor an already factored matrix
Mat: Small fix for checking and docs
Mat: Added MatSetFactorType() - Needed it when making a shell matrix look factored
PetscDS: Added PetscDSUpdateBoundary() - Lets the user change the boundary condition
single precision produces different convergence history
p4est: has a dependency on zlib - so handle it correctly
Add -mat_mffd_complex to use the Lyness complex number trick to compute J_u * v instead of differencing.
Replace VecWAXPY by VecAXPY if needed
Revert "Replace VecWAXPY by VecAXPY if needed"
Replace VecWAXPY by VecAXPY if needed
MatHermitianTransposeGetMat and MatCreateVecs
ex19: Updated test filter to avoid false positives.
DM: Improved Global-To-Natural docs Suggested-by: Josh L <ysjosh.lo@gmail.com>
Do not build shared openblas when doing static build
Upgrade OpenBLAS to 0.3.3
test: add alt output file for changes in OSX-10.14 and Xcode-10.0 [perhaps related to ML]
...

Conflicts:
src/vec/is/utils/vsectionis.c

show more ...

Merged petsc/petsc into master

Merge branch 'dalcinl/glvis' [PR #1153]

* dalcinl/glvis:
GLVis Enhancements
GLVis: Add command line options
GLVis: Change visualization defaults for 1D/2D mesh/solution
GLVis: Add command line optio

Merge branch 'dalcinl/glvis' [PR #1153]

* dalcinl/glvis:
GLVis Enhancements
GLVis: Add command line options
GLVis: Change visualization defaults for 1D/2D mesh/solution
GLVis: Add command line options to send arbitrary keys and commands
GLVis: Refactor implementation for DMs and Vec
Do not use nonlocal returns (setjmp/longjmp) for I/O error handling.
Add PetscGLVisCollective{Begin|End}() to handle closed windows.
Remove duplicated code in Plex and DA, use instead a routine with a callback in charge of dumping data to the GLVis server.

show more ...

GLVis: Refactor implementation for DMs and Vec

* Do not use nonlocal returns (setjmp/longjmp) for I/O error handling.
* Add PetscGLVisCollective{Begin|End}() to handle closed windows.
* Remove dupli

GLVis: Refactor implementation for DMs and Vec

* Do not use nonlocal returns (setjmp/longjmp) for I/O error handling.
* Add PetscGLVisCollective{Begin|End}() to handle closed windows.
* Remove duplicated code in Plex and DA, use instead a routine
with a callback in charge of dumping data to the GLVis server.

show more ...

Merge branch 'stefano_zampini/fix-pcksp-fetidp-maint' [PR #1145]

Merge branch 'stefano_zampini/fix-pcksp-fetidp-maint' into maint [PR #1145]

DMDA: allow users to customize the HO coordinates (as in DMPLEX)

added test

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (440 commits)
revert sources to dev - reset PETSC_VERSION_RELEASE - reset changes/dev.html
release: set v3.9 strings
fix grep us

Merge branch 'master' into knepley/feature-pc-patch

* master: (440 commits)
revert sources to dev - reset PETSC_VERSION_RELEASE - reset changes/dev.html
release: set v3.9 strings
fix grep usage on solaris [use egrep]
opensolaris: fix errors
Update timer reporting and minor reporting fix
Remove redundant if statement. Found by @jedbrown
Fixed problem with order of developer photos on website.
superlu_dist: use correct flag in example [PETSC_HAVE_SUPERLU -> PETSC_HAVE_SUPERLU_DIST]
Bib: PERMON ref
fix for osx
doc: more author fixes
doc: more author fixes
Italicized "orderings" in MPI process placement discussion.
Added Richard to the user manual author list.
Added Richard to the list of active developers on the website.
add string check for MS-MPI and IMPI timeout errors
opensolaris does not have multiple grep utils - but default one does not support -F. So use fgrep instead
Standardizing timeout checks
Report wall clock time of total tests
Use time instead of date %s
...

Conflicts:
include/petscpc.h
src/ksp/ksp/interface/itfunc.c

show more ...

Merge branch 'stefano_zampini/fix-matis-dmda-l2g'

PETSCVIEWERGLVIS: Fix defaults for constructor

DMDA defaults to left-looking, that matches the layout obtained from DMDAGetElements

Merge branch 'stefano_zampini/feature-glvis-homesh-periodic'

Use "size" in place of "commsize" for MPI_Comm_size()

Fixes from nightly builds

Merge branch 'barry/move-to-new-test-harness' into barry/all-new-test-harness-branches

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if m

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if malloc is already set
Plex: Fixed array initialization
pgi: compile fix
knl: update test to use memkind and remove option that worked arround a bug with intel 17
Check the return value for memkind_posix_memalign
Change the default behavour for -malloc_hbw
Bib: More refs
test: remove runex13f90 as its now converted to new test suite
fix win32 crash. This test was previously run with '-n 4' - so restoring it
Fix petscsfgetgraph_ to work for all Fortran compilers by directly using array of PetscSFNodes
bugfix for MatDuplicate_MPIAIJ_PtAP Reported-by: Samuel Lanthaler <s.lanthaler@gmail.com>
strip out dead sundials usage code; change sundials test to only run 5 timesteps to prevent different number of steps on different systems.
Remove extra lines of output file
Example uses C99 constructs so must mark with requires: c99
fix const missmatch for DMDAVecRestoreArrayRead()
remove conflict between function name in example and new PETSc TS function
builds: attempt to do maint/master/next test builds in separate clones
ex62: it turned out that CHACO partioning is not deterministic. Use a prescribed partition instead
...

Conflicts:
src/dm/interface/dm.c
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with updated 17.10 compilers
Fix for test dirs that are not tutorials/tests
fix use of double in PetscAbsReal() which produces compiler warnings with single precision build
elemental: remove info on conflict of -with-cxx-dialect=C++11 on osx - it works now.
Cleanup .bib files
Fix allfortranstubs rule to rm generated files from correct directory, not outdated location
ierr set but not checked
Remove initial refine so test runs faster and does not time out on some machines
Gail's copyedits for bibtex items
Docs: manual: add further description of 3 different current testing options
DM: check for ops->localtolocalbegin/end before calling
PetscSF: fix typo in tutorial ex1
Vec+HDF5: Fix output for complex - Need to check for empty group name
SNES: SNESDestroy() can be called with snes->dm == NULL
SNES: SNESDestroy() can be called with snes->dm == NULL
Vec+HDF5: Fix output for complex - Need to check for empty group name
Docs: Manual: Update tests section
gmakegentest: also exclude .#filenames created by emacs
DMPlex: Fix output of test ex1 after changes to Gmsh reader
...

show more ...