Merge remote-tracking branch 'origin/release'

Fix error checking in DMDA for periodic cases where it cannot handle periodic boundary conditions

Also add error checking to MatFDColoring() to check for bad coloring input.

Also fix bug where call

Fix error checking in DMDA for periodic cases where it cannot handle periodic boundary conditions

Also add error checking to MatFDColoring() to check for bad coloring input.

Also fix bug where call to ISColoringGetIS() where the is already exists and the caller requests PETSC_OWN_POINTER

Reported-by: Richard Katz <richard.katz@earth.ox.ac.uk>

show more ...

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGER
Pass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]
Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXX

The compiler will now automatically prevent you from using the wrong argument type for the first three bullets above
This will also require an update sowing with the new sowing branch this MR is using.

show more ...

Merge remote-tracking branch 'origin/release'

Minor docs fixes

Update to sowing version that supports PetscViewer and PetscObject

Remove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowing

Also handles the passing of null

Update to sowing version that supports PetscViewer and PetscObject

Remove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowing

Also handles the passing of null objects correctly

show more ...

Update source code removing all unneeded /*@C and associated manual stubs and interfaces

simple fixes for DMDA manual pages

DA: Fix setting boundary type from options

DA: Use the DM periodicity mechanism

DM+DA: Fix bounding box for periodicity
- Fix Locate to respect periodicity

Remove some unneeded parentheses

Remove carriage return in Petsc(Assert|Check)()

git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'

Suggested-by: Stefan

Remove carriage return in Petsc(Assert|Check)()

git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'

Suggested-by: Stefano Zampini

show more ...

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...