Merge branch 'jacobf/2021-03-26/clang-static-linter' into 'main'

Feature: libClang PETSc Macro Static Analyzer

See merge request petsc/petsc!3773

Linter using libClang that checks PetscValidHeaderSpecifcType, PetscValidHeaderSpecific, PetscValidHeader, PetscValid[XXX]Pointer, PetscValidType, PetscCheckSameComm, PetscValidLogicalCollectiveXXX f

Linter using libClang that checks PetscValidHeaderSpecifcType, PetscValidHeaderSpecific, PetscValidHeader, PetscValid[XXX]Pointer, PetscValidType, PetscCheckSameComm, PetscValidLogicalCollectiveXXX for validity. Automatically generates diff files for problems with a known solution.

show more ...

Merge branch 'barry/2020-11-24/central-patch' into 'master'

Barry/2020 11 24/central patch

See merge request petsc/petsc!3440

Provide an example src/dm/tutorials/ex25.c that takes a patch from a parallel DMDA to one process

Fix DMZoomPatch() to work in 2d and and support not requesting a halo

Remove unneeded Vec argument

Provide an example src/dm/tutorials/ex25.c that takes a patch from a parallel DMDA to one process

Fix DMZoomPatch() to work in 2d and and support not requesting a halo

Remove unneeded Vec argument from DMZoonPatch()

Minor improvements to manual pages

Commit-type: bug-fix, feature, example
/spend 4h
Reported-by: Victoria Hamtiaux <victoria.hamtiaux@uclouvain.be>

show more ...

Merge branch 'dalcinl/fix-null' into 'master'

Fix 0 -> NULL for pointers

See merge request petsc/petsc!3086

DM: Replace 0 -> NULL for pointers

Merged in dalcinl/dm-api (pull request #1850)

DM interface

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

DM: Deprecate DMCreateAggregates()

* This interface is untested and may be redundant
* DMDA is the only provider, keep it as DMDACreateAggregates()

DM: Simplify implementation of DMHasCreateInjection()

* Add log event for DMCreateInjection()
* Get rid of DMHasCreateInjection_Default()
* Rename dm->ops->getinjection to dm->ops->createinjection
*

DM: Simplify implementation of DMHasCreateInjection()

* Add log event for DMCreateInjection()
* Get rid of DMHasCreateInjection_Default()
* Rename dm->ops->getinjection to dm->ops->createinjection
* Improve error checking here and there

show more ...

Merged in barry/update-collective-on (pull request #1744)

Update the use of Collective on in the manual pages to reflect the new style

Update the use of Collective on in the manual pages to reflect the new style

Commit-type: style-fix, documentation
Thanks-to: Patrick Sanan <patrick.sanan@gmail.com>

Merged in psanan/man-pages-remove-keywords (pull request #1717)

Man pages: Remove .keywords fields

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be unif

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be uniformly used or maintained.

Thus, remove all .keywords: fields, and a following blank line, if present.

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find src/ -type f -exec gsed -i '/keywords:/d' {} +
find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find include/ -type f -exec gsed -i '/keywords:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'barry/tao-to-new-test-harness' into barry/all-new-test-harness-branches

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (60 commits)
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warni

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (60 commits)
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warning
Plex ex26: Protect ExodusII stuff
DM: DMCreateSubDM() field argument should be const
TS ex46: Newlines and some numerical jitter
TS ex45: Newlines and some numerical jitter
TS ex11: Fixed indentation and time step numbering
SNES ex12: Update for DM view changes
Plex tests: Update to new DM output
Plex ex23: Use Nc not dim for vector fields
Plex: Default section now ignores cells hanging off boundary meshes
Plex: Viewer now reports the cell Height
Increase patchlevel to 3.8.3
Plex: Fixed DMPlexInterpolate() bugs - Do not copy associated data if we are not interpolating - Do not interpolate if we already have full depth
fix valgrind errors with using PetscObjectGetName()/SetName() with the same object - resulting in a free() before copy.
ex4: fix compile warning and update makefile
Minor fixes
Improving report_tests
PetscDS: Must initialize the default adjacency
...

Conflicts:
include/petsc/private/dmimpl.h
include/petscdm.h
include/petscis.h
src/dm/impls/plex/plexcreate.c

show more ...

Merge branch 'master' into knepley/feature-plex-exodus-update

* master:
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warning
Plex ex26

Merge branch 'master' into knepley/feature-plex-exodus-update

* master:
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warning
Plex ex26: Protect ExodusII stuff
DM: DMCreateSubDM() field argument should be const
TS ex46: Newlines and some numerical jitter
TS ex45: Newlines and some numerical jitter
TS ex11: Fixed indentation and time step numbering
SNES ex12: Update for DM view changes
Plex tests: Update to new DM output
Plex ex23: Use Nc not dim for vector fields
Plex: Default section now ignores cells hanging off boundary meshes
Plex: Viewer now reports the cell Height
DM: Check IS block size in DMCreateSubDM()
DM: DMCreateSubDM() should take a const array
Plex ex26: Test for FEM dof layout and DMCreateSubDM() Contributed-by: Blaise A Bourdin <bourdin@lsu.edu>

show more ...

Merge remote-tracking branch 'origin/knepley/feature-subdm-test'

DM: DMCreateSubDM() field argument should be const

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
superlu: libray is installed in PREFIX/lib64 - fix this to use PREFIX/lib
backport fixes cc105cc3 2b35c90a - required for 3bf428d - that was backported from master - 80c96bb
'echo -n' fails on opensolaris/osx - so avoid using it.
fix diffs in nightlybuilds due to options in ~/.petscrc
add Kelley03 to src/docs/tex/petsc.bib
build: determine moudles, mpi.h used during buildtime and print in 'info'
fix analyzer warnings
fix build failure on opensolaris - where -lm from flibs is removed due to -lm in cxxlibs. But then - only flib gets used for some configure tests [blaslapack, parms]
config: prefer __restrict over C99 restrict keyword
...

show more ...

Merge branch 'barry/remove-funct'

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-t

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-to: Andreas Mang <andreas@ices.utexas.edu>

show more ...