Merge branch 'jose/release/pgi-20.9-warnings' into 'release'

Fix warnings in NVIDIA compilers (formerly PGI)

See merge request petsc/petsc!3397

Fix warnings in NVIDIA compilers (formerly PGI): unreachable statement

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merged in barry/update-collective-on (pull request #1744)

Update the use of Collective on in the manual pages to reflect the new style

Update the use of Collective on in the manual pages to reflect the new style

Commit-type: style-fix, documentation
Thanks-to: Patrick Sanan <patrick.sanan@gmail.com>

Merged in psanan/man-pages-remove-keywords (pull request #1717)

Man pages: Remove .keywords fields

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be unif

Man pages: remove .keywords: fields

This field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),
but it doesn't seem to be uniformly used or maintained.

Thus, remove all .keywords: fields, and a following blank line, if present.

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find src/ -type f -exec gsed -i '/keywords:/d' {} +
find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} +
find include/ -type f -exec gsed -i '/keywords:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead

Merge branch 'master' into knepley/feature-snes-ex13-spectral

* master: (2350 commits)
migrate warning fix from next-tmp
Revert "Remove dead code."
clarifying comment in the code
Remove dead code.
Add JuMP citation
Copyedits and updates to developers manual
Add more protection to intrinsics
MPI: protect arguments in MPI macros
Add the missing conditionals for 64-bit build
Plex+VTK: Fix field type determination
Fix bug in name cleanup
Bib: Added ref
Plex+VTK: Fix field type determination
Plex: Updated test output - I am now hating this shit
forgot to save file after moving prototypes to petscsys.h
update Apple example project settings per Xcode
Two functions should actually be public, used, for example from Apple MacOS and iOS programs
includes should always be included relative to include directory
Apple removed old locations of docsets
SNES ex12: Updated test output
...

Conflicts:
src/snes/examples/tutorials/ex13.c

show more ...

Merge branch 'barry/tao-to-new-test-harness' into barry/all-new-test-harness-branches

Merge branch 'barry/move-to-new-test-harness' into barry/all-new-test-harness-branches

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (60 commits)
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warni

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (60 commits)
petsc4py: update to use latest 3.8 snapshot
petsc4py: update to snapshot that syncs with 276c550
fix warning
Plex ex26: Protect ExodusII stuff
DM: DMCreateSubDM() field argument should be const
TS ex46: Newlines and some numerical jitter
TS ex45: Newlines and some numerical jitter
TS ex11: Fixed indentation and time step numbering
SNES ex12: Update for DM view changes
Plex tests: Update to new DM output
Plex ex23: Use Nc not dim for vector fields
Plex: Default section now ignores cells hanging off boundary meshes
Plex: Viewer now reports the cell Height
Increase patchlevel to 3.8.3
Plex: Fixed DMPlexInterpolate() bugs - Do not copy associated data if we are not interpolating - Do not interpolate if we already have full depth
fix valgrind errors with using PetscObjectGetName()/SetName() with the same object - resulting in a free() before copy.
ex4: fix compile warning and update makefile
Minor fixes
Improving report_tests
PetscDS: Must initialize the default adjacency
...

Conflicts:
include/petsc/private/dmimpl.h
include/petscdm.h
include/petscis.h
src/dm/impls/plex/plexcreate.c

show more ...

Merge remote-tracking branch 'origin/knepley/fix-plex-interpolation-consistency'

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if m

Merge branch 'master' into knepley/feature-plex-adjoint-prelim

* master: (251 commits)
yaml: add a backup download URL
Fix documentation of MatSetRandom function
Ignore -malloc-hbw option if malloc is already set
Plex: Fixed array initialization
pgi: compile fix
knl: update test to use memkind and remove option that worked arround a bug with intel 17
Check the return value for memkind_posix_memalign
Change the default behavour for -malloc_hbw
Bib: More refs
test: remove runex13f90 as its now converted to new test suite
fix win32 crash. This test was previously run with '-n 4' - so restoring it
Fix petscsfgetgraph_ to work for all Fortran compilers by directly using array of PetscSFNodes
bugfix for MatDuplicate_MPIAIJ_PtAP Reported-by: Samuel Lanthaler <s.lanthaler@gmail.com>
strip out dead sundials usage code; change sundials test to only run 5 timesteps to prevent different number of steps on different systems.
Remove extra lines of output file
Example uses C99 constructs so must mark with requires: c99
fix const missmatch for DMDAVecRestoreArrayRead()
remove conflict between function name in example and new PETSc TS function
builds: attempt to do maint/master/next test builds in separate clones
ex62: it turned out that CHACO partioning is not deterministic. Use a prescribed partition instead
...

Conflicts:
src/dm/interface/dm.c
src/snes/examples/tutorials/ex13.c

show more ...

Plex: Update to new Interpolate interface

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with

Merge branch 'master' into knepley/fix-plex-bc-multiple

* master: (347 commits)
tests: add 'PETSC_HAVE_C99' flag - so that 'requires: c99' can be used in the test suite
PGI: fix build error with updated 17.10 compilers
Fix for test dirs that are not tutorials/tests
fix use of double in PetscAbsReal() which produces compiler warnings with single precision build
elemental: remove info on conflict of -with-cxx-dialect=C++11 on osx - it works now.
Cleanup .bib files
Fix allfortranstubs rule to rm generated files from correct directory, not outdated location
ierr set but not checked
Remove initial refine so test runs faster and does not time out on some machines
Gail's copyedits for bibtex items
Docs: manual: add further description of 3 different current testing options
DM: check for ops->localtolocalbegin/end before calling
PetscSF: fix typo in tutorial ex1
Vec+HDF5: Fix output for complex - Need to check for empty group name
SNES: SNESDestroy() can be called with snes->dm == NULL
SNES: SNESDestroy() can be called with snes->dm == NULL
Vec+HDF5: Fix output for complex - Need to check for empty group name
Docs: Manual: Update tests section
gmakegentest: also exclude .#filenames created by emacs
DMPlex: Fix output of test ex1 after changes to Gmsh reader
...

show more ...

Merge branch 'maint'

* maint:
Spell check: interger -> integer
petscsys.h : partial man page cleanup
configure exodusii: pass HDF5_DIR to Exodus cmake
Docs: DMPlex man page and source commen

Merge branch 'maint'

* maint:
Spell check: interger -> integer
petscsys.h : partial man page cleanup
configure exodusii: pass HDF5_DIR to Exodus cmake
Docs: DMPlex man page and source comments fixes
Docs: Manual: clarifications for DMPlex chapter

show more ...

Merged in psanan/petsc-docproject/psanan/dmplex-docs-update (pull request #773)

Psanan/dmplex docs update

Approved-by: Matthew Knepley <knepley@gmail.com>

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Docs: DMPlex man page and source comments fixes

* remove sieve mentions from all DMPlex man pages and source comments
* DMPlexSymmetrize man page: typo fix
* DMPlexCreateExodusFromFile man page: fix

Docs: DMPlex man page and source comments fixes

* remove sieve mentions from all DMPlex man pages and source comments
* DMPlexSymmetrize man page: typo fix
* DMPlexCreateExodusFromFile man page: fix function name
* DMPlexCreateCubeBoundary man page typo fix

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'scott/test-datafiles-fix' of https://bitbucket.org/petsc/petsc into scott/test-datafiles-fix

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into stefano_zampini/feature-fetidp-ex69