Plex: Fix geometry check

Merge branch 'knepley/feature-embedded-manifold' into 'main'

Plex+PetscFE: Fixes to allow embedded manifolds

See merge request petsc/petsc!8141

Plex+PetscFE: Fixes to allow embedded manifolds
- Add PetscFEGeomMode to describe geometry
- Reorganized PetscFEGeom
- PetscFEGeomCreate(), DMFieldCreateFEGeom() and DMSNESGetFEGeom() now take the Pe

Plex+PetscFE: Fixes to allow embedded manifolds
- Add PetscFEGeomMode to describe geometry
- Reorganized PetscFEGeom
- PetscFEGeomCreate(), DMFieldCreateFEGeom() and DMSNESGetFEGeom() now take the PetscFEGeomMode
- J and invJ have dE dimensions
- f1, g1, g2, g3 have dE dimensions
- FIX the dim argument of all point function is really dE because it is used to index the gradients
- Clarified behavior of PetscFEGeomGetCellPoint()
- Now -dm_plex_coordinate_dim can change the coordinate dimension of a mesh created by Plex
- Implicit cell geometry must be used when dim != cdim

show more ...

Merge branch 'jose/warning-plexgeometry' into 'main'

Fix compile warning in plexgeometry.c

See merge request petsc/petsc!8083

Fix compile warning in plexgeometry.c

In file included from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscsys.h:1258,
from /home/gitlab-runner/builds/q8svuz_Y/0/sle

Fix compile warning in plexgeometry.c

In file included from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscsys.h:1258,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscvec.h:8,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscmat.h:6,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petsc/private/dmpleximpl.h:3,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:1:
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c: In function 'DMPlexLocatePoint_Internal':
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:563:216: error: array subscript 2 is above array bounds of 'PetscReal[2]' {aka 'double[2]'} [-Werror=array-bounds]
563 | if (!found) PetscCall(PetscInfo(dm, "Point (%g, %g, %g) != Mapped Ref Coords (%g, %g, %g) with error %g\n", (double)pointR[0], (double)pointR[1], (double)pointR[2], (double)real[0], (double)real[1], (double)real[2], (double)inverseError));
| ~~~~^~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscerror.h:557:28: note: in definition of macro 'PetscCall'
557 | ierr_petsc_call_q_ = __VA_ARGS__; \
| ^~~~~~~~~~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:563:27: note: in expansion of macro 'PetscInfo'
563 | if (!found) PetscCall(PetscInfo(dm, "Point (%g, %g, %g) != Mapped Ref Coords (%g, %g, %g) with error %g\n", (double)pointR[0], (double)pointR[1], (double)pointR[2], (double)real[0], (double)real[1], (double)real[2], (double)inverseError));
| ^~~~~~~~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:557:15: note: while referencing 'real'
557 | PetscReal real[2], inverseError = 0, normPoint = DMPlex_NormD_Internal(dimC, pointR);
| ^~~~
In file included from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscsys.h:1258,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscvec.h:8,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscmat.h:6,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petsc/private/dmpleximpl.h:3,
from /home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:1:
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:563:165: error: array subscript 2 is above array bounds of 'PetscReal[2]' {aka 'double[2]'} [-Werror=array-bounds]
563 | if (!found) PetscCall(PetscInfo(dm, "Point (%g, %g, %g) != Mapped Ref Coords (%g, %g, %g) with error %g\n", (double)pointR[0], (double)pointR[1], (double)pointR[2], (double)real[0], (double)real[1], (double)real[2], (double)inverseError));
| ~~~~~~^~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/include/petscerror.h:557:28: note: in definition of macro 'PetscCall'
557 | ierr_petsc_call_q_ = __VA_ARGS__; \
| ^~~~~~~~~~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:563:27: note: in expansion of macro 'PetscInfo'
563 | if (!found) PetscCall(PetscInfo(dm, "Point (%g, %g, %g) != Mapped Ref Coords (%g, %g, %g) with error %g\n", (double)pointR[0], (double)pointR[1], (double)pointR[2], (double)real[0], (double)real[1], (double)real[2], (double)inverseError));
| ^~~~~~~~~
/home/gitlab-runner/builds/q8svuz_Y/0/slepc/petsc/src/dm/impls/plex/plexgeometry.c:529:16: note: while referencing 'pointR'
529 | PetscReal pointR[2], ref[2], error;
| ^~~~~~
cc1: all warnings being treated as errors
gmake[3]: *** [gmakefile:201: arch-gnu-lint/obj/src/dm/impls/plex/plexgeometry.o] Error 1

show more ...

Merge branch 'zach/dmplex-locate-high-order-hex' into 'main'

Plex: Use FE to locate points in higher-order geometry

See merge request petsc/petsc!8062

Fix use of PetscScalar/Real

Plex: Use relative tolerances when locating points

Plex: Use FE to locate points in higher-order geometry

Merge branch 'stefanozampini/useless-cast' into 'main'

Remove useless cast

See merge request petsc/petsc!7894

Brain dead fixes for useless casts

Merge branch 'knepley/feature-hamiltonian-ex2-opt' into 'main'

Fix Hamiltonian ex2 for Landau Damping

See merge request petsc/petsc!7937

DMSwarm: Allow multiple fields to define the DM field and multiple cellDM, allow different coordinate fields, and compute moments
- Changed interface for DMSwarmVectorDefineField() and DMSwarmVectorG

DMSwarm: Allow multiple fields to define the DM field and multiple cellDM, allow different coordinate fields, and compute moments
- Changed interface for DMSwarmVectorDefineField() and DMSwarmVectorGetField() to allow multiple fields
- Add DMSwarmReplace_Internal()
- Add coordinate name to Swarm
- Add DMSwarmGetCoordinateField() and DMSwarmSetCoordinateField()
- Add DMSwarmComputeMoments()
- In DMLocatePoints_Plex(), ignore extra coordinates in input vector
- Add CellDMInfo struct
- Add DMSwarmPushCellDM() and DMSwarmPopCellDM()

show more ...

Merge branch 'jolivet/clang-format-19' into 'main'

clang-format-19

See merge request petsc/petsc!7644

Remove unneeded parentheses

Merge branch 'barry/2024-09-02/rebased-fix-conversion-warnings' into 'main'

Compiler finds (and forbid) casts from higher precision integers to lower

See merge request petsc/petsc!7806

Fix MPIU_* routines to always return MPI error codes and thus be usable with PetscCallMPI()

Introduce MPIU_Count to be used when MPI_Count is not available

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in th

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in the CI

show more ...

Merge branch 'knepley/fix-periodic-grid-hash' into 'main'

Plex: Fix grid hashing for periodic meshes

See merge request petsc/petsc!7609

Plex: Fix grid hashing for periodic meshes

Merge branch 'barry/2024-04-13/fix-sowing-strings' into 'main'

Update PETSc to use sowing bfort that handles string arguments and PETSC_NULL_INT

See merge request petsc/petsc!7480

Update source code removing all unneeded /*@C and associated manual stubs and interfaces

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2024-04-24/doc-fixes/release' into 'release'

release docs fixes

See merge request petsc/petsc!7498

release docs fixes

Commit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, example
Funded-by:
Project:
Time: hours
Reported-by:

release docs fixes

Commit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, example
Funded-by:
Project:
Time: hours
Reported-by:
Thanks-to:
Development Tools: Vim, Emacs, Eclipse

show more ...