Avoid empty initialized braces, a problem in C89 [nightlies]

Fix various compiler warnings and add PetscFunctionBegin

Merge remote-tracking branch 'origin/barry/fix-dead-variables'

Merge remote-tracking branch 'origin/stefano_zampini/feature-glvis-viewer-fixdmdependency2'

Merge branch 'dmay/swarm-pic-tools-v3.8'

clang analyzer fixes

Fix many dead assignments, mostly due to missing CHKERRQ(ierr);

Commit-type: style-fix
Reported-by: clang static analyzer

Fixed C89 compilation errors (C++ comments, comma at end of enumerator)

http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2017/07/25/make_next_arch-linux-c89_el6.log

Fix conflict in makefile when merging dmay/swam-pic-tools into master

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Added initial implementation of GLVis viewer

Merge branch 'scott/test-datafiles-fix' of https://bitbucket.org/petsc/petsc into scott/test-datafiles-fix

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into stefano_zampini/feature-fetidp-ex69

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]' to showup in '-help' Reported-by: Mark Adams <mfadams@lbl.gov>
Plex: Remove dead code
TS tutorials ex11: remove unused functions
TSAdapt: Set TSADAPTNONE as default adapt type
DMPlex: missed viewer change in synchronized output
Revert "Merge branch 'hzhang/ts-ex9busdmnetwork'"
TSAdapt: Update changes/dev.html
TSAdapt: Set default type for TSGLEE
TS tutorials ex11: make work with complex scalars
Bib: Added ref
TS ex18: Fix initializer
TS ex11: Fix M_PI
Plex ex1f90: FUCK FORTRAN
f2cblaslapack: remove duplicate xerbla.o and xerbla_array.o from lapack [they are already in blas]
TSAdapt: Refactor handling of default adapt type
TSAdapt: Update changes/dev.html
TSAdapt: Update manual
TSAdapt: Refactor interface and implementations
...

show more ...

Merge branch 'tisaac/feature-plex-tests-new'

This merge changes PetscSpace and PetscQuadrature to have a number of
components, so that vector-valued functionals can be defined for
non-Lagrange finit

Merge branch 'tisaac/feature-plex-tests-new'

This merge changes PetscSpace and PetscQuadrature to have a number of
components, so that vector-valued functionals can be defined for
non-Lagrange finite elements. Along the way, this branch also converts
the regression tests related to DMPlex that were in config/builder.py to
the new test harness, and makes lots of changes necessary for them to
be portable tests.

* tisaac/feature-plex-tests-new: (263 commits)
TS tutorials ex11: remove unused functions
DMPlex: missed viewer change in synchronized output
TS tutorials ex11: make work with complex scalars
TS ex18: Fix initializer
TS ex11: Fix M_PI
Plex ex1f90: FUCK FORTRAN
TS tutorials ex11: use a union when punning
silence compiler warnings
SNES tutorials ex56: set partitioner from options
Plex: once again, MPI_Barrier() can't be used to synch output
windows compile fixes balay@ps4 ~/petsc/src/ts/examples/tutorials $ make PETSC_DIR=$HOME/petsc ex11 /home/balay/petsc/bin/win32fe/win32fe cl -o ex11.o -c -MD -wd4996 -Z7 -I/home/balay/petsc/include -I/home/balay/petsc/arch-mswin-uni/include -I/home/balay/petsc/include/petsc/mpiuni `pwd`/ex11.c ex11.c C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(300): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)' C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(301): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)' C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(370): error C2229: struct '<unnamed-tag>' has an illegal zero-sized array C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(463): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)' C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(505): error C2229: struct '<unnamed-tag>' has an illegal zero-sized array C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(724): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)' C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(728): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)' C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1179): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1184): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1191): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1194): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1383): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1521): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1522): warning C4090: 'function': different 'const' qualifiers C:\cygwin64\home\balay\petsc\src\ts\examples\TUTORI~1\ex11.c(1523): warning C4090: 'function': different 'const' qualifiers
PetscMath: check for math functions by function pointer resolvability
another windows fix for log2() C:\cygwin64\home\petsc\PETSC~1.CLO\include\petscmath.h(28): warning C4273: 'log2': inconsistent dll linkage C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt\../ucrt/math.h(506): note: see previous definition of 'log2'
fix log2() compile error on windows /home/petsc/petsc.clone-4/include/petscmath.h:28:8: error: expected ‘)’ before ‘/’ token double log2(double); ^
SNES tutorials ex12: turn off complex for restart test
Add empty file to silence warnings
TS tutorials ex46: make output match floating point filter
TS tutorials ex18: remove unused flags
SNES tutorials ex69: use end of line anchor instead of word boundary
SNES tutorials ex69: portable word boundary regex
...

show more ...

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so a

Merge branch 'master' into knepley/feature-plex-torus

* master: (174 commits)
Bib: Another ref
Increase patchlevel to 3.7.6
Explicitly listing the LTO library causes difficulties on MacOS so avoid it
TSBDF: Update changes/dev.html
Added Fortran TaoType and TaoLineSearchType definitions
Add Fortran TaoType and TaoLineSearchType definitions
setblocksize for iscol_sub
TSBDF: Use standard TS API and options to control adaptivity
Bib: More refs and a correction
SNESTest: Bug-fix in SNESTest when threshold printing option is turned on.
fix warning and valgrind complains reported by the nightly tests
Section+Doc: Small doc fix
pflotran: switch to using the new upstream git repo
DMPlex: Error if attempt to partition a distributed graph with Chaco
fix complex build error
fix complex build
PetscError() did not properly copy over the specific error message when error type was PETSC_ERROR_INITIAL
TSAdapt: Refactor handling of the always_accept flag
Additional clarification for MatMeshToCellGraph() manual page
optimize MatCreateSubMatrix_MPIAIJ() by merging check of sameXXXDist() into one MPI_AllReduce
...

Conflicts:
config/BuildSystem/config/packages/med.py

show more ...

DMPlex geometry: make constants work for quad precision

DMSwarmPIC:
* Code fixes for complex builds

DMLocatePoints_Plex:
* Added early abort case for points outside the domain bounding box
* Added reporting of the method used to locate each point
* Added hack option flag to allow the number of boxe

DMLocatePoints_Plex:
* Added early abort case for points outside the domain bounding box
* Added reporting of the method used to locate each point
* Added hack option flag to allow the number of boxes to be set when using the grid hash method

show more ...

DMLocatePoints_Plex:
* Add info logging points/sec processed
* Added method PetscGridHashGetEnclosingBoxQuery() to get box and return true/false if point was located (or not). It is completely valid

DMLocatePoints_Plex:
* Add info logging points/sec processed
* Added method PetscGridHashGetEnclosingBoxQuery() to get box and return true/false if point was located (or not). It is completely valid that we are given a point to locate which is outside of all boxes.
* Added logic to re-use a star forest node list

show more ...

Merge branch 'tisaac/feature-fe-dual-apply' into tisaac/feature-plex-tests-new

There has unfortunately been a lot of interplay between our work to
change the petscspace/dualspace to accept vector co

Merge branch 'tisaac/feature-fe-dual-apply' into tisaac/feature-plex-tests-new

There has unfortunately been a lot of interplay between our work to
change the petscspace/dualspace to accept vector components, and the
work to transfer the tests in config/builder.py to the new test harness.
I'm merging them together to get them to play nice with each other, and
so that I only have one feature branch to handler when merging into
master/next.

* tisaac/feature-fe-dual-apply: (64 commits)
snes tutorials ex12: fix restart test arguments
nightly build fixes for arch-viennacl
fix run command to match the command in master/makefile. [the diff will be correct in master/next]
PetscFE: fix typo in for loop declaration
PetscPartitioner: use simple partitioning for regression tests
DT tests ex1: fix test arguments to match regression output
DT ex1: fix options
DMPlexCreateHexBoxMesh: no cells in z direction for 2D
PCBDDC: use %D for PetscInt printfs
Plex: helper function used in all cases now
Plex tests ex7: make partitions portable for testing
Plex: use MPIU_2INT instead of MPI_2INT
MatAIJ KLU: remove redefinition of SuiteSparse_long
DMPlexRefine_CTetgen() mimics DMPlexRefine_Tetgen()
DMPlexGenerate_Tetgen(): mimic ctetgen so it can be used equivalently
Plex: Cylinder fixes for complex
Plex ex1: Test for periodic cylinder
Plex: I think periodic cylinder is working
Plex ex1: Updated torus test
Plex: Torus can now be arbitrarily refined
...

show more ...

Merge branch 'knepley/feature-mantle-example' into stefano_zampini/feature-fetidp-ex69

Merge branch 'master' into knepley/feature-plex-tests-new

* master: (108 commits)
Bib: Added ref
Bib: Updated reference
Bib: Updated reference
Work around problems with Apple Xcode 8.3 and h

Merge branch 'master' into knepley/feature-plex-tests-new

* master: (108 commits)
Bib: Added ref
Bib: Updated reference
Bib: Updated reference
Work around problems with Apple Xcode 8.3 and handling of rpath argument with gfortran
help menu update for MatCreateSubMatrices() Reported-by: Brad Aagaard <baagaard@usgs.gov>
fix flops for PCApply_PBJacobi_1 and PCApply_PBJacobi_7 Reported-by: Pierre Jolivet <pierre.jolivet@enseeiht.fr>
TSRK: Fix FSAL optimization to not skip update and check or stages.
Travis-CI: Workaround too long TMPDIR in macOS with Open MPI
test: Fix type mismatch in KSP test.
test: Fix warnings from gfortran -Wconversion (OS X, Homebrew build)
MPIUNI: Silence GCC -Wconversion warnings
Fortran: Add error checking for incorrect PETSC_NULL_XXX argument when expecting function
fix test output per changes in 517c9301b2e9239931bfd644803fd6bb859387ea
MUMPS: update to version 5.1.1 with opensolaris compile fixes
TSRK: Mention 5BS in the changelog.
TSRK: Mention the new 5BS scheme in the manual.
fix 'unused variable' warning
Remove unused code
added hbw_realloc
fixed undefined ptr
...

Conflicts:
config/BuildSystem/config/packages/med.py

show more ...

remove outdated __FUNCT__ definition

Commit-type: style-fix