Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-08-09/fix-manualpage-rot' into 'main'

Stop make allmanpages if an error is detected. Otherwise errors are hidden and never fixed.

See merge request petsc/petsc!5510

Fix errors in manual pages that were hidden and passed the CI

ERROR Uses Input Parameter but has multiple input parameters in PetscObjectProcessOptionsHandlers() src/sys/objects/inherit.c
ERROR (Vec

Fix errors in manual pages that were hidden and passed the CI

ERROR Uses Input Parameter but has multiple input parameters in PetscObjectProcessOptionsHandlers() src/sys/objects/inherit.c
ERROR (VecStrideSum) Incomplete argument list (probably + with no - in vinv.c
ERROR (VecStrideSumAll) Incomplete argument list (probably + with no - in vinv.c
ERROR (MatFilter_AIJ) Incomplete argument list (probably + with no - in mpiaij.c
ERROR (DMPlexCreateNaturalVector) Incomplete argument list (probably + with no - in plexnatural.c
WARNING (hypre.c): argument with no description in PCSMG
WARNING (hypre.c): argument with no description in PCSMG
WARNING (hypre.c): argument with no description in PCSMG
WARNING (hypre.c): argument with no description in PCSMG
a=`cat /Users/barrysmith/Src/petsc/arch-classic-docs/manualpages.err | wc -l`; test ! $a -gt 0
gmake[3]: [makefile:376: allmanpages] Error 1 (ignored)

show more ...

Merge branch 'marboeuf/plex-naturalpointsf' into 'main'

Plex: create the natural point SF

See merge request petsc/petsc!5502

cleanup in plexnatural.c and linked examples

- make output of test26, ex26f90, and ex62f90 more terse
- Replace VecCreateLocalVector / VecDestroyLocalVector to get block size by VecGetLocalVectore /

cleanup in plexnatural.c and linked examples

- make output of test26, ex26f90, and ex62f90 more terse
- Replace VecCreateLocalVector / VecDestroyLocalVector to get block size by VecGetLocalVectore / VecRestoreLocalVector

show more ...

Plex: add and implement DMPlexCreateNaturalVector

DMPlexCreateNaturalVector gives a Vec capable of holding the natural ordering
and distribution. The routine mimicks DMCreateGlobalVector.

Merge branch 'marboeuf/plex-fix-g2n-constraintdof' into 'main'

Plex: bug fix in DMPlexCreateGlobalToNaturalSF in presence of constraint dofs

See merge request petsc/petsc!5453

Plex: bug fix in DMPlexCreateGlobalToNaturalSF in presence of constraint dofs

The creation of the natural SF raises an error when the section includes constraint dofs.
Leaves have duplicate entries.

Plex: bug fix in DMPlexCreateGlobalToNaturalSF in presence of constraint dofs

The creation of the natural SF raises an error when the section includes constraint dofs.
Leaves have duplicate entries. Now the natural SF includes the constraint dofs.

show more ...

Merge branch 'knepley/fix-plex-g2n' into 'main'

Fix Plex g2n map

See merge request petsc/petsc!4547

Merge branch 'wence/petsc-check-do-while' into 'main'

Wrap PetscCheck and PetscAssert in do { } while (0)

Closes #1199

See merge request petsc/petsc!5291

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Plex: Construction of G2N mapping was just wrong

Merge branch 'psanan/docs-seealso-formatting' into 'main'

Docs: Fix man page .seealso entries missing spaces after commas

Closes #1176

See merge request petsc/petsc!5202

Docs: Fix man page .seealso entries missing spaces after commas

```python

import os
import re
import fileinput

START_PATTERN = re.compile(r"^( *\.seealso:? )(.*$)")
FIX_PATTERN = re.compile(r",([^

Docs: Fix man page .seealso entries missing spaces after commas

```python

import os
import re
import fileinput

START_PATTERN = re.compile(r"^( *\.seealso:? )(.*$)")
FIX_PATTERN = re.compile(r",([^ $\n])")

def _fix_comma(matchobj):
return "`, `%s" % matchobj.group(1)

def process_file(filename_full):
""" Find/fix commas w/o trailing spaces or newlines in .seealso blocks """
with fileinput.FileInput(filename_full, inplace=True) as the_file:
in_block = False
for line in the_file:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(START_PATTERN, line) # not stripped line
if match:
in_block = True
if in_block:
if re.search(FIX_PATTERN, line):
line_fixed = re.sub(FIX_PATTERN, _fix_comma, line)
print(line_fixed, end="") # prints to file
else:
print(line, end="") # prints to file
else:
print(line, end="") # prints to file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process files in local tree(s) """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Merge branch 'psanan/docs-sphinx-man-pages' into 'main'

Integrate Man Pages into Sphinx Docs

Closes #1132 and #1015

See merge request petsc/petsc!4989

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (wor

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (word.rstrip(","), comma)

def _process_stripped_line(line):
return " ".join(map(_process_word, line.split()))

start_pattern = re.compile(r"^( *\.seealso:? )(.*$)")

def process_file(filename_full):
with fileinput.FileInput(filename_full, inplace=True) as f:
in_block = False
for line in f:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
line_modified = None
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(start_pattern,
line) # not stripped line
if match:
indent = " " * len(match.group(1))
in_block = True
line_modified = match.group(
1) + _process_stripped_line(
match.group(2).strip())
elif in_block:
line_modified = indent + _process_stripped_line(
line_stripped)
if line_modified:
print(line_modified) # prints to the file
else:
print(line, end="") # prints to the file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process everything """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
print("FILE ---", filename_full)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit

chkerr and friends wrapped

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()