update how CPR can be implemented in PCFIELDSPLIT manual page
Always print full information about solver in view; never say if lumped was setThe reason we have viewers is so people can see what was set!
PC+Doc: Clarify CPR documentation in FieldSplit
Minor cleanup, remove some outdated code, remove unneeded constructs, improve manual pages slightly, add missing test caseTime: 2.5 hours
Merge branch 'barry/remove-funct'
Add support for null argument from Fortran for VecScatterCreateToZero() VecScatterCreateToAll()Also update a few uses of NULL_OBJECT to the appropriate PETSC_NULL_XXXTime: .1 hoursReported-by: T
Add support for null argument from Fortran for VecScatterCreateToZero() VecScatterCreateToAll()Also update a few uses of NULL_OBJECT to the appropriate PETSC_NULL_XXXTime: .1 hoursReported-by: Tim Steinhoff <kandanovian@gmail.com>
show more ...
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-t
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-to: Andreas Mang <andreas@ices.utexas.edu>
Merge branch 'barry/fortran-update'
PCReset_FieldSplit() did not work correctly. Do a simple reset that cleans out the old data structuresThe drawback to this is that the options are lost to the inner KSP objects; but that is better
PCReset_FieldSplit() did not work correctly. Do a simple reset that cleans out the old data structuresThe drawback to this is that the options are lost to the inner KSP objects; but that is better thanbuggy code. Eventually we should try to preserve the inner KSP, while removing all the matrices, vectors, and ISPatch was provided by reporter.Time: .5 hoursReported-by: Sander Arens <Sander.Arens@ugent.be>
Updated and simplified Fortran interfaceReduced from 4 distinct approaches to using PETSc from Fortran to 1No more .h90 files (Fortran 90 functionality is now always available)Parameters and func
Updated and simplified Fortran interfaceReduced from 4 distinct approaches to using PETSc from Fortran to 1No more .h90 files (Fortran 90 functionality is now always available)Parameters and function prototypes are now provide through Fortran modules, not includes;only #define are provided in the petscXXXdef.h filesPETSc objects can be declared as either type(tXXX) or XXX. For example type(tVec) or VecMoved now private Fortran include files out of public include directory since uses don't use them;they are only used to generate the Fortran modulesEasier to support and test; we can now easily add more function prototypesAlso had to rework generation of manual pages to consistently use MANSEC and SUBMANSECsince these variables also handle how the Fortran modules are generated.Time: 57 hours
incorrect argument name in manual pageReported-by: Peter J. Puchyr <pjpuchyr@gmail.com>
phrasing in manual page results in false link and is incomplete.Reported-by: Dave May <dave.mayhem23@gmail.com>
When the Schur complement form of PCFIELDSPLIT is called PCSetUp() needs to be called before PCFieldSplitGetSubKSP()Add very useful error message to this caseTime: .1 hourReported-by: David Nolte
When the Schur complement form of PCFIELDSPLIT is called PCSetUp() needs to be called before PCFieldSplitGetSubKSP()Add very useful error message to this caseTime: .1 hourReported-by: David NolteThanks-to: Arthur Soprano, Lisandro Dalcin
added test example for ex42.cImproved manual pageChanged MatSchurComplementComputeExplicitOperator() to actually computethe Schur complement and not ignore the 1,1 block of the matrixTime: .1 h
added test example for ex42.cImproved manual pageChanged MatSchurComplementComputeExplicitOperator() to actually computethe Schur complement and not ignore the 1,1 block of the matrixTime: .1 hoursReported-by: Hoang Giang Bui <hgbk2008@gmail.com>
Extract the submatricesExtract the submatrices from the preconditioning matrix instead of the Jacobian matrix.The reason for this is that the MatMults for the submatrices (at line 1004, 2035 and 1
Extract the submatricesExtract the submatrices from the preconditioning matrix instead of the Jacobian matrix.The reason for this is that the MatMults for the submatrices (at line 1004, 2035 and 1054 of fieldsplit.c)involves function evaluations (which is not cheap) when we are using the matrix-free method for inexact Newton.I have some tests in MOOSE, and this change halves the compute time.
Need kspimpl.h in fieldsplit.c because of the KSP_Solve_FS.. variablesReported-by: Satish Balay <balay@mcs.anl.gov>
removed a variety of #include <xxximpl.h> from source code that was not needed
Merge branch 'maint'
Improve manual page for PCFieldSplitSetSchurPreReported-by: Dave May <dave.mayhem23@gmail.com>
revert this change from 00e125f as it breaks windows c++ tests
removed a bunch of unneeded inclusions of xxximpl.h which exposed private data where it did not have to be exposedalso made more systematic the inclusion of the base xxximpl.h in the derived yyyimp
removed a bunch of unneeded inclusions of xxximpl.h which exposed private data where it did not have to be exposedalso made more systematic the inclusion of the base xxximpl.h in the derived yyyimpl.hso the inclusion is done in the include file rather than in each source code that includes it
Merge branch 'barry/fix-some-clang-warnings'
fix loop counters in example and make actual runs of the example in nightly testsReported-by: clang static analyzer
a variety of fixes for issues detected by the clang static analyzerReported-by: clang static analyzer
These two routines must use TryMethod() because they are supposedto be ignored if the PCType is not fieldsplitReported-by: nightly tests
12345678910>>...23