Merge branch 'release'

Merge branch 'rmills/fix-matdiagonalscalelocal/release' into 'release'

Fix long-standing bug in MatMPIAIJDiagonalScaleLocalSetUp()

See merge request petsc/petsc!8910

Remove legacy '+1' allocations in XXXDiagonalScaleLocalSetUp() routines for AIJ and BAIJ parallel matrices

This commit removes '+1's in some memory allocations that are believed
to be leftover from

Remove legacy '+1' allocations in XXXDiagonalScaleLocalSetUp() routines for AIJ and BAIJ parallel matrices

This commit removes '+1's in some memory allocations that are believed
to be leftover from long ago to handle corner cases with malloc() calls
of size 0, which some implementations would not handle correctly. This
ceased to be an issue long ago.

Thanks-to: Pierre Jolivet <pierre@joliv.et>, Barry Smith <bsmith@petsc.dev>

show more ...

Fix long-standing bug in MatMPIAIJDiagonalScaleLocalSetUp()

This commit fixes a problem I discovered in October 2017 and then forgot about
after some unsuccessful initial attempts to find the proble

Fix long-standing bug in MatMPIAIJDiagonalScaleLocalSetUp()

This commit fixes a problem I discovered in October 2017 and then forgot about
after some unsuccessful initial attempts to find the problem. The MPIAIJ
implementation for MatDiagonalScaleLocalSetUp() was broken when the
local-to-global mappings in PETSc were refactored to always use
block indices; the MPIAIJ implementation of
MatDiagonalScaleLocalSetUp(), however, used element-wise, not block
indexing, and this was not refactored at the time, as it was overlooked
due to having no test case.
My commit finally fixes this; it also fixes several memory leaks in the
AIJ and BAIJ implementations of MatDiagonalScaleLocal() which were
overlooked, again, due to having no test cases.

show more ...

Merge branch 'jolivet/clang-format-21' into 'main'

clang-format-21

See merge request petsc/petsc!8202

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'lindad/mpi-fix-reset-preallocation' into 'release'

Fix MatResetPreallocation_MPIAIJ

See merge request petsc/petsc!8063

Fix MatResetPreallocation_MPIAIJ

Per Barry's suggesetion I inserted a `MatDisAssemble` which
immediately fixed my issue. I will work on adding a test

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...

Merge branch 'jolivet/rm-first-empty-line' into 'main'

Remove first and last empty lines

See merge request petsc/petsc!6892

Remove first and last empty lines

Merge branch 'jacobf/2023-08-09/linter-detect-static-function-candidates' into 'main'

Linter detect possible static functions

See merge request petsc/petsc!6796

Delete unused code

Merge remote-tracking branch 'origin/release'

Merge branch 'stefanozampini/fix-mpibaij-mpiaij-conversion' into 'release'

MATMPIBAIJ: fix non const operation in conversion to MPIAIJ

See merge request petsc/petsc!6582

MATMPIBAIJ: fix non const operation in conversion to MPIAIJ

Make MatDisAssemble_MPIAIJ and MatDisAssemble_MPIBAIJ support null offdiagonal block

Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'

Feature: Non-discardable PetscErrorCode

See merge request petsc/petsc!5923

Make PetscErrorCode a non-discardable enum

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2022-11-29/barry/2022-11-29/fix-matconvert-baij-aij/release' into 'release'

fix matconvert aij to baij to correctly check for any nonzero in a block. fix matincreaseoverlap aij t

Merge branch 'barry/2022-11-29/barry/2022-11-29/fix-matconvert-baij-aij/release' into 'release'

fix matconvert aij to baij to correctly check for any nonzero in a block. fix matincreaseoverlap aij to respect bs in IS

See merge request petsc/petsc!5897

show more ...

fix matconvert aij to baij to correctly check for any nonzero in a block to do proper BAIJ preallocation

Merge branch 'jacobf/2022-11-08/remove-petsctable' into 'main'

Remove PetscTable

See merge request petsc/petsc!5819

Use PetscHMapISet() in place of PetscHMapISetWithMode(INSERT_VALUES) as the intent is clearer