Merge branch 'jolivet/minor-cleanup' into 'main'

Minor cleanup: use MPI_IN_PLACE when possible and avoid extra allocation

See merge request petsc/petsc!8925

Minor cleanup: use MPI_IN_PLACE when possible and avoid extra allocation

Merge branch 'jolivet/clang-format-21' into 'main'

clang-format-21

See merge request petsc/petsc!8202

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'

show more ...

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}
done

show more ...

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g

Remove multiple parentheses and extra semicolon

git grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'
git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'
git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'

show more ...

Merge branch 'jacobf/2023-08-09/linter-detect-static-function-candidates' into 'main'

Linter detect possible static functions

See merge request petsc/petsc!6796

Add static to internal functions

Merge branch 'hongzh/sell-cuda' into 'main'

SELL-based SpMV

See merge request petsc/petsc!3428

Further optimization of MatMult_SeqSELLCUDA

- Add more kernels
- Use multiple threads per row for matrices with narrow slices
- Use multiple blocks per slice for matrices with wide slices
- Add thre

Further optimization of MatMult_SeqSELLCUDA

- Add more kernels
- Use multiple threads per row for matrices with narrow slices
- Use multiple blocks per slice for matrices with wide slices
- Add three new APIs to return the irregularity ratio, the maximum slice width and the average slice width

Experiments show that column blocking gives much worse performance for wide matrices and permulation based on slice width has almost no impact on the performance.

show more ...

Initial commit for porting SELL to GPU

- Add tiled SPMV and basic SpMVfor SeqSELL
- Tested in serial
- Offloadmask is used to determine when the matrix should be copied to GPU
- Use different slice

Initial commit for porting SELL to GPU

- Add tiled SPMV and basic SpMVfor SeqSELL
- Tested in serial
- Offloadmask is used to determine when the matrix should be copied to GPU
- Use different slice height for CUDA version
- By checking the nonzerostate, PETSc can decide if the whole matrix need to be copied or just the values need to be copied
- Make the convert function public so that the very slow MatConvert_Basic can be avoided sometimes. E.g. one can use a two-step convert method: AIJ->SELL,SELL->SELLCUDA instead of the direct convert AIJ->SELLCUDA
- Make the FLOPS count for SELL same as that for AIJCUSPARSE.
- MatDisAssemble is not needed.
- Change slice height from 32 to 16 for GPU
- To overlap communication with MatMult, VecScatterBegin() should be called before MatMult() for the diagonal part.
- SLICE_HEIGHT is defined to be 32 to match the warp size of GPU. For other cases, it is still 8.

Funded-by:
Project: PETSc for GPU
Time: 42 hours
Reported-by:
Thanks-to:

show more ...

Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'

Feature: Non-discardable PetscErrorCode

See merge request petsc/petsc!5923

Make PetscErrorCode a non-discardable enum

Merge branch 'jacobf/2022-11-08/remove-petsctable' into 'main'

Remove PetscTable

See merge request petsc/petsc!5819

Use PetscHMapISet() in place of PetscHMapISetWithMode(INSERT_VALUES) as the intent is clearer

- Replace PetscTable with PetscHMapI.
- Rename:
- PetscTableCreate() -> PetscHMapICreateWithSize()
- PetscTableFind() -> PetscHMapIGetWithDefault()
- PetscTableAdd() -> PetscHMapISetWithMode()

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'jacobf/2022-09-17/slimmer-petscobject' into 'main'

Feature: Slimmer PetscObject

See merge request petsc/petsc!5649

Remove parent, parentid, flops, time, mem, and memchildren. Deprecate PetscLogObjectParent(), PetscLogObjectMemory(), and PetscNewLog()

Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners w/o PetscCall()

See merge request petsc/petsc!5561

Remove braces from one-liners w/o PetscCall()

Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners

See merge request petsc/petsc!5557

Remove braces from one-liners