Merge branch 'barry/2025-07-30/fix-matshellsetoperationarg' into 'main'

Complete usage of PetscVoidFn and PetscErrorCodeFn and introduce PetscFortranCallbackFn

See merge request petsc/petsc!8615

Change use of void (*)(void) and void (**)(void) in the PETSc API to PetscVoidFn * and PetscVoidFn ** or PetscErrorCodeFn * or PetscErrorCodeFn **

Merge branch 'jolivet/rm-explicit-empty-output_file' into 'main'

Remove 535 empty .out and consolidate the use of output/empty.out

See merge request petsc/petsc!8538

Remove explicitly listed empty files and switch to output/empty.out

Merge branch 'jolivet/remove-cast' into 'main'

Use NULL or nullptr instead of casted 0

See merge request petsc/petsc!7857

Use NULL or nullptr instead of casted 0

Merge remote-tracking branch 'origin/release'

Merge branch 'jolivet/fix-typos' into 'release'

Fix typos

See merge request petsc/petsc!6984

Fix typos

Merge branch 'jczhang/support-cuda12' into 'main'

Update matsolve related routines of aijcusparse to support CUDA-12.

See merge request petsc/petsc!6225

ex69: make nloc an even number, to avoid a mysterious cudaErrorMisalignedAddress error with cuda-12 on frog

The error is not reproducible on frog with cuda-11.7/11.8 or other machines with cuda-12.0

ex69: make nloc an even number, to avoid a mysterious cudaErrorMisalignedAddress error with cuda-12 on frog

The error is not reproducible on frog with cuda-11.7/11.8 or other machines with cuda-12.0/12.1

On frog, we have the following error trace:

[balay@frog tests]$ /software/mpich-4.1.1/bin/mpiexec -n 2 ./ex69 -A_mat_type aijcusparse -test 0 -k 6 -l 0 -use_shell 1 -use_gpu_aware_mpi 0
[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: GPU error
[0]PETSC ERROR: cuda error 716 (cudaErrorMisalignedAddress) : misaligned address
[0]PETSC ERROR: See https://petsc.org/release/faq/ for trouble shooting.
[0]PETSC ERROR: Petsc Development GIT revision: v3.18.5-1103-gedeb0b75eb7 GIT Date: 2023-03-24 13:29:04 -0500
[0]PETSC ERROR: ./ex69 on a arch-cuda121 named frog.mcs.anl.gov by balay Sat Mar 25 13:18:58 2023
[0]PETSC ERROR: Configure options --with-mpi-dir=/software/mpich-4.1.1 --with-cuda-dir=/usr/local/cuda-12.1 PETSC_ARCH=arch-cuda121
[0]PETSC ERROR: #1 PetscSFLinkMemcpy_CUDA() at /home/balay/petsc/src/vec/is/sf/impls/basic/cuda/sfcuda.cu:1075
[0]PETSC ERROR: #2 PetscSFLinkCopyRootBufferInCaseNotUseGpuAwareMPI() at /home/balay/petsc/include/../src/vec/is/sf/impls/basic/sfpack.h:297
[0]PETSC ERROR: #3 PetscSFLinkStartRequests_MPI() at /home/balay/petsc/src/vec/is/sf/impls/basic/sfmpi.c:32
[0]PETSC ERROR: #4 PetscSFLinkStartCommunication() at /home/balay/petsc/include/../src/vec/is/sf/impls/basic/sfpack.h:270
[0]PETSC ERROR: #5 PetscSFBcastBegin_Basic() at /home/balay/petsc/src/vec/is/sf/impls/basic/sfbasic.c:191
[0]PETSC ERROR: #6 PetscSFBcastWithMemTypeBegin() at /home/balay/petsc/src/vec/is/sf/interface/sf.c:1454
[0]PETSC ERROR: #7 VecScatterBegin_Internal() at /home/balay/petsc/src/vec/is/sf/interface/vscat.c:73
[0]PETSC ERROR: #8 VecScatterBegin() at /home/balay/petsc/src/vec/is/sf/interface/vscat.c:1319
[0]PETSC ERROR: #9 MatMult_MPIAIJCUSPARSE() at /home/balay/petsc/src/mat/impls/aij/mpi/mpicusparse/mpiaijcusparse.cu:451
[0]PETSC ERROR: #10 MatMult() at /home/balay/petsc/src/mat/interface/matrix.c:2573
[0]PETSC ERROR: #11 MatMult_S() at ex69.c:11
[0]PETSC ERROR: #12 MatMult_Shell() at /home/balay/petsc/src/mat/impls/shell/shell.c:1014
[0]PETSC ERROR: #13 MatMult() at /home/balay/petsc/src/mat/interface/matrix.c:2573
[0]PETSC ERROR: #14 MatProductNumeric_X_Dense() at /home/balay/petsc/src/mat/interface/matproduct.c:329
[0]PETSC ERROR: #15 MatProductNumeric() at /home/balay/petsc/src/mat/interface/matproduct.c:685
[0]PETSC ERROR: #16 main() at ex69.c:127
[0]PETSC ERROR: PETSc Option Table entries:
[0]PETSC ERROR: -A_mat_type aijcusparse (source: command line)
[0]PETSC ERROR: -k 6 (source: command line)
[0]PETSC ERROR: -l 0 (source: command line)
[0]PETSC ERROR: -test 0 (source: command line)
[0]PETSC ERROR: -use_gpu_aware_mpi 0 (source: command line)
[0]PETSC ERROR: -use_shell 1 (source: command line)
[0]PETSC ERROR: ----------------End of Error Message -------send entire error message to petsc-maint@mcs.anl.gov----------
application called MPI_Abort(MPI_COMM_SELF, 97) - process 0

[balay@frog tests]$ /software/mpich-4.1.1/bin/mpiexec -n 2 compute-sanitizer ./ex69 -A_mat_type aijcusparse -test 0 -k 6 -l 0 -use_shell 1 -use_gpu_aware_mpi 0
========= COMPUTE-SANITIZER
========= COMPUTE-SANITIZER
========= Invalid __global__ write of size 16 bytes
========= at 0x470 in void cusparse::csrmv_v3_partition_kernel<(int)256, cusparse::VectorScalarMultiplyPolicy, int, int, double, double, double>(const T4 *, T3, T4, int, T3 *, cusparse::KernelCoeff<T7>, T3, T6 *)
========= by thread (0,0,0) in block (0,0,0)
========= Address 0x7f0dee800678 is misaligned
========= and is inside the nearest allocation at 0x7f0dee800600 of size 720 bytes
========= Saved host backtrace up to driver entry point at kernel launch time
========= Host Frame: [0x30b492]
========= in /lib64/libcuda.so.1
========= Host Frame: [0x8ba1eb]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame: [0x9161eb]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame: [0x193817]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame: [0x19c258]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame: [0x1c2fc5]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame:cusparseSpMV [0xeb15d]
========= in /usr/local/cuda-12.1/lib64/libcusparse.so.12
========= Host Frame:/home/balay/petsc/src/mat/impls/aij/seq/seqcusparse/aijcusparse.cu:3627:MatMultAddKernel_SeqAIJCUSPARSE(_p_Mat*, _p_Vec*, _p_Vec*, _p_Vec*, PetscBool, PetscBool) [0x1e8917b]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/impls/aij/seq/seqcusparse/aijcusparse.cu:3483:MatMult_SeqAIJCUSPARSE(_p_Mat*, _p_Vec*, _p_Vec*) [0x1e85e9c]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/impls/aij/mpi/mpicusparse/mpiaijcusparse.cu:452:MatMult_MPIAIJCUSPARSE(_p_Mat*, _p_Vec*, _p_Vec*) [0x1e088c7]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/interface/matrix.c:2573:MatMult [0x1cdaf43]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/tests/ex69.c:11:MatMult_S [0x26fb]
========= in /home/balay/petsc/src/mat/tests/./ex69
========= Host Frame:/home/balay/petsc/src/mat/impls/shell/shell.c:1014:MatMult_Shell [0x1b354b7]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/interface/matrix.c:2573:MatMult [0x1cdaf43]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/interface/matproduct.c:329:MatProductNumeric_X_Dense [0x1c87033]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/interface/matproduct.c:685:MatProductNumeric [0x1c8f75f]
========= in /home/balay/petsc/arch-cuda121/lib/libpetsc.so.3.018
========= Host Frame:/home/balay/petsc/src/mat/tests/ex69.c:127:main [0x5d7e]
========= in /home/balay/petsc/src/mat/tests/./ex69
========= Host Frame:__libc_start_call_main [0x3feb0]
========= in /lib64/libc.so.6
========= Host Frame:__libc_start_main [0x3ff60]
========= in /lib64/libc.so.6
========= Host Frame:_start [0x2395]
========= in /home/balay/petsc/src/mat/tests/./ex69

show more ...

Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'

Feature: Non-discardable PetscErrorCode

See merge request petsc/petsc!5923

Make PetscErrorCode a non-discardable enum

Merge branch 'jczhang/add-MatDenseGetArrayAndMemType' into 'main'

Add MatDenseGetArrayAndMemType and friends

Closes #1299

See merge request petsc/petsc!5956

Mat: add MatDenseGetArrayAndMemType and friends

Fix #1299

Merge branch 'jacobf/2022-09-23/veccupm' into 'main'

Feature: CUPM Vec

See merge request petsc/petsc!5685

Fix incorrect usage of VecCUDARestoreArray(). Arrays were either double-restored or restored using wrong API

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-07-23/add-petscbeginuser' into 'main'

Add PetscFunctionBeginUser to all PETSc C/C++ examples

See merge request petsc/petsc!5470

Add PetscFunctionBeginUser to all PETSc C/C++ examples

Now the stack frames will contain the main program and the correct line numbers in them

git ls-files | egrep "(tutorials|tests)" | xargs sed -

Add PetscFunctionBeginUser to all PETSc C/C++ examples

Now the stack frames will contain the main program and the correct line numbers in them

git ls-files | egrep "(tutorials|tests)" | xargs sed -i "s?\(PetscCall(PetscInitialize(&argc\)?PetscFunctionBeginUser;\n \1?g"

Commit-type: error-checking, testing-fix
/spend 15m

show more ...

Merge branch 'barry/2022-06-13/make-one-line-if-call' into 'main'

Change if () { PetscCall() } three liner to one liner

See merge request petsc/petsc!5344

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...