Merge branch 'barry/2022-03-30/strip-petscall-petsctrymethod' into 'main'Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallSee merge request petsc/petsc!5051
Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codesBoth for debug and optimized buildsAlso removes shadow declaration errors from use of mpiu_allreduceCommit-type: error-
Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codesBoth for debug and optimized buildsAlso removes shadow declaration errors from use of mpiu_allreduceCommit-type: error-checkingReported-by: Lisandro Dalcin <dalcinl@gmail.com>
show more ...
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be addit
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be additions needed for running with a static error checkerCommit-type: error-checking/spend 15mReported-by:Lisandro Dalcin <dalcinl@gmail.com>
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
pluck ~1000 low hanging PetscCheckFalse() -> PetscCheck() fruit
chkerr and friends wrapped
doc: fix References: sectionNotation:. * - textor. year - text
rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()
deprecate PETSC_STATIC_INLINE
add PetscAssert() and PetscAssertFalse()
make PetscInfo() variadic
SETERRQ[1-9]+ begone
Fix missing ierr =, removed incorrect CHKERRQ()Commit-type: error-checking, style-fix\spend 45m
PetscStack : check for correct push/popEnforce checkstack for CI jobsFixes from testsuite
Remove all double blank lines from sourceCommit-type: petsc-style/2h
Fix typos in sourceCommit-type: style-fix/spend 2m
All MPIU_ functions except MPIU_File return MPI error codes for checkingUpdate checkbadSource to find use of CHKERRQ with MPIU_ functionsCommit-type: i.e. error-checking, optimization, bug-fix, p
All MPIU_ functions except MPIU_File return MPI error codes for checkingUpdate checkbadSource to find use of CHKERRQ with MPIU_ functionsCommit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, exampleFunded-by:Project:Time: hoursReported-by:Thanks-to:Development Tools: Vim, Emacs, Eclipse
KSP: Prefer DM to PC Mat when creating vectors - This gets the right View function for the vectorsCo-Authored-By: Blaise Bourdin <bourdin@lsu.edu>
Turn on checkbadSource test to generate an error when found; fix all source code that causes errorsCommit-type: portability-fix, testing-fix, style-fix, feature, maintainability/spend 1.5h
SNES: Replace 0 -> NULL for pointers
SNES: only change linesearch type when not already setThis is necessary to allow users to SNESLineSearchSetType before SNESSetFromOptions.
docs: fix Input/Output Parameters list formatReported-by: Pierre Jolivet <pierre.jolivet@enseeiht.fr>
Double semicolons
Merge branch 'gropp/doc-fixes-1' [PR #1838]
DM: Simplify implementation of DMHasCreateInjection()* Add log event for DMCreateInjection()* Get rid of DMHasCreateInjection_Default()* Rename dm->ops->getinjection to dm->ops->createinjection*
DM: Simplify implementation of DMHasCreateInjection()* Add log event for DMCreateInjection()* Get rid of DMHasCreateInjection_Default()* Rename dm->ops->getinjection to dm->ops->createinjection* Improve error checking here and there
12345678910>>...16