Remove some PetscCheckFalse()
fixup some remaining stragglers from !4889
remove empty l2impls.h
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
show more ...
chkerr and friends wrapped
rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()
add PetscAssert() and PetscAssertFalse()
make PetscInfo() variadic
SNESLineSearch CP: fix overzealous atol exiting line search but not SNESWhen F and Y are both modest (1e-8), their product can be smaller thanthe default atol (1e-15) even though we need to take t
SNESLineSearch CP: fix overzealous atol exiting line search but not SNESWhen F and Y are both modest (1e-8), their product can be smaller thanthe default atol (1e-15) even though we need to take the step. Whenexiting early under this condition, the line search exits before takingany step, but the SNES continues to iterate: 0 SNES Function norm 9.086021195164e-01 Line search: lambdas = [1., 0.], ftys = [-0.656115, 2.91487] Line search terminated: lambda = 0.816265, fnorms = 0.0870758 1 SNES Function norm 8.707582821951e-02 Line search: lambdas = [1., 0.], ftys = [-6.48955e-06, 0.00979613] Line search terminated: lambda = 0.999338, fnorms = 0.00044834 2 SNES Function norm 4.483404033935e-04 Line search: lambdas = [1., 0.], ftys = [1.86622e-10, 1.43036e-06] Line search terminated: lambda = 1.00013, fnorms = 1.09993e-08 3 SNES Function norm 1.099934077677e-08 Line search terminated ended at initial point because dot(F,Y) = 3.11502e-16 < atol = 1e-15 4 SNES Function norm 1.099934077677e-08 Line search terminated ended at initial point because dot(F,Y) = 3.11502e-16 < atol = 1e-15 5 SNES Function norm 1.099934077677e-08 Line search terminated ended at initial point because dot(F,Y) = 3.11502e-16 < atol = 1e-15 6 SNES Function norm 1.099934077677e-08 Line search terminated ended at initial point because dot(F,Y) = 3.11502e-16 < atol = 1e-15In this commit, we ensure that SNES declares convergence if the"critical point" notion of atol is satisfied on the first step of theline search. Additionally, we change the notion of atol to mean "in thedirection of Y", but not multiplied by Y.Reported-by: Emily Jakobs <emily.jakobs@colorado.edu>
Turn on checkbadSource test to generate an error when found; fix all source code that causes errorsCommit-type: portability-fix, testing-fix, style-fix, feature, maintainability/spend 1.5h
Spring cleaning
Remove usage of PETSC_HAVE_FORTRAN_STDCALL, PETSC_BLASLAPACK_STDCALL, HAVE_FORTRAN_MIXED_STR_ARG flags - as Compaq f90 compiler is no longer supported
Refactored LineSearchBT to PostCheck on lambda*Y instead of the original Y
linesearchbt.c edited online with Bitbucket
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be unif
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be uniformly used or maintained.Thus, remove all .keywords: fields, and a following blank line, if present.This is accomplished with GNU sed (gsed on OS X), with the following commands.*Warning* that this type of command can corrupt a .git directory,so be cautious in reusing or modifying these commands. They first lookfor and delete matching lines with a following line consisting of only whitespace,and then delete any remaining matching lines. find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find src/ -type f -exec gsed -i '/keywords:/d' {} + find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find include/ -type f -exec gsed -i '/keywords:/d' {} +Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed
Fix several of the TODO: items from the testig of examplesStill a variety of problems to resolve including memory corruptionCommit-type: testing-fix
trivial fixes of incorrect formatting in SNES linesearch routinesCommit-type: style-fix
Allow -1 to SNESSetTolerances() and -snes_max_funcs to indicate unlimited number of function evaluationsThis is useful when running with -snes_test_jacobian and other use casesCommit-type: featur
Allow -1 to SNESSetTolerances() and -snes_max_funcs to indicate unlimited number of function evaluationsThis is useful when running with -snes_test_jacobian and other use casesCommit-type: featureReported-by: Hong Zhang <hongzhang@anl.gov>
Merge branch 'barry/critical-point-divide-by-zero/maint'
Avoid an unnecessary divide by zero in critical path and l2 line searchCommit-type: featureReported-by: Brian Thomas Weston <weston8@llnl.gov>
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \(
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \( -name "*.c" -or -name "*.h" -or -name "*.cxx" \) | xargs gsed -i 's/Notes\s*:\s*\(\w.*\)/Notes:\n \1/'This adds a newline and 4 spaces whenever "Notes:" is followed by any "word" character, in any .c, .h, or .cxx file in src/ or include/
Fix for complexCommit-type: bug-fixReported-by: Jose E. Roman <jroman@dsic.upv.es>
Have CP line search return immediately if the inner product of F and Y is smallCommit-type: featureReported-by: Robert Nr Nourgaliev <nourgaliev1@llnl.gov>
Improve monitor message for small snorm in line search; it is not really a failureCommit-type: featureFunded-by: IMEXProject: chemistry
Do not as severely limit the allowed size of lambda in the next step for l2 when a Nan or Inf was previously producedReported-by: Till Martens <till.martens@dlr.de>
123456789