Remove PetscCheckFalse from SNES directory

Commit-type: housekeeping
/spend 20m

Merge branch 'jacobf/2022-04-05/petscattrformat-all-the-rest' into 'main'

Enable PETSC_ATTRIBUTE_FORMAT()

See merge request petsc/petsc!5085

Enable PETSC_ATTRIBUTE_FORMAT()

Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'

Remove bogus error returns from Begin/End() macros

See merge request petsc/petsc!5069

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+ return 0;

show more ...

chkerr and friends wrapped

Merge branch 'knepley/feature-dm-aux-vec' into 'main'

DM: Add equation part to DM aux vector key

See merge request petsc/petsc!4995

DM: Add equation part to DM aux vector key

Merge branch 'jed/amg-symmetry' into 'main'

PCGAMG: skip symmetric non-SPD use of KSPCR for eigenvalues

See merge request petsc/petsc!4910

PCGAMG: update tests

* formatting of Chebyshev information
* use of GAMG SA eigenvalue estimates

Merge branch 'knepley/feature-plex-distribute-default' into 'main'

Plex: Change default to automatic distribution

See merge request petsc/petsc!4843

Plex: Change default to automatic distribution - Add DMPlexDistributeGet/SetDefault() to change this - Add DMPlexCopy_Internal() to keep state in Plex object consistent

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

SETERRQ[1-9]+ begone

Merge branch 'jwallwork23/tweak-snes-ex12-tri-p1-adapt-uniform' into 'main'

Tweak 3D adaptation tests in SNES ex12

See merge request petsc/petsc!4743

snes ex12: tweak options for 3D metric-based adaptation
- Four processors was too many for such a small problem and ParMmg was struggling with the partitioning.
- Increasing the size of the initial m

snes ex12: tweak options for 3D metric-based adaptation
- Four processors was too many for such a small problem and ParMmg was struggling with the partitioning.
- Increasing the size of the initial mesh also helps.

show more ...

Merge branch 'jwallwork23/fixes-parmmg' into 'main'

ParMmg updates

See merge request petsc/petsc!4725

snes ex12: choose a finer initial mesh
- See https://gitlab.com/petsc/petsc/-/issues/951#note_807413580

Merge branch 'jwallwork23/default-to-mmg' into 'main'

Set Mmg and ParMmg as the default adaptors

See merge request petsc/petsc!4665

snes ex12: use pragmatic