Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+ return 0;

show more ...

chkerr and friends wrapped

Merge branch 'knepley/feature-dm-aux-vec' into 'main'

DM: Add equation part to DM aux vector key

See merge request petsc/petsc!4995

DM: Add equation part to DM aux vector key

Merge branch 'jed/amg-symmetry' into 'main'

PCGAMG: skip symmetric non-SPD use of KSPCR for eigenvalues

See merge request petsc/petsc!4910

PCGAMG: update tests

* formatting of Chebyshev information
* use of GAMG SA eigenvalue estimates

Merge branch 'knepley/feature-plex-distribute-default' into 'main'

Plex: Change default to automatic distribution

See merge request petsc/petsc!4843

Plex: Change default to automatic distribution - Add DMPlexDistributeGet/SetDefault() to change this - Add DMPlexCopy_Internal() to keep state in Plex object consistent

Merge branch 'jczhang/feature-kokkos-sycl' into 'main'

Add Kokkos SYCL support

See merge request petsc/petsc!4562

Disable some tests due to bugs in Kokkos or dpcpp

Merge remote-tracking branch 'origin/release'

Merge branch 'knepley/feature-plex-ex13-error' into 'release'

SNES ex13: Add an error monitor

See merge request petsc/petsc!4555

SNES ex13: Add an error monitor

Merge branch 'psanan-release-patch-82973' into 'main'

Developer docs, style: remove rule about using "if (!rank)" and replace all "!rank" usage with "rank == 0"

See merge request petsc/petsc!4146

Style: replace "!rank" with "rank == 0"

In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds les

Style: replace "!rank" with "rank == 0"

In SF tutorial ex1 (src/vec/is/sf/tutorials/ex1.c), add parentheses around "rank == 0". This is relevant because ! binds more tightly than +, but == binds less
tightly, so the result of the computation would otherwise change.

show more ...

Merge branch 'jolivet/fix-some-missing-chkerr' into 'main'

Some missing CHKERR[Q|MPI]

See merge request petsc/petsc!4190

Some missing CHKERR[Q|MPI]

Merge branch 'knepley/feature-plex-ceed-integration' into 'main'

Plex: Initial CEED integration

See merge request petsc/petsc!3918

Plex: Update examples to use new creation interface

Merge branch 'knepley/feature-ds-residualbd-key' into 'main'

DS+FE+Doc: Make BdResidual take a key

See merge request petsc/petsc!3761

DM+Plex: Boundary integration functions are now stored in a PetscWeakForm held in the Boundary object
- Boundary residual/Jacobian functions now take a form key
- Now store DMLabel in DSBoundary
- Im

DM+Plex: Boundary integration functions are now stored in a PetscWeakForm held in the Boundary object
- Boundary residual/Jacobian functions now take a form key
- Now store DMLabel in DSBoundary
- Improved Boundary, Weak Form, and DS viewers
- Remove DMCopyBoundary(), DMCopyDisc() is sufficient
- Need DMTransferDS_Internal() to create new DS with label in the correct DM
- Correct all DMAddBoundary() in tests
- Allow DMBoundary to hold just a label name if necessary since p4est is missing labels in a lot of places
- Fix propagating coordinate dimension in DS

show more ...

Merge branch 'knepley/feature-dm-aux-data' into 'main'

DM: Replace object composition with an API for auxiliary data

See merge request petsc/petsc!3798