Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+

PetscInitialize() and PetscFinalize() wrapped:

- ierr = PetscInitialize();if (ierr) return ierr;
+ CHKERRQ(PetscInitialize());

- ierr = PetscFinalize();
- return ierr;
+ CHKERRQ(PetscFinalize());
+ return 0;

show more ...

chkerr and friends wrapped

Merge remote-tracking branch 'origin/maint' into master

Merge branch 'rmills/fix-dmcomposite-mat-vec-types/maint' into 'maint'

Make routines for creating Mat and Vec objects from DMCOMPOSITE honor -dm_mat_type and -dm_vec_type options.

See merge request

Merge branch 'rmills/fix-dmcomposite-mat-vec-types/maint' into 'maint'

Make routines for creating Mat and Vec objects from DMCOMPOSITE honor -dm_mat_type and -dm_vec_type options.

See merge request petsc/petsc!3073

show more ...

Make routines for creating Mat and Vec objects from DMCOMPOSITE honor -dm_mat_type and -dm_vec_type options.

This fix is needed so that GPU matrix and vector types can be used with simulations emplo

Make routines for creating Mat and Vec objects from DMCOMPOSITE honor -dm_mat_type and -dm_vec_type options.

This fix is needed so that GPU matrix and vector types can be used with simulations employing DMCOMPOSITE.

This commit also adds CUDA and ViennaCL tests for SNES tutorial ex28,
which will fail without the fix in this commit.

show more ...

Merge branch 'jed/enable-c99-tests' into 'master'

tests: remove c99 requires because PETSC_HAVE_C99 is gone

See merge request petsc/petsc!2935

tests: remove c99 requires because PETSC_HAVE_C99 is gone

PETSC_HAVE_C99 was removed in 75b4e14096da0ef4f038ff4e2c695b95ada13594

configure: Currently PETSc requires a c99 compiler - update
conf

tests: remove c99 requires because PETSC_HAVE_C99 is gone

PETSC_HAVE_C99 was removed in 75b4e14096da0ef4f038ff4e2c695b95ada13594

configure: Currently PETSc requires a c99 compiler - update
configure test accordingly

but we still had lots of\

build:
requires: c99

in the tests, all of which have since been being skipped in the
tests. This will re-enable those tests.

Commit-type: bug-fix

show more ...

Merge branch 'jed/promote-examples-tests-tutorials' [petsc/petsc!2610]

* jed/promote-examples-tests-tutorials:
Promote examples/{tests,tutorials}/ to {tests,tutorials}/

Promote examples/{tests,tutorials}/ to {tests,tutorials}/

This shortens paths and improves consistency between test target names
and paths to the source and output files. Most of the work was
compl

Promote examples/{tests,tutorials}/ to {tests,tutorials}/

This shortens paths and improves consistency between test target names
and paths to the source and output files. Most of the work was
completed by this script, followed by mild cleanup of nonconforming
cases.

for makefile in `git ls-files 'src/*makefile'`; do
if rg -q 'DIRS.*\bexamples\b' $makefile; then
base=$(dirname $makefile)
dirs=$(cd $base/examples && ls -d tests tutorials 2>/dev/null | xargs echo)
perl -pi -e "s#^(DIRS.*)\bexamples\b#\1${dirs}#" $makefile
git rm $base/examples/makefile
for t in $dirs; do
git mv $base/examples/$t $base/
perl -pi -e "s#^(LOCDIR[[:space:]]*=).*#\1 $base/$t/#" $base/$t
done
fi
done

git grep -l -E -z 'examples/(tutorials|tests)' | xargs -0 perl -pi -e 's#examples/(tutorials|tests)#\1#g'
git checkout @ \
src/docs/website/documentation/changes/ \
src/benchmarks/results/

show more ...