| #
cd791dc2
|
| 21-Nov-2023 |
Barry Smith <bsmith@mcs.anl.gov> |
Fix PetscOptionsGetViewer() so it works in a thread-safe way
When PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is shared by all threads that call PetscOptio
Fix PetscOptionsGetViewer() so it works in a thread-safe way
When PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is shared by all threads that call PetscOptionsGetViewer(). In the previous code PetscObjectReference() and dereference (via PetscViewerDestroy() where called on the viewer by multiple threads after the viewer was accessed thus corrupting the object.
This branch introduces a PetscOptionsRestoreViewer() that allows not doing the referencing and dereferencing on persistant viewers, thus removing the specific race condition above.
Other possible solutions include
Use a lock on each PetscObjectReference/Dereference() just in case they are shared. Could be time consuming so one could mark each object as either threadshared or independent and only do the locks on threadshared objects. This lowers the cost but would require more extensive changes to PETSc infrastructure. And I do not know if this shared/not shared model is what we need in the long run, though it might be.
show more ...
|
| #
dff8f175
|
| 11-Oct-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'adams/gamg-square-graph-true' into 'main'
GAMG: switch the default to using square graph
See merge request petsc/petsc!6923
|
| #
d4adc10f
|
| 11-Oct-2023 |
Mark Adams <524115-markadams4@users.noreply.gitlab.com> |
GAMG: switch the default to using square graph
|
| #
be9d80f0
|
| 09-Oct-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'adams/gamg-add-old-filter' into 'main'
Add PCGAMGSetLowMemoryFilter() with -pc_gamg_low_memory_threshold_filter for...
See merge request petsc/petsc!6918
|
| #
a9ccf005
|
| 09-Oct-2023 |
Mark Adams <524115-markadams4@users.noreply.gitlab.com> |
Add PCGAMGSetLowMemoryFilter() with -pc_gamg_low_memory_threshold_filter for...
|
| #
6e5bc3c4
|
| 12-Sep-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'adams/gamg-add-old-coarsening' into 'main'
add-old-coarsening and small cleanups
See merge request petsc/petsc!6814
|
| #
d529f056
|
| 08-Sep-2023 |
markadams4 <mfadams@lbl.gov> |
add old aggressive coarsening algorithm as option, switch default MIS ordering algorithm back to old one
|
| #
6c37f76f
|
| 27-Jul-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'tisaac/feature-log-handler' into 'main'
Deglobalize logging into PetscLogHandler and PetscLogState
See merge request petsc/petsc!6709
|
| #
2611ad71
|
| 14-Jul-2023 |
Toby Isaac <toby.isaac@gmail.com> |
Profiling: Improve !defined(PETSC_USE_LOG) #defines
- If we cast macro arguments to void, we can avoid unused errors that have forced lots of conditionally included code like this:
```c #if def
Profiling: Improve !defined(PETSC_USE_LOG) #defines
- If we cast macro arguments to void, we can avoid unused errors that have forced lots of conditionally included code like this:
```c #if defined(PETSC_USE_LOG) PetscLogEvent event; #endif ```
- Having global counters like petsc_TotalFlops externed event if !PetscDefined(USE_LOG) helps to remove a lot of needless `#ifdef`s around code that can instead be placed in `if (PetscDefined(USE_LOG)) {}` blocks.
show more ...
|
| #
31d78bcd
|
| 02-Feb-2023 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'
Feature: Non-discardable PetscErrorCode
See merge request petsc/petsc!5923
|
| #
3ba16761
|
| 10-Dec-2022 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
Make PetscErrorCode a non-discardable enum
|
| #
0769a646
|
| 09-Dec-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'adams/snes-tutorials-ex56-update' into 'main'
Adams/snes tutorials ex56 update
See merge request petsc/petsc!5910
|
| #
cdb485dd
|
| 09-Dec-2022 |
Mark Adams <524115-markadams4@users.noreply.gitlab.com> |
Adams/snes tutorials ex56 update
|
| #
ea0e54ad
|
| 10-Nov-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'adams/snesex56_refactor' into 'main'
Update SNES/tutorials/ex56 with modern use of Plex, a Laplacian test in addition to the elasticity test, and some cleanup of ad hoc code.
See merg
Merge branch 'adams/snesex56_refactor' into 'main'
Update SNES/tutorials/ex56 with modern use of Plex, a Laplacian test in addition to the elasticity test, and some cleanup of ad hoc code.
See merge request petsc/petsc!5814
show more ...
|
| #
3667b0a5
|
| 10-Nov-2022 |
Mark Adams <524115-markadams4@users.noreply.gitlab.com> |
Update SNES/tutorials/ex56 with modern use of Plex, a Laplacian test in addition to the elasticity test, and some cleanup of ad hoc code.
|
| #
c1f49a03
|
| 01-Oct-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'suyash/hip' into 'main'
Add HIP support to Mat class in PETSc
See merge request petsc/petsc!5383
|
| #
47d993e7
|
| 01-Oct-2022 |
suyashtn <suyashtn@umich.edu> |
Add HIP support to Mat class in PETSc
Co-authored-by: Justin Chang <jychang48@gmail.com>
Fixed-by: Jacob Faibussowitsch <jacob.fai@gmail.com> Fixed-by: Junchao Zhang <jczhang@mcs.anl.gov> Fixed-by:
Add HIP support to Mat class in PETSc
Co-authored-by: Justin Chang <jychang48@gmail.com>
Fixed-by: Jacob Faibussowitsch <jacob.fai@gmail.com> Fixed-by: Junchao Zhang <jczhang@mcs.anl.gov> Fixed-by: Satish Balay <balay@mcs.anl.gov>
show more ...
|
| #
061e922f
|
| 22-Sep-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'
Feature: Bicycle Storage Facility 2
See merge request petsc/petsc!5661
|
| #
d71ae5a4
|
| 21-Sep-2022 |
Jacob Faibussowitsch <jacob.fai@gmail.com> |
source code format changes due to .clang-format changes
|
| #
f0af967e
|
| 29-Aug-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jolivet/fix-style-one-liners' into 'main'
Remove braces from one-liners w/o PetscCall()
See merge request petsc/petsc!5561
|
| #
ad540459
|
| 29-Aug-2022 |
Pierre Jolivet <pierre@joliv.et> |
Remove braces from one-liners w/o PetscCall()
|
| #
38f67375
|
| 27-Aug-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jolivet/fix-style-one-liners' into 'main'
Remove braces from one-liners
See merge request petsc/petsc!5557
|
| #
48a46eb9
|
| 27-Aug-2022 |
Pierre Jolivet <pierre@joliv.et> |
Remove braces from one-liners
|
| #
47dfd8b8
|
| 26-Aug-2022 |
Satish Balay <balay@mcs.anl.gov> |
Merge branch 'jczhang/for-jlse-test' into 'main'
Turn on remaining petsc/kokkos tests for sycl
See merge request petsc/petsc!5556
|
| #
dcfd994d
|
| 25-Jul-2022 |
Junchao Zhang <jczhang@mcs.anl.gov> |
Tests: turn on some kokkos tests for sycl
|