Fix handling of PetscStack for callback functions and external package calls (and update slepc in sync)

Information was often wrong; incorrect filenames and line numbers removed

Also unified naming

Fix handling of PetscStack for callback functions and external package calls (and update slepc in sync)

Information was often wrong; incorrect filenames and line numbers removed

Also unified naming for callback function stack frames

Commit-type: error-checking, debugability
/spend 2h

show more ...

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these

Wrap PetscCheck and PetscAssert in do { } while (0)

These macros look like functions, so they should behave like
functions. Fix up the resulting invalid syntax due to the previous
behaviour of these macros being "if (...)
statement_without_semicolon". Fixes #1199.

show more ...

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\

Change if () { PetscCall() } three liner and friends to one liners

for i in `git ls-files | grep "\.[ch]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ ]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$[ ]*}\$?\1if (\2) PetscCall(\3$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

for i in `git ls-files | grep "\.[hc]$"` ; do sed 's?\$?ZZZ?g' $i | tr '\n' '$' | sed 's?\([ }else]*\)if (\([-;,.\*+=a-z0-9A-Z_>]*\)) {\$[ ]*PetscCall(\([- ._+=a-z0-9A-Z>*,()]*);\)\$\([ ]*\)} \([- ._+=a-z0-9A-Z>*,()]*);\)\$?\1if (\2) PetscCall(\3$\4\5$?g' | tr '$' '\n' | sed 's?ZZZ?$?g' > $i.joe ; mv $i.joe $i ; done

Yes, really ugly but Barry still cannot master awk

Commit-type: housekeeping

show more ...

DMDASNES: add DMDASNESSetFunctionLocalVec() and friends

Merge branch 'barry/2022-05-03/cleanup-makefiles' into 'main'

remove unneeded stuff from makefiles

See merge request petsc/petsc!5211

Add -include */petscdir.mk to makefile that lacked it

for i in `git ls-files | grep makefile | xargs grep -L petscdir.mk`; do
echo $i ;
str=`echo $i |sed -e 's?[-a-zA-Z0-9]*/?../?g' -e 's?makef

Add -include */petscdir.mk to makefile that lacked it

for i in `git ls-files | grep makefile | xargs grep -L petscdir.mk`; do
echo $i ;
str=`echo $i |sed -e 's?[-a-zA-Z0-9]*/?../?g' -e 's?makefile?petsckdir.mk?g'` ;
cp $i tmp
echo "-include $str" > $i
cat tmp >> $i
done

Commit-type: makefile, housekeeping
/spend 15m

show more ...

remove garbage from makefiles

Including
* unused FLAGS variables
* All: lib that did not work
* stray blank lines etc

Commit-type: housekeeping
/spend 1h