use standard bool instead of enum

PetscBool is equivalent to _Bool/bool in C

For C standards prior to C23, true = 1 and false = 0 are defined in <stdbool.h>.
For C23, true and false are real keywor

use standard bool instead of enum

PetscBool is equivalent to _Bool/bool in C

For C standards prior to C23, true = 1 and false = 0 are defined in <stdbool.h>.
For C23, true and false are real keywords.

The Fortran equivalent is logical(C_BOOL) with C_BOOL from
ISO_C_binding.

The C and the C++ standard do not specify the size of Booleans, but they
typically have a size of 1 Byte with b00000000 for false and b00000001 for true.
When using compilers from the same vendor, it is sane to assume that
_Bool/bool in C and bool in C++ are fully compatible. But that is not
guaranteed by the standards

show more ...

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical op

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical operations instead of
MPI_MIN, MPI_MAX, and MPI_LAND.

Note: Most of the previous code was probably working as intended, I did
the changes when debugging error related to the use of standard C Bool and
kept them because it took me a while to understand that MPI has integer
flags and PETSc has Booleans. Using different names makes this clear,
but was and is not done consistently.

show more ...

ensure that Fortran Bool is interoperable

The kind C_BOOL for logical from ISO_C_binding only defines the size of
the logical as 1 Byte. It does not define which values (bit patterns) are
used to en

ensure that Fortran Bool is interoperable

The kind C_BOOL for logical from ISO_C_binding only defines the size of
the logical as 1 Byte. It does not define which values (bit patterns) are
used to encode true and false. In stdbool.h from C, true is defined as 1
and false as 0, but these values are not guaranteed by the Fortran standard.

There are (at least) two contemporary Fortran compilers that use a
difference convention: Intel Fortran (ifort and ifx) and NVIDIA Fortran
(nvfortran, former PGI). Both represent true as all bits set, i.e. -1 for
a signed integer or 255 for an unsigned integer.

Intel Fortran can be made interoperable with the "-standard-semantics" or
"-fpscomp logicals". The latter is now set by default to ensure
interoperability while avoiding effects such as modified name mangling
rules and performance degradations due to the former.

NVIDIA Fortran can be made interoperable with the "-Munixlogical" flag.
This is set manually in the "linux-cuda-single-cxx" pipeline. This is
now set by default.

show more ...

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'

show more ...

Convert some SETERRQ() to PetscCheck()

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}
done

show more ...

missing "s" for isascii and issundials

plex(cgns): Disallow writing already-written solution

This avoids errors like:
```
26 TS dt 1e-06 time 2.6e-05
Min, Max CFL: 3.7707e-08, 0.10498
0 SNES Function norm 6.812037421856e-01
L

plex(cgns): Disallow writing already-written solution

This avoids errors like:
```
26 TS dt 1e-06 time 2.6e-05
Min, Max CFL: 3.7707e-08, 0.10498
0 SNES Function norm 6.812037421856e-01
Linear solve converged due to CONVERGED_RTOL iterations 4
1 SNES Function norm 1.606574458672e-03
Linear solve did not converge due to DIVERGED_PC_FAILED iterations 0
PC failed due to FACTOR_NUMERIC_ZEROPIVOT
Nonlinear solve did not converge due to DIVERGED_LINEAR_SOLVE iterations 1
26 TS dt 1e-06 time 2.6e-05
[0]PETSC ERROR: --------------------- Error Message --------------------------------------------------------------
[0]PETSC ERROR: Error in external library
[0]PETSC ERROR: CGNS error 1 Duplicate child name found: FlowSolution26
```
where a solution was written on timestep 26, the next timestep failed,
then `ts_monitor_solution` attempts to write the same solution to the
CGNS file, but the CGNS library complains that a solution with the same
name already exists.

show more ...

Remove explicitly listed empty files and switch to output/empty.out

Merge branch 'barry/2025-07-02/fortran-no-semicolon-end-of-line' into 'main'

fortran no semicolon at end of line

See merge request petsc/petsc!8519

fortran no semicolon at end of line

Remove all unneeded ; at end of Fortran source code line

Add checkbadSource to check for semicolon at the end of lines

Fortran: Fix HDF5 attribute writing interface

- Ensure real attribute writing routine is available unconditionally in real-only builds
- Add new wrappers in zhdf5f.c for writing:
- Integer attribu

Fortran: Fix HDF5 attribute writing interface

- Ensure real attribute writing routine is available unconditionally in real-only builds
- Add new wrappers in zhdf5f.c for writing:
- Integer attributes
- Scalar (PetscScalar) attributes
- Real attributes
- Update petscviewer.h90 to expose the real version consistently
- Adds a minimal test program (ex80f.F90) to verify functionality
- Update test case to reflect proper names
Fixes: #194

Thanks-to: Martin Diehl

add dependency for HDF5 in test

fix the c stubs to remove garbage values

update the test case to reflect proper names

fix clang format

show more ...

Merge branch 'release'

fix(cgns): Correct handling of unset IterationValues and TimeValues

Draw: Add PetscDrawLGGetData()

ts: Add -ts_run_steps and -ts_monitor_solution_skip_initial

Co-authored-by: Kenneth E. Jansen <kenneth.jansen@colorado.edu>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Barry Smith <

ts: Add -ts_run_steps and -ts_monitor_solution_skip_initial

Co-authored-by: Kenneth E. Jansen <kenneth.jansen@colorado.edu>
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Barry Smith <bsmith@mcs.anl.gov>

show more ...

Merge remote-tracking branch 'origin/release'

Sys: check in PetscLogView() only when in PetscFinalize()

Fixes #1761
Reported-by: Volker Jacht @jac_grs

Random123 casting fix for UNIT64

Merge remote-tracking branch 'origin/release'

Remove the last of the uses of $ in the first line of formatted manual pages

Merge branch 'jolivet/cleanup-symbols' into 'main'

Do not expose unneeded symbols

See merge request petsc/petsc!8335

Do not expose unneeded symbols