Merge branch 'MarDiehl/use-bool-instead-of-enum' into 'main'

use bool instead of enum

See merge request petsc/petsc!8528

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical op

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical operations instead of
MPI_MIN, MPI_MAX, and MPI_LAND.

Note: Most of the previous code was probably working as intended, I did
the changes when debugging error related to the use of standard C Bool and
kept them because it took me a while to understand that MPI has integer
flags and PETSc has Booleans. Using different names makes this clear,
but was and is not done consistently.

show more ...

Merge branch 'jolivet/clang-format-21' into 'main'

clang-format-21

See merge request petsc/petsc!8202

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\

Remove unnecessary braces around one-liners

git grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'

show more ...

Merge branch 'barry/2024-04-29/add-fortran-enums' into 'main'

Major updates to Fortran interface

See merge request petsc/petsc!7517

Fortran 90: fully embrace After 34 years!

- deprecate use of 'F90' in Fortran function names
- use Fortran pointers when appropriate
- the new Fortran API is not backward compatible with previous ve

Fortran 90: fully embrace After 34 years!

- deprecate use of 'F90' in Fortran function names
- use Fortran pointers when appropriate
- the new Fortran API is not backward compatible with previous versions!
- also clean up inconsistent PETSc code detected by new Fortran generation tools
- drop use of bfort
- automatically generate all the Fortran PETSc objects, enums etc from the include files
- generate most of the Fortran interface definitions and functions from the source code
- simplify the number and organization of Fortran modules

Co-authored-by: Jose E. Roman <jroman@dsic.upv.es>

show more ...

Merge branch 'stefanozampini/useless-cast' into 'main'

Remove useless cast

See merge request petsc/petsc!7894

Brain dead fixes for useless casts

Merge remote-tracking branch 'origin/release'

Merge branch 'jose/release/intel-warning-2' into 'release'

Fix another compiler warning in Intel oneAPI 2024.2.1

See merge request petsc/petsc!7855

Merge branch 'barry/2024-09-02/rebased-fix-conversion-warnings' into 'main'

Compiler finds (and forbid) casts from higher precision integers to lower

See merge request petsc/petsc!7806

Fixes for clang-tidy

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in th

Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']

Also fix the code to repository to compile cleanly with these flags in the CI

show more ...

Fix another compiler warning in Intel oneAPI 2024.2.1

src/sys/classes/viewer/impls/socket/send.c:186:29: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
18

Fix another compiler warning in Intel oneAPI 2024.2.1

src/sys/classes/viewer/impls/socket/send.c:186:29: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
186 | char myname[MAXHOSTNAME + 1];
| ^~~~~~~~~~~~~~~
src/sys/classes/viewer/impls/socket/send.c:186:29: note: read of non-const variable 'MAXHOSTNAME' is not allowed in a constant expression
src/sys/classes/viewer/impls/socket/send.c:185:22: note: declared here
185 | static size_t MAXHOSTNAME = 100;
| ^

show more ...

Merge branch 'barry/2024-07-01/fix-petscoptionsgetviewer' into 'main'

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

See merge request petsc/petsc!7667

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

Hence the code needs to be refactored

Introduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

Hence the code needs to be refactored

Introduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routines

Reported-by: James Wright
Thanks-to: Jeremy L Thompson

show more ...

Merge branch 'barry/2024-05-29/minor-fortran-stub-cleanup' into 'main'

More improvements to Fortran stubs and interfaces

See merge request petsc/petsc!7598

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of

This requires some changes to user FORTRAN code

Pass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an array
Pass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGER
Pass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]
Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXX

The compiler will now automatically prevent you from using the wrong argument type for the first three bullets above
This will also require an update sowing with the new sowing branch this MR is using.

show more ...

Merge branch 'barry/2024-04-13/fix-sowing-strings' into 'main'

Update PETSc to use sowing bfort that handles string arguments and PETSC_NULL_INT

See merge request petsc/petsc!7480

Update source code removing all unneeded /*@C and associated manual stubs and interfaces

Merge remote-tracking branch 'origin/release'

Merge branch 'barry/2024-04-24/doc-fixes/release' into 'release'

release docs fixes

See merge request petsc/petsc!7498

release docs fixes

Commit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, example
Funded-by:
Project:
Time: hours
Reported-by:

release docs fixes

Commit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, example
Funded-by:
Project:
Time: hours
Reported-by:
Thanks-to:
Development Tools: Vim, Emacs, Eclipse

show more ...

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

checkbadSource: rules for PetscFunctionBegin and derivatives