Merge branch 'barry/2024-09-29/fix-function-typedef-style' into 'main'Unify handling of context destructorsSee merge request petsc/petsc!7900
Unifies all context destructors to have a form of PetscCtxDestroyFn == PetscErrorCode (*)(void **)Changes the previous subset of destructor APIs that used PetscErrorCode (*)(void *) (mostly those t
Unifies all context destructors to have a form of PetscCtxDestroyFn == PetscErrorCode (*)(void **)Changes the previous subset of destructor APIs that used PetscErrorCode (*)(void *) (mostly those thatused PetscContainer- Now allows any context to be a PetscObject- Will provide a cleaner mapping to bindings in other languages- Simplifies the maintenance of PETSc source code; improves clarityNot backward compatible, compiler warnings will tell users what functions need to be updated
show more ...
Plex+Viewer: Added Python and PyVista viewers- Enable viewer filename interface for Python viewer- Add -viewer_python_filename to set the output filename- Add -dm_plex_transform_active_values to e
Plex+Viewer: Added Python and PyVista viewers- Enable viewer filename interface for Python viewer- Add -viewer_python_filename to set the output filename- Add -dm_plex_transform_active_values to explicitly set values in the label- Add -dm_plex_option_phases to control sequencing of setup from the command line
cgns viewer: Sanity check arguments
Minor fixes in manpages
Use PetscObjectContainerCompose() when applicable
CI: update checkclangformat to use clang-format-19.1.0
Remove unneeded parentheses
Merge branch 'jrwrigh/cgns_parallel_io' into 'main'CGNS: Add parallel Plex building, VecLoad, and moreSee merge request petsc/petsc!7826
cgns: Add parallel Plex read, VecLoad, etc.- Parallel Plex building with `-dm_plex_cgns_parallel`- Parallel solution reading via `VecLoad()`- Added `PetscViewerCGNSOpen()`- Added `PetscViewerCGN
cgns: Add parallel Plex read, VecLoad, etc.- Parallel Plex building with `-dm_plex_cgns_parallel`- Parallel solution reading via `VecLoad()`- Added `PetscViewerCGNSOpen()`- Added `PetscViewerCGNSGetSolution{Time,Name}()`,`PetscViewerCGNSSetSolutionIndex()`
Merge branch 'jolivet/remove-cast' into 'main'Use NULL or nullptr instead of casted 0See merge request petsc/petsc!7857
Merge remote-tracking branch 'origin/release'
Use NULL or nullptr instead of casted 0
Introduce PetscCallReturnMPI() to check for PETSc errors in PETSc provided MPI callpacks.
Fix MPIU_* routines to always return MPI error codes and thus be usable with PetscCallMPI()Introduce MPIU_Count to be used when MPI_Count is not available
Fixes for clang-tidy
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in th
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in the CI
Fix another compiler warning in Intel oneAPI 2024.2.1src/sys/classes/viewer/impls/socket/send.c:186:29: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] 18
Fix another compiler warning in Intel oneAPI 2024.2.1src/sys/classes/viewer/impls/socket/send.c:186:29: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] 186 | char myname[MAXHOSTNAME + 1]; | ^~~~~~~~~~~~~~~src/sys/classes/viewer/impls/socket/send.c:186:29: note: read of non-const variable 'MAXHOSTNAME' is not allowed in a constant expressionsrc/sys/classes/viewer/impls/socket/send.c:185:22: note: declared here 185 | static size_t MAXHOSTNAME = 100; | ^
Remove empty comments from the source, that is /* */Also remove some /******************* commentsAlso remove some multiline comments with /* and */ at the beginning and end of each line
Fix bug in PetscViewerBinaryWriteReadAll() thatprevented saving dense matrices whose number of entries on MPI rank 0 is greater than PETSC_MPI_INT_MAX byremoving unneeded PetscCall(PetscMPIIntCast
Fix bug in PetscViewerBinaryWriteReadAll() thatprevented saving dense matrices whose number of entries on MPI rank 0 is greater than PETSC_MPI_INT_MAX byremoving unneeded PetscCall(PetscMPIIntCast(count, &cnt)); on rank 0.Also removed unneeded potentially large malloc when used with on one MPI rankReported-by: Sreeram R Venkat <srvenkat@utexas.edu>Code still does not work if any MPI process besides rank 0 has a matrix with a number of entries greater than PETSC_MPI_INT_MAX
Add shared memory support for PCMPI using both shmget() and MPI_Win_allocate_shared()
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routinesReported-by: James WrightThanks-to: Jeremy L Thompson
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGERPass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXXThe compiler will now automatically prevent you from using the wrong argument type for the first three bullets aboveThis will also require an update sowing with the new sowing branch this MR is using.
All constructors should do PetscAssertPointer on output objectReported-by: Blaise BourdinConstructors should not initialize the output to NULL upon entry, serves no purposeFix some formatting i
All constructors should do PetscAssertPointer on output objectReported-by: Blaise BourdinConstructors should not initialize the output to NULL upon entry, serves no purposeFix some formatting in constructors
12345678910>>...32