Make PetscErrorCode a non-discardable enum

Merge branch 'barry/2022-05-01/fix-petsccall-fortran' into 'main'

Add proper support for PetscCall(), PetscCallMPI() for Fortran

See merge request petsc/petsc!5196

Add proper support for PetscCall(), PetscCallMPI() for Fortran

Also add support for PetscCallA(), PetscCallMPIA() for Fortran that abort

Provide support for printing the Fortran line and filenames

Add proper support for PetscCall(), PetscCallMPI() for Fortran

Also add support for PetscCallA(), PetscCallMPIA() for Fortran that abort

Provide support for printing the Fortran line and filenames with the errors or not depending on how long Fortran source code lines can be

Minor improvements to handling calls to PetscError() with no function string

Commit-type: error-checking, feature
/spend 2h

show more ...

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

Merge branch 'jacobf/2021-11-02/attribute-format-sys' into 'main'

Feature: PETSC_ATTRIBUTE_FORMAT - sys

See merge request petsc/petsc!4520

apply PETSC_ATTRIBUTE_FORMAT and related fixes to sys sources

Merge branch 'balay/remove-stdcall' into 'master'

Remove usage of PETSC_HAVE_FORTRAN_STDCALL, PETSC_BLASLAPACK_STDCALL,...

See merge request petsc/petsc!2546

Remove usage of PETSC_HAVE_FORTRAN_STDCALL, PETSC_BLASLAPACK_STDCALL, HAVE_FORTRAN_MIXED_STR_ARG flags - as Compaq f90 compiler is no longer supported

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to ne

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to new ANL style
Hash: Quick documentation fix
PetscBinaryViewerRead -> PetscViewerBinaryRead
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing

Merge branch 'master' into knepley/feature-pc-patch

* master: (562 commits)
fix clang-analyzer warning
Developers manual never use system randomizers in PETSc and example source code.
missing CHKERRQ()
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Add a test for ex21
Fix error in ex21
Add missing fortran interface that handles null objects
DMComposite: add missing guards
MatPreallocate: fix overpreallocation of local rows
style fixes
MatView_MPI_DA: do not print twice the class prefix
MatSetOperation: stash the original MatView_XXX in the viewnative function pointer
DMCreateInterpolation_DA gracefully error instead of catching FPE signals
MatIncreaseOverlap: preserve communicator of index sets
MatMPIAIJ: fix indentation and missing CHKERRQ
ISBuildTwoSided: remove tabs and fix style
Fix documentation
PetscViewerDraw: fix unininitialized warning from valgrind
MatConvert_SeqAIJ_SeqBAIJ: remove error for non square matrices and add MAT_REUSE_MATRIX case
Mat: MAT_INPLACE_MATRIX can be used for transposition with rectangular matrices
...

Conflicts:
src/dm/dt/interface/dtfe.c
src/dm/impls/plex/plex.c
src/dm/impls/plex/plexfem.c
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/makefile
src/snes/examples/tutorials/output/ex62_18.out
src/snes/examples/tutorials/output/ex62_19.out
src/snes/examples/tutorials/output/ex62_20.out
src/snes/examples/tutorials/output/ex62_20_parmetis.out
src/snes/examples/tutorials/output/ex62_21.out
src/snes/examples/tutorials/output/ex62_22.out
src/snes/examples/tutorials/output/ex62_23.out
src/snes/examples/tutorials/output/ex62_24.out
src/snes/examples/tutorials/output/ex62_25.out
src/snes/examples/tutorials/output/ex62_26.out
src/snes/examples/tutorials/output/ex62_27.out
src/snes/examples/tutorials/output/ex62_28.out
src/snes/examples/tutorials/output/ex62_29.out
src/snes/examples/tutorials/output/ex62_2d_p3_1.out
src/snes/examples/tutorials/output/ex62_30.out
src/snes/examples/tutorials/output/ex62_31.out
src/snes/examples/tutorials/output/ex62_32.out
src/snes/examples/tutorials/output/ex62_33.out
src/snes/examples/tutorials/output/ex62_34.out
src/snes/examples/tutorials/output/ex62_35.out
src/snes/examples/tutorials/output/ex62_36.out
src/snes/examples/tutorials/output/ex62_pc_simple.out
src/snes/examples/tutorials/output/ex62_pc_simplec.out
src/snes/examples/tutorials/output/ex62_quad_q2p1_full.out
src/snes/examples/tutorials/output/ex62_quad_q2q1_full.out
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'knepley/feature-error-logging' of bitbucket.org:petsc/petsc into knepley/feature-error-logging

Merge branch 'master' into knepley/feature-error-logging

* master: (324 commits)
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Revert "tgamma: icc on wi

Merge branch 'master' into knepley/feature-error-logging

* master: (324 commits)
DT: Reverting the tgamma change broke MPFR - I guess we need a nightly build with it in
Revert "tgamma: icc on windows requires mathimf.h for tgamma."
setup routine no longer calls PetscCalloc5 if the arrays have already been allocated in a previous setup call
clarify SNESGetFunction()
Move MOAB docs to submansec so as not to clutter DM mansec
doc: remove matlab from doc generation dependency - i.e remove 'alldoc3' and use 'html' to generate corresponding '*.m.html' files.
Remove matlab pounders related cruft that is not required. Document the matlab code better and include an appropriate message in the help text.
Fixed typo.
Remove the inclusion of matlab in testing.
Finalizing comments and the work for the test problems.
Finished the testing and generation of plots. Some simple bug fixes addressed.
Set -Wl,-rpath for Mac OS Matlab mkl directory; don't pass -nojvm to matlab since it causes crashes on Barry's machine and is not needed
Added list of known problems with the code.
Added a comment on ignoring the return from Tao.
Finish with initial implementation of matlab interface to test TAO pounders.
Working through the matlab interface for pounders testing.
Fix typo in manual Reported-by: Jaroslaw Piwonski (CAU) <jpi@informatik.uni-kiel.de>
Fixed mkl_sparse_sypr() calls that were using an unsupported value in the matrix descriptor.
test harness: simplify code that checks for sequential-only tests
Fix the doc for call-backs drdyf drdpf
...

show more ...

Merge branch 'maint'

Merge remote-tracking branch 'origin/jed/gfortran8-strlen-type/maint' into maint

Fortran: detect gfortran-8 and use size_t for string lengths

https://gcc.gnu.org/gcc-8/porting_to.html

Revert "remove dead code"

This reverts commit e42d1bb89c832af7cff7ca5dc681a50206c18b0f.

remove dead code

Commit-type: style-fix

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page information about convergence testing when using KSPRICHARDSON
SNES ex5: Restore old output since this breaks an example I have
Noted that some Cray XC systems will use 'aprun' instead of 'srun'. Thanks to Herr Doktor Hong Zhang for this suggestion.
Added example configure script for Cray XC40 with KNL processors (e.g., NERSC Cori).
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7
SNES ex5: make boundary condition handling consistent for symmetry
SNES ex5: use L2 norm and *_monitor_short for output
SNES ex5: the L^2 norm scales with the l^2 norm over sqrt(N)
SNES ex5: refactor MMS capability to avoid extreme code duplication
Documentation fix: typo in PetscLogStageRegister manual page.
nodes -> vertices
rename DMNetworkGetComponentTypeOffset -> DMNetworkGetComponentKeyOffset
rename DMNetworkGetConnectedNodes() -> DMNetworkGetConnectedVertices()
Jacobians for adjoints for explicit methods and constant Jacobians never got initialized
fix complex build error
fix build failure with fortran interface
fix compile error with cdc753b64c658d532d7813e942002e67025667a6
...

Conflicts:
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/ex69.c

show more ...

Merge remote-tracking branch 'origin/barry/feature-fortran-petscerror'

fortran: add SETERRA() and CHKERRA() macros as ifort flags 'return' in 'program main' as error

/sandbox/petsc/petsc.clone-2/src/sys/examples/tutorials/ex4f90.F90(42): error #6353: A RETURN statement

fortran: add SETERRA() and CHKERRA() macros as ifort flags 'return' in 'program main' as error

/sandbox/petsc/petsc.clone-2/src/sys/examples/tutorials/ex4f90.F90(42): error #6353: A RETURN statement is invalid in the main program.
call MPI_Comm_size(PETSC_COMM_WORLD,size,ierr);if (ierr .ne. 0) then ; call PetscError(PETSC_COMM_SELF,ierr,PETSC_ERROR_REPEAT,PETSC_NULL_CHARACTER); return; endif

And attempt to shorten the macros by using PetscErrorF() subroutine

And fix all examples to use SETERRA/CHKERRA in main program (instead of SETERRQ/CHKERRQ)

Note: CHKERRA are different from CHKERRABORT on the C interface - as it does not take 'comm' option

show more ...