Merge branch 'jolivet/pacify-gcc' into 'main'

Fix (erroneous) -Wmaybe-uninitialized (#1847)

See merge request petsc/petsc!9036

Fix style of 6497c311e7b976d467be1503c1effce92a60525c

Merge branch 'jolivet/clang-format-21' into 'main'

clang-format-21

See merge request petsc/petsc!8202

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}
done

show more ...

Merge branch 'stefanozampini/useless-cast' into 'main'

Remove useless cast

See merge request petsc/petsc!7894

Brain dead fixes for useless casts

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

checkbadSource: rules for PetscFunctionBegin and derivatives

Merge branch 'jolivet/rm-first-empty-line' into 'main'

Remove first and last empty lines

See merge request petsc/petsc!6892

Remove first and last empty lines

Merge branch 'tisaac/feature-log-handler' into 'main'

Deglobalize logging into PetscLogHandler and PetscLogState

See merge request petsc/petsc!6709

Profiling: Add interface for getting unqiue global logging names

It has been implicit since the beginning that, in default logging
interface, stages, events, and classes have to be registered in the

Profiling: Add interface for getting unqiue global logging names

It has been implicit since the beginning that, in default logging
interface, stages, events, and classes have to be registered in the same
order on every process. This is harder to accomplish with nested
logging, where new events and stages may be created on the fly.

This change uses the newly created PetscLogState interface
to assign each event/stage/class a globally unique id based
on its name. Essentially, each process in turn tells the other
processes the names of things that haven't been assigned ids yet,
and they all agree on their new ids. The global ids are used
to construct global <-> local maps.

In the easy case of all processes having the same things named in the
same order, the process stops after they all confirm that they
have the same names in the same order.

This communication pattern is straight-forward and does not
attempt to be efficient, but log viewing lots and lots of
MPI_Allreduces, so the cost of this will not be noticeable.

show more ...

Profiling: Add PetscLogState interface to describe events and stages

The design that is being implemented is a separation between the
logging state that is common to multiple log handlers and the lo

Profiling: Add PetscLogState interface to describe events and stages

The design that is being implemented is a separation between the
logging state that is common to multiple log handlers and the log
handlers themselves. This new interface PetscLogState will
become the replacement for PetscStageLog, but this change
only introduces it without deploying it.

Internally, PetscLogState is:

- A registry (PetscLogRegistry) of more-or-less immutable information
about stages, events, and classes that have been registered. The
registry is not exposed, but the registry entries (PetscLogEventInfo,
PetscLogStageInfo, PetscLogClassInfo), that I feel comfortable exposing
them (pass-by-copy) through PetscLogStateXXXGetInfo() functions.

- A stack of stages that have been pushed and popped

- A PetscBT describing the active/inactive state of logging stages
and events. I have kept the existing semantics of
PetscLogStateSetActive / PetscLogEventActivate /
PetscLogEventActivateClass, which is: if the stage is active
and the (event,stage) pair is active, then log handling proceeds.
This logic is encoded in PetscLogStateStageEventIsActive

- For symmetry I have added PetscLogClass that matches PetscLogStage
and PetscLogEvent

- The profiling interface is littered with ad hoc resizable array types
(PetscEventRegLog, PetscEventPerfLog, PetscClassPerfLog,
PetscStageLog). The intention is for these to go away. This commit
introduces a PetscHashMap-style macro constructor for resizable
arrays (PETSC_LOG_RESIZABLE_ARRAY). It is only used in implementing
these arrays: they do not appear in the public interface. Storage
could be switched to a hashmap or other backing storage at some point
in the future.

show more ...