replace if (...) return PetscError with PetscCheck() and other minor tweaks

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...

chkerr and friends wrapped

Merge branch 'jacobf/2022-01-05/c99' into 'main'

Feature: C99 and C++11

See merge request petsc/petsc!4700

rename PetscAssert() -> PetscCheck() and PetscAssertDebug() -> PetscAssert()

add PetscAssert() and PetscAssertFalse()

make PetscInfo() variadic

SETERRQ[1-9]+ begone

Merge branch 'jose/spelling-errors' into 'main'

Fix many spelling errors in manpages and comments

See merge request petsc/petsc!4283

Fix spelling errors in manpages and comments

Merge branch 'barry/2021-03-22/fix-malloc-failure' into 'main'

PetscMalloc() was using "allocating" space, zeroing it etc before verifying a...

See merge request petsc/petsc!3747

PetscMalloc() was using "allocating" space, zeroing it etc before verifying a non-NULL pointer was even returned

Fix the code to immediately check if a non-NULL pointer was returned, otherwise immed

PetscMalloc() was using "allocating" space, zeroing it etc before verifying a non-NULL pointer was even returned

Fix the code to immediately check if a non-NULL pointer was returned, otherwise immediately generate an error.

Commit-type: bug-fix
Project: Brain project
/spend 10m
Reported-by: Getnet Betrie <gbetrie@anl.gov>

show more ...

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge branch 'master' into 'barry/2019-08-22/fix-fblaslapack-for-nag'

# Conflicts:
# lib/petsc/conf/test

Merge branch 'barry/2019-09-04/feature-nan-malloc' into 'master'

Add code to initialize PetscMalloc() memory with Nan. Simplify and clarify the...

See merge request petsc/petsc!2017

Fix use of incorrect variable name that appears in some code paths.

Commit-type: bug-fix
Reported-by: Jed Brown <jed@jedbrown.org>

Add code to initialize PetscMalloc() memory with Nan. Simplify and clarify the options for controlling PetscMalloc() debugging.

This now trivially detects an error that lay undetected in ts/examples

Add code to initialize PetscMalloc() memory with Nan. Simplify and clarify the options for controlling PetscMalloc() debugging.

This now trivially detects an error that lay undetected in ts/examples/tutorials/multistage/ex5.c for months

Commit-type: style-fix, feature, documentation

show more ...

Merged in barry/optimize-aij-da (pull request #1762)

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

1) PetscCalloc*() now uses system calloc()
2) Merged some Pets

Non-numeric optimizations focused on AIJ, MatFDColoring, and DMCreateMatrix_DA_*AIJ, looking to improve performance in GPU environments

1) PetscCalloc*() now uses system calloc()
2) Merged some PetscMalloc*()
3) Eliminated unneeded PetscCalloc*()
4) Removed some memory allocations and copies in MatFDColoringSetUp(), added local variables for better compiler optimization
5) Added MatSetValues_SeqAIJ_SortedFull(), added MatSetOption(MAT_SORTED_FULL)
6) Optimized DMCreateMatrix_DA_*AIJ for nonperiodic case to automatically have sorted columns (faster MatSetValues() times)
7) Eliminated call to PetscMemzero() in PetscFree()

Commit-type: style-fix, feature

show more ...

Merge remote-tracking branch 'origin/psanan/docs-remove-manconcepts' [PR #1733]

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but not from examples).

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merged petsc/petsc into master

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...