Merge branch 'jolivet/remove-cast' into 'main'

Use NULL or nullptr instead of casted 0

See merge request petsc/petsc!7857

Use NULL or nullptr instead of casted 0

Merge branch 'barry/2024-07-01/fix-petscoptionsgetviewer' into 'main'

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

See merge request petsc/petsc!7667

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

Hence the code needs to be refactored

Introduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI

The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore model

Hence the code needs to be refactored

Introduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routines

Reported-by: James Wright
Thanks-to: Jeremy L Thompson

show more ...

Merge branch 'barry/2024-02-20/fix-petscviewergetsubcomm' into 'main'

Document that PetscViewerGetSubViewer() is collective on the outer viewer and fix bugs.

See merge request petsc/petsc!7309

Document that PetscViewerGetSubViewer() is collective on the outer viewer and fix bugs.

Reported-by: Pierre Jolivet

Merge branch 'barry/2023-11-21/fix-thread-safety-petscoptionsgetviewer' into 'main'

Fix PetscOptionsGetViewer() so it works in a thread-safe way

See merge request petsc/petsc!7047

Fix PetscOptionsGetViewer() so it works in a thread-safe way

When PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is shared
by all threads that call PetscOptio

Fix PetscOptionsGetViewer() so it works in a thread-safe way

When PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is shared
by all threads that call PetscOptionsGetViewer(). In the previous code PetscObjectReference() and
dereference (via PetscViewerDestroy() where called on the viewer by multiple threads after the viewer
was accessed thus corrupting the object.

This branch introduces a PetscOptionsRestoreViewer() that allows not doing the referencing and dereferencing
on persistant viewers, thus removing the specific race condition above.

Other possible solutions include

Use a lock on each PetscObjectReference/Dereference() just in case they are shared. Could be time consuming so one
could mark each object as either threadshared or independent and only do the locks on threadshared objects. This lowers
the cost but would require more extensive changes to PETSc infrastructure. And I do not know if this shared/not shared model
is what we need in the long run, though it might be.

show more ...

Merge branch 'jolivet/rm-first-empty-line' into 'main'

Remove first and last empty lines

See merge request petsc/petsc!6892

Remove first and last empty lines

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'barry/2022-08-23/fix-sys-man' into 'main'

Fix up all manual pages in src/sys directory

See merge request petsc/petsc!5559

Fix up all manual pages in src/sys directory

Commit-type: documentation
/spend 10h

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-07-23/add-petscbeginuser' into 'main'

Add PetscFunctionBeginUser to all PETSc C/C++ examples

See merge request petsc/petsc!5470

Add PetscFunctionBeginUser to all PETSc C/C++ examples

Now the stack frames will contain the main program and the correct line numbers in them

git ls-files | egrep "(tutorials|tests)" | xargs sed -

Add PetscFunctionBeginUser to all PETSc C/C++ examples

Now the stack frames will contain the main program and the correct line numbers in them

git ls-files | egrep "(tutorials|tests)" | xargs sed -i "s?\(PetscCall(PetscInitialize(&argc\)?PetscFunctionBeginUser;\n \1?g"

Commit-type: error-checking, testing-fix
/spend 15m

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'psanan/docs-remove-concepts' into 'release'

Docs: remove Concepts

See merge request petsc/petsc!5065

Docs: remove "Concepts:" and related comments in /*T .. T*/ blocks

Remove all \*T ... comment blocks with e.g.

cd src && find . -type f -exec sed -i '/^[! ] *\/\*T$/,/^[! ]*T\*\/$/d' {} \;

Clea

Docs: remove "Concepts:" and related comments in /*T .. T*/ blocks

Remove all \*T ... comment blocks with e.g.

cd src && find . -type f -exec sed -i '/^[! ] *\/\*T$/,/^[! ]*T\*\/$/d' {} \;

Clean up resulting double blank lines with e.g.

cd src && find . type f \( -name "*.c" -o -name "*.cxx" -o -name "*.F" -o -name "*.F90" \) -exec sh -c "cat -s {} > tmp && mv tmp {}" \;

Manually revert those changes from the vendored code (src/sys/yaml)

Manually restore a few comments from these blocks.

Manually remove "Concepts:" and "Processors:" comments from files
which have these outside of "\*T" blocks automatically deleted above.

show more ...

Merge branch 'barry/2022-03-22/rm-petsccheckfalse-mpi-size' into 'main'

Remove use of PetscCheckFalse() on a subset of examples

See merge request petsc/petsc!5006

Remove all use of PetscCheckFalse() for MPI size on a subset of examples

Commit-type: error-checking, housekeeping
/spend 35m

Merge branch 'jacobf/2022-02-23/variadic-chkerr' into 'main'

Variadic CHKERRQ()

See merge request petsc/petsc!4889

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX

The great renaming:

- CHKERRQ() -> PetscCall()
- CHKERRV() -> PetscCallVoid()
- CHKERRMPI() -> PetscCallMPI()
- CHKERRABORT() -> PetscCallAbort()
- CHKERRCONTINUE() -> PetscCallContinue()
- CHKERRXX() -> PetscCallThrow()
- CHKERRCXX() -> PetscCallCXX()
- CHKERRCUDA() -> PetscCallCUDA()
- CHKERRCUBLAS() -> PetscCallCUBLAS()
- CHKERRCUSPARSE() -> PetscCallCUSPARSE()
- CHKERRCUSOLVER() -> PetscCallCUSOLVER()
- CHKERRCUFFT() -> PetscCallCUFFT()
- CHKERRCURAND() -> PetscCallCURAND()
- CHKERRHIP() -> PetscCallHIP()
- CHKERRHIPBLAS() -> PetscCallHIPBLAS()
- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()
- CHKERRQ_CEED() -> PetscCallCEED()
- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()
- CHKERRMKL() -> PetscCallMKL()
- CHKERRMMG() -> PetscCallMMG()
- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()
- CHKERRCGNS() -> PetscCallCGNS()
- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()
- CHKERRSTR() -> PetscCallSTR()
- CHKERRTC() -> PetscCallTC()

show more ...