Fix capture of MPI error code in MPIU_Allreduce()

Otherwise MPI error code could propagate up posing as a PETSc error code

Commit-type: error-checking
/spend 20m

Merge branch 'barry/2020-10-08/fix-mpi-error-codes' into 'master'

Convert MPI error type to PETSc error with string message for all MPI calls

See merge request petsc/petsc!3326

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-pro

Convert MPI error type to PETSc error with string message for all MPI calls

Now PETSc examples will ONLY return PETSc error codes and never MPI error codes directly so we can understand and post-process their
errors better.

The test harness will now automatically retry tests that fail with MPI, this may help with Intel MPI that produces
seemingly random failures.

Commit-type: error-checking
/spend 30m

show more ...

Merge branch 'maint'

Merge branch 'barry/2019-10-28/fix-petscbarrier-fortran/maint' into 'maint'

Fix for calling PetscBarrier() from Fortran

See merge request petsc/petsc!2235

Fix for calling PetscBarrier() from Fortran

Commit-type: bug-fix
Reported-by: Victor Eijkhout <eijkhout@tacc.utexas.edu>

Merge branch 'jed/fix-int-overflow' into 'master'

pbarrier.c: hash in unsigned rather than signed (overflow)

See merge request petsc/petsc!2092

pbarrier.c: hash in unsigned rather than signed (overflow)

Merge remote-tracking branch 'origin/psanan/docs-remove-manconcepts' [PR #1733]

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but not from examples).

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'master' into jpusztay/feature-swarm-symplectic-example

Merge branch 'master' into jpustay/feature-swarm-example

Merged petsc/petsc into master

Merged petsc/petsc into master

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (345 commits)
Update dev notes for the coming release
Increase patchlevel to 3.9.4
doc fixes
Added some AIJSELL tests t

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (345 commits)
Update dev notes for the coming release
Increase patchlevel to 3.9.4
doc fixes
Added some AIJSELL tests that mirror the SELL tests.
Bib: More refs
Removed use of hardwired -1 to represent PETSC_NULL_XXX object, since the null value is now 0.
fix memleaks flagged by valgrind
ex62: disable long running test and workaround differences in iteration counts on various builds.
Add FAQ we can point to when users get error messages such as: "PETSc was configured with one OpenMPI mpi.h version but now appears to be compiling using a different OpenMPI mpi.h version"
swith test from mpich to openmpi as mpich ch3:sock is unuserable per PetscShmCommGet()
DM: Forgot to move include statement
fix nightlybuild issues - disable hypre [for openmp] and fix uninitialized variables
tests: enable openmp and hwloc with one of the mumps tests
Default BoomerAMG smoothers
Configure: Revert changes from debb90c, so that we are back to the original Libmesh
Configure: Reverted change for Libmesh from 83cd5d7
Split vecimpl.h into vecimpl.h and vecscatterimpl.h
SNES ex62: Turned off some tests for other precisions and shortened output of sensitive tests
Use mmap to allocate the shared pthread barrier if available
Add configure test for functional mmap
...

Conflicts:
include/petscconvest.h
src/snes/examples/tutorials/ex13.c
src/snes/interface/snes.c
src/snes/utils/convest.c

show more ...

Merge branch 'master' into knepley/fix-superdm-is

* master: (123 commits)
Fix a few more Fortran objects to have their NULL value match the C NULL value
remove dead code
Add variable point blo

Merge branch 'master' into knepley/fix-superdm-is

* master: (123 commits)
Fix a few more Fortran objects to have their NULL value match the C NULL value
remove dead code
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
fix mpiuni test
Remove CHKFORTRANNULLOBJECTDEREFERENCE since it is no longer needed with Fortran null equal to C null
PETSCFEOPENCL: declare PetscFEGetTabulation_Basic as external
PETSCFEOPENCL: declare PetscFESetUp_Basic as external
Change Fortran null pointer to match C null pointer
one more fix
jenkins: run 'cleantest' after examples are run - to recover diskspace
logical order bug in diagbrdn update fixed, tests updated again
replace new -petscspace_order instances with -petscspace_degree
PETSCSPACETENSOR: clear up naming confusion of subspaces
regression.py: remove configure code related to old test suite - now that SLEPc no longer needs it
PetscSpaceSetup_Poly(): make idempotent
Plex ex3: update tests
Lift changes to defunct dtfe.c from [PR #1074]
PetscSpace_Tensor: clarification of vector-valued
PetscSpace_Tensor: allow height subspaces, fixes tabulation initialization
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master:
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
Rem

Merge branch 'master' into knepley/feature-pc-patch

* master:
Add variable point block Jacobi for MPIAIJ matrix.
should not pass user contexts through CHKFORTRANNULLOBJECT in Fortran stubs
Remove CHKFORTRANNULLOBJECTDEREFERENCE since it is no longer needed with Fortran null equal to C null
Change Fortran null pointer to match C null pointer

Conflicts:
src/ksp/ksp/interface/itfunc.c

show more ...

Merge remote-tracking branch 'origin/barry/change-fortran-null'

Remove CHKFORTRANNULLOBJECTDEREFERENCE since it is no longer needed with Fortran null equal to C null

Commit-type: feature

Merged petsc/petsc into master

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler war

Merge branch 'master' into knepley/feature-pc-patch

* master: (226 commits)
fix bib
type in bibtex entry
copy edits to bibtex items
Hypre matrix: small fix
Hypre matrix: fixed compiler warnings
Plex: Fixed missing PetscRealPart() in partition balance.
Added MatZeroEntries_HYPRE
Removed outdated mention of cusp and thrust from installations instructions; remove cusp from example configurations
Remove another location where fshift was used with -1 to indicate handling of error condition which was never handled
Generate an immediate error, if requested, if CG detects indefinite PC or Mat
Remove hack of using special fshift value of -1 to indicate error handling, was broken for MatSOR_SeqAIJ and did nothing constructive in the other cases
Options: Fix sys_tests-ex6 to not print options
PetscOptionsDestroy: Add missing free() call
Configure: Pragmatic now requires Cxx11
Error check that the communicator in the IS matches that in the matrix otherwise ISAllGather() produces incorrect results.
Options: Code reorganization and faster option lookup
fix compile warning
Doc: Fixed manpage for PCFieldSplitSetSchurPre()
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
...

Conflicts:
include/petscdm.h
include/petscpc.h
include/petscpctypes.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexdistribute.c
src/ksp/pc/impls/makefile
src/ksp/pc/interface/pcregis.c

show more ...