Sys: Replace 0 -> NULL for pointers

Add warning about unfreed memory for certain string creation functions, adding missing manual page seealso for string operations.

Merged in barry/cleanup-petscconf-h (pull request #1834)

Remove testing and inserting into petscconf.h items that are not actually used by PETSc

Remove testing and inserting into petscconf.h items that are not actually used by PETSc

1) PETSC_HAVE_LIBXXXX - which was rarely used
be careful with the package libpng and libjpeg since they hav

Remove testing and inserting into petscconf.h items that are not actually used by PETSc

1) PETSC_HAVE_LIBXXXX - which was rarely used
be careful with the package libpng and libjpeg since they have lib in the name of the package
2) various system include files that are never used or always exist: for example stdlib.h
3) various system functions that are never used or always exist
4) fixes for requires for MUMPS and SuperLU_DIST when dependent packages are installed or not installed (unrelated to the rest of this pull request)
5) packages that always exist such as PETSC_HAVE_BLASLAPACK, or are not used by PETSc such as PETSC_HAVE_NETCFD
6) remove a couple of uses of HAVE_LIB* in the code that were not needed by adjusting the configure code slightly
7) remove all the #if guards for each entry in petscconf.h since petscconf.h already has a guard and
the values are never defined else where the extra guards just make the file cluttered

For a build with about 10 external packages this reduced the size of petscconf.h from 1236 lines to 828/4 around 220 entries.

Commit-type: style-fix, cleanup

Reported-by: Jed Brown <jed@jedbrown.org

show more ...

Merge remote-tracking branch 'origin/psanan/docs-remove-manconcepts' [PR #1733]

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but

Man pages: remove Concepts: fields

These fields were previously stripped from the man pages by logic removed in
21a59cba2737d49dc2f0bd12c08db0d2a3f3f209

Remove these fields from all man pages (but not from examples).

This is accomplished with GNU sed (gsed on OS X), with the following commands.
*Warning* that this type of command can corrupt a .git directory,
so be cautious in reusing or modifying these commands. They first look
for and delete matching lines with a following line consisting of only whitespace,
and then delete any remaining matching lines.

find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find src -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/ {N; /\n\s*$/d}' {} +
find include -type f -not -path "*/examples/*" -not -name "*.html" -not -name "*.bib" -exec gsed -i '/Concepts:/d' {} +

Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed

show more ...

Merge branch 'maint'

Merged in stefano_zampini/misc-fixes/maint (pull request #1550)

Stefano zampini/misc fixes/maint

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

Housekeeping: strip out __FUNC__ or __FUNCT__ from PETSc

Merge from master

Merged petsc/petsc into master

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyze

Merge branch 'master' into knepley/fix-superdm-is

* master: (455 commits)
bib: spell out some names for format consistency with related refs
bib: two 2018 pubs now appeared
cleaning up analyzer warnings
compile fixes (workarround PGI bug?):
undoing the branch's changes to leastsquares outputs
more fixes for complex builds
compile error fix for complex builds
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Fixed an uninitialized variable and got rid of an unused one.
memleak fixed and output files updated
fixing build errors on some archs
Mat: obey options prefix of Mat in MatNullSpaceTest
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/dm/interface/dmi.c

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix

Merge branch 'master' into knepley/feature-pc-patch

* master: (281 commits)
compile fixes (workarround PGI bug?):
1) Look for 64 bit integer MKL BLAS if 64 bit indices are used with PETSc 2) Fix Pardiso code to only compile pardiso_init64 when needed, otherwise can generate warnings/errors
jenkins: run 'cleantest' before 'allgtest-tap' - an attempt to fix errors of type:
cuda: protect cuda includes
fix cuda warnings.
fix complex compile error
Revert "Improved polymorphism of interfaces for MatSetValuesBlocked()"
Bib: Updated ref
Doc: More function documentation
petscvec: move PetscSFCreateFromZero from vscat to vec sources
Mat: obey options prefix of Mat in MatNullSpaceTest
Plex+SNES: Must pass user context through
vscat: move ftn-custom to correct location remove custom vecscatterdestroy_()
vscat: move interface routines to correct location
vscat: delete dead code
fix compile error
FE: Correct coordinates in IntegrateBd
Bib: Added refs
SNES ex17: 3D tests must require a 3D grid generator
Plex+TS: We cannot run the check with the same vector that is the TS solution
...

Conflicts:
include/petsc/private/dmpleximpl.h
src/docs/website/documentation/changes/dev.html
src/snes/examples/tutorials/ex13.c
src/snes/utils/dmplexsnes.c

show more ...

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incor

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (249 commits)
Bib: Added refs
Netcdf should always build netcdf-4 (needed for example by exodusii.
trivial fixes of incorrect formatting in SNES linesearch routines
ISSetBlockSize_General: removed blockwise contiguity check.
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
config prefix: avoid ad-hoc path substitutions
config/install: no need to rename paths for installBinDir
rules: fix path in (evidently unimportant) uncrustify target
config pkgconfig: use ${prefix} in PETSc.pc and do not modify in install
fix gcov obj path
Improved polymorphism of interfaces for MatSetValuesBlocked()
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
...

show more ...

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out

Merge branch 'master' into knepley/feature-plex-functionals

* master: (984 commits)
netcdf: set zlib as optional dependency corretly [wrt --enable-netcdf-4] - otherwise netcdf configure errors out
fix gcov obj path
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Dev manual: remove duplicate entry
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
...

show more ...

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
config

Merge branch 'master' into knepley/feature-plex-elasticity-test

* master: (1553 commits)
-options_table was changed to options_view in 2014 but documentation was not updated to reflect it
configure: fix F2003 test
Plex test ex5: Removed "future" test, as it resulted in issues in the nightly tests.
Some minor typos in TS
Add ADIOS2.py which I forgot to git add in the past
Plex ex5: Disable test
Doc: Added note for interface change
KSPLSQRMonitorDefault fixed for quad precision
Tao: Added alternative output for chwirut2 test.
TS ex45,ex46: Removed overly refined tests for faster nightly tests.
KSP ex72: Fixed needlessly long-running PCTFS tests.
SNES ex56: Reduced test size to speed up nightly test suite.
KSPSolve_LSQR: don't compute unused norm of rhs
SNES ex13: Reduced problem sizes for nightly tests.
PetscOptionsDeprecated(): fix for NULL prefix
PetscOptionsDeprecated(): add option to print additional info
SNES ex12: Reduced sizes for BDDC tests.
PetscFileRetrieve(): Suppress output to STDERR when downloading a file.
MatMatMult: Fixed unused variable pN.
DMDestroy: Guard call to dm->ops->destroy * Similar guards are in place in many other methods (IS,Vec,Mat) and permit the DM to be destroyed even if DMSetType() was never called.
...

show more ...

Merged petsc/petsc into master

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComp

Merge branch 'master' into knepley/feature-plex-parallel-submesh

* master: (2931 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex

Merge branch 'master' into knepley/fix-plex-submesh-projection

* master: (425 commits)
remove N in docs for SNESQN
replaced test tolerance with PETSC_SQRT_MACHINE_EPSILON
fortran: PetscComplex type is missing from fortran
initialize variables so that static analyzer doesn't mistakenly think they are used uninitialized.
Move access of prefix until it is actually used
Remove DMDASplitComm2d(), used in one example that was not tested
Functions that do not return PetscErrorCode should not use PetscFunctionBegin/End paradgm
remove unneeded reassignment of same value
Missing CHKERRQ(); Mostly in Tao code
Remove clang static analyser warning about passing NULL variable to strncat()
missing newline in -ts_monitor_extreme
minor fixes for integer counters
Configure: Deal with '__func__' in C89 builds with newer Clang and GCC.
Jenkinsfile: Increased timeout for tests to 5 minutes.
3.9 changes: further clarify removal of -pc_factor_mat_solver_package
Options deprecations: add "PETSc" to inline warning
removing unused variable
MatShift support added to MATSUBMAT. Mimics MATSHELL functionality. Needed for matrix-free Hessians in TAO Newton-Line-Search methods.
Add -ts_monitor_extreme
Dev manual: add note on deprecating options database keys
...

Conflicts:
src/dm/impls/plex/examples/tests/ex4.c

show more ...

Remove clang static analyser warning about passing NULL variable to strncat()

Commit-type: testing-fix
Reported-by: clang static analyzer

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod

Merge branch 'master' into arcowie-rem/feature-error-logging

* master: (353 commits)
Configure: Pragmatic now requires Cxx11
fix compile warning
mpiuni: build somempifort.o after mpiuni.mod
Remove use of common block from MPIUNI code
use was in wrong location
Fortran line extends past 72 char
Moved the rest of the PETSc common block variables over to petscsys module
tests: fix breakage due to cd93b0e13c6da70ee1e038f55989cf888bc1d1c5
Need to use petscsys to get PETSC_COMM_SELF defined in example
Mat ex23 and ex40: fix errors reported from nightly tests
Put declaration on too lines because otherwise it generates an error for truncated line
Move PETSC_COMM_WORLD and PETSC_COMM_SELF from common blocks to petscsys module
tests: fix requires - and create out files for seqaijmkl tests
KSP ex72: nested dissection is likely to be different between machines
cmake: downgrade to version 3.9 - as newer versions require cxx11 compiler [which is not universal]. However stick with version 3.11 on opensolaris
Mat ex23: fix memory leaks
Bib: Some new refs
KSP examples: add missing casts to double in printf
updated GAMG KSP tests
PetscRound() should be PetscRoundReal() in __fp16
...

Conflicts:
include/petsclog.h
src/sys/logging/plog.c
src/sys/logging/utils/eventlog.c

show more ...

Merge branch 'master' into denera/lmvm-mat-and-pc

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to ne

Merge branch 'master' into knepley/fix-plex-project-tests

* master: (477 commits)
Added correct report number for PETSc Developers Guide
Update PETSc Developers Guide title and final pages to new ANL style
Hash: Quick documentation fix
PetscBinaryViewerRead -> PetscViewerBinaryRead
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
...

show more ...

Merge branch 'master' into knepley/feature-pc-patch

* master: (107 commits)
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for

Merge branch 'master' into knepley/feature-pc-patch

* master: (107 commits)
cast in GAMG_HASH so that it works for PetscInt32 near PETSC_INT_MAX without overflow to negative numbers
Add link for DrMemory which may serve as an alternative to valgrind on Windows
Finish Gail's copyedits for developers manual.
openmpi: fix namespace conflict [with static build on ppc64le]
two pages of Gail's edits to developers guide
Another chapter of Gail's copyedits for the developers guide
Gail's copyedits on two more chapters of the developers guide
Fix more %d to %D in GAMG code. Fix code style in GAMG code
DMPlexVTK: vertices is int! need to use %d instead of %D
TS ex18: update outputs (reported by nightly tests)
Use %D in error messages for GAMG hash; fix style issues with GAMG hash
config: Update petsc4py git commit
Fix bad plain extern declaration.
Add Gail's copyedits for the initial portion of the developers guide
Add missing common block to subroutine
fix mpiuni tests with xl compilers
Copy & paste the change on PetscSparseDensePlusDot
Fix a wrong macro
PetscInfo: Add missing errorchecking
Log: various fixes and cleanups
...

Conflicts:
src/dm/impls/plex/plex.c

show more ...

Merge branch 'barry/update-petscstrncpy'