Minor fixes
Add static to internal functions
Sys: Move PetscBT declaration to petscsystypes.hThe PetscBT header included an inline function that callsPetscViewer functions. I want to use PetscBT in the exposedlogging interface, but can't d
Sys: Move PetscBT declaration to petscsystypes.hThe PetscBT header included an inline function that callsPetscViewer functions. I want to use PetscBT in the exposedlogging interface, but can't do that with the current headerorganization.To be able to use PetscBT in this way, I move the declarationof PetscBT into petscsystypes.h (independent of the inlinefunctions like PetscBTLookup), and I move the PetscBTViewout of the header and into a new file,src/sys/classes/viewer/utils/btview.c.In moving PETSC_BITS_PER_BYTE (= CHAR_BIT) into petscsystypes.hI noticed that limits.h is included in petscsystypes.h so thereis no need to additionally include it in petscsys.h, so I removedthat include.
show more ...
... and apply it
Merge branch 'tisaac/feature-type-generic-petsc-valid-pointer' into 'main'Implement a type generic PetscValidPointerSee merge request petsc/petsc!6693
Merge remote-tracking branch 'origin/release'
Rename PetscValidPointer -> PetscAssertPointer
Deploy new PetscValidPointer, remove PetscValidXXXPointer
Fix -Wc++-compatinclude/petscerror.h:461:26: warning: enum conversion from ‘int’ to ‘PetscErrorCode’ in assignment is invalid in C++ [-Wc++-compat] 461 | ierr_petsc_call_q_ = __VA_ARGS__; \
Fix -Wc++-compatinclude/petscerror.h:461:26: warning: enum conversion from ‘int’ to ‘PetscErrorCode’ in assignment is invalid in C++ [-Wc++-compat] 461 | ierr_petsc_call_q_ = __VA_ARGS__; \ | ^src/sys/utils/mpishm.c:438:3: note: in expansion of macro ‘PetscCall’ 438 | PetscCall(hwloc_get_cpubind(ctrl->topology, ctrl->cpuset, HWLOC_CPUBIND_PROCESS)); | ^~~~~~~~~
Fix -Wextra-semi-stmt
Manual linter fixes: sys
Lint apply: sys
Merge branch 'barry/2023-06-15/add-fortran-file-viewer' into 'main'Allow one to attach a PETSCVIEWERASCII to a Fortran file unitSee merge request petsc/petsc!6607
HAVE_FORTRAN should be USE_FORTRAN_BINDINGS since it is about generating the Fortran bindings, not about if the Fortran compiler exists
Add PetscIsCloseAtTolScalar()
Add PetscStrcmpAny
build: fix -DPETSC_SKIP_COMPLEXReported-by: "Taller, Daniel" <taller1@llnl.gov>
Fix PetscCallMPI(MPI_Allreduce()) with PETSc types
Format the ftn-custom files with clang-format. Apparently no particular reason we did not format them initially
Fix typos
Use strerror() to print the cause of system errors to help users debug problems related to IOCommit-type: usabilityBranch-name: barry/2023-03-30/use-strerror-for-sys-errorsBranch-root: mainBran
Use strerror() to print the cause of system errors to help users debug problems related to IOCommit-type: usabilityBranch-name: barry/2023-03-30/use-strerror-for-sys-errorsBranch-root: mainBranch-purpose: Use strerror() to print the cause of system errors to help users debug problems related to IO
12345678910>>...31