Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc

Merge branch 'barry/2020-08-16/fix-source-formatting' into 'master'

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

See merge request petsc/petsc!3064

show more ...

Turn on checkbadSource test to generate an error when found; fix all source code that causes errors

Commit-type: portability-fix, testing-fix, style-fix, feature, maintainability
/spend 1.5h

Merge commit 'd47bf9aaf1e5266cc3f0ff499f934c85788965a9' into jed/fix-matcreatempibaij/maint

Obtain changed (v3.5) handling of MatMPIBAIJSetPreallocationCSR to match
documentation.

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page

Merge branch 'master' into knepley/fix-fe-default

* master: (297 commits)
Bib: Added refs and fixed one
Doc: Fixed formatting problems for MatCreateAIJ() manual page.
Add to PCSOR manual page information about convergence testing when using KSPRICHARDSON
SNES ex5: Restore old output since this breaks an example I have
Noted that some Cray XC systems will use 'aprun' instead of 'srun'. Thanks to Herr Doktor Hong Zhang for this suggestion.
Added example configure script for Cray XC40 with KNL processors (e.g., NERSC Cori).
Fix possible sprintf -Wformat-overflow
PetscMalloc2-7: fix -Wint-in-bool-context for GCC 7
SNES ex5: make boundary condition handling consistent for symmetry
SNES ex5: use L2 norm and *_monitor_short for output
SNES ex5: the L^2 norm scales with the l^2 norm over sqrt(N)
SNES ex5: refactor MMS capability to avoid extreme code duplication
Documentation fix: typo in PetscLogStageRegister manual page.
nodes -> vertices
rename DMNetworkGetComponentTypeOffset -> DMNetworkGetComponentKeyOffset
rename DMNetworkGetConnectedNodes() -> DMNetworkGetConnectedVertices()
Jacobians for adjoints for explicit methods and constant Jacobians never got initialized
fix complex build error
fix build failure with fortran interface
fix compile error with cdc753b64c658d532d7813e942002e67025667a6
...

Conflicts:
src/snes/examples/tutorials/ex13.c
src/snes/examples/tutorials/ex62.c
src/snes/examples/tutorials/ex69.c

show more ...

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output l

Merge branch 'master' into knepley/feature-rigid-bodies

* master: (204 commits)
windows fixes
revert this change as a relavent fix is already in origin/knepley/fix-ex-types
regenerate output log for snes_tutorials-ex62_fetidp_3d_tet that got corrupted in 188e10d6f1cffa866ec0197053a0e55fa4e7da41
fix opensolaris build error with --with-log=0 Undefined first referenced symbol in file PetscLogEventGetPerfInfo arch-opensolaris-misc/tests/src/dm/impls/plex/examples/tests/ex9.o
fix warnings on windows C:\cygwin64\home\petsc\PETSC~1.CLO\src\tao\examples\TUTORI~1\ex1.c(217): warning C4113: 'void (__cdecl *)()' differs in parameter lists from 'void (__cdecl *)(void)'
disable example with absoft (due to fixed/free form limit)
c89 fixes
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
Plex ex19: Remove unneeded code
Plex: Fix projection when we have a dmAux which is a domain boundary - If we are projecting on a lower dimension thing (effectiveHeight > 0), then we need to get the space and dual space on this subcell - The tabulation needs to be in the right dimension for both dm and dmAux
PetscFE: Added height subspaces to PetscFE - Added PetscFEGetHeightSubspace() - Added array in struct
PetscDualSpace: Small cleanup of parameter name
PetscSpace: Added height subspaces for PetscSpace - Added PetscSapceGetHeightSubspace() and member function - Added subspaces array
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix some minor style issues
Extend AMS/ADS to support high-order element.
...

show more ...

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warni

Merge branch 'master' into stefano_zampini/feature-gmsh-periodic

* master: (1016 commits)
metis: setself.downloaddirnames for change in 6d90219d8fa4f8b2fd242cc6ff9008358d87c26f
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
...

Conflicts:
include/petscdm.h
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/dm/impls/plex/plexhdf5.c

show more ...

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ m

Merge branch 'master' into knepley/feature-dm-bc-components

* master: (320 commits)
fix compile warning: /sandbox/petsc/petsc.clone/src/snes/examples/tests/ex2.c:250:8: warning: ‘pointsAllProcs’ may be used uninitialized in this function [-Wmaybe-uninitialized] ierr = DMInterpolationSetUp(interpolator, dm, pointsAllProcs);CHKERRQ(ierr);
migrate 'build requires: !mpiuni' to new format
migrate 'build requires: !complex' to new format
workarround 'division by zero' compiler warning on windows C:\cygwin64\home\petsc\PETSC~3.CLO\src\ts\examples\TUTORI~1\ex11.c(416): warning #39: division by zero if (uL->h < 0 || uR->h < 0) {for (i=0; i<1+dim; i++) flux[i] = 0./0.; return;} /* SETERRQ(PETSC_COMM_SELF,PETSC_ERR_ARG_OUTOFRANGE,"Reconstructed thickness is negative"); */
dos2unix to prevent warnings on opensolaris "/export/home/petsc/petsc.clone/src/ksp/ksp/examples/tests/ex53.c", line 6: warning: invalid white space character in directive
fix output file - corresponding to code changes in efd4aadf157bf1ba2d80c2be092fcf4247860003
disable test on windows
update log from opensolaris so that the diff is clean on linux aswell
update grep in sync with change in efd4aadf157bf1ba2d80c2be092fcf4247860003
Fixed code that did not correctly set current color for block insertion
Update output files that did not get fixed after previous merges
Change MPIUni to not immediately abort on operations it cannot perform, instead return error code
Add filter for example that can produce 1 different iteration count
Example add system calloc, bad formating of %d in print, commented out code
Always use (void) for functions that take no arguments, never ()
always need to caste PetscReal variables to (double) in print statements
updates to manual page for clarity
update help menu for MatRARt() -- MatRARt_mpiaij_mpiaij is supported now, but not efficient.
fix nightlybuild error with c1cbb1def3f8ddca04c3998b9c06618fd1ffef35 on arch-linux-IPL64 src/ksp/pc/examples/tests ex5_1
output has changed with e6d0a238963c2a97dd04845ea512b529992c7cdb so update the output file
...

show more ...

Merge remote-tracking branch 'origin/barry/consistent-formating-ascii-solver-viewers'

Make ASCII PC/KSP/SNES/TSView() code and output in a standard style

The code that prints the ASCII view for solvers was occasionally inconsistent:
1) TSView printed the type specific information aft

Make ASCII PC/KSP/SNES/TSView() code and output in a standard style

The code that prints the ASCII view for solvers was occasionally inconsistent:
1) TSView printed the type specific information after the general info while
all other solvers printed it before (right after the name of the type is printed)
2) KSPView consistently printed the name of the subtype on EACH line of the subtypes
output as did a few of the PC and SNES viewers. Since they are all printed indented
directly below the subtype name there is no reason to print this information on each line
3) TSView printed output about number of linear solvers and SNES even for explicit
methods, which is goofy.
4) a few other minor formatting and consistency issues where fix.

Commit-type: style-fix, feature
Time: 16 hours

show more ...

Merge branch 'scott/test-datafiles-fix' of https://bitbucket.org/petsc/petsc into scott/test-datafiles-fix

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
ini

Merge branch 'master' into knepley/feature-plex-sphere-mesh

* master: (2633 commits)
Bib: Added ref
SNES ex56: Update test output
add a citation to petsc.bib
Plex: Initialize variables
initialize ap as complained by the nightly tests
Plex ex3: Update to new point function API
initialize some variables as complained by nightly tests
SNES ex12: Mix misnaming Nf --> Nc
update tests
add tests
add MatView_SeqXAIJ_ASCII_structonly(); enable A->structure_only in MatSetValuesBlocked_SeqBAIJ
typo
fill-in some references
Bib: Fixed ref
Plex: Added PLY to file support
Plex: Adding PLY support
PetscDS: Turn off Fortran bindings for Constants
Plex tests: Updated to new point function API
SNES ex56: Moved tests to new format
DM: Allow field projection functions to take an array of scalars - This will allow us to pass in user data to kernels without void *, more efficiency than aux fields
...

Conflicts:
config/builder.py
include/petscdmplex.h
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/plexcreate.c
src/dm/impls/plex/plexgmsh.c
src/snes/examples/tutorials/ex63.c

show more ...

Merge branch 'master' into stefano_zampini/feature-fetidp-ex69

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]

Merge branch 'master' into knepley/feature-plex-boundary-values

* master: (487 commits)
Bib: More refs
Fixed errors in the manuals and ts_glee source code doc
fix bug to enable '-xxx_via [alg]' to showup in '-help' Reported-by: Mark Adams <mfadams@lbl.gov>
Plex: Remove dead code
TS tutorials ex11: remove unused functions
TSAdapt: Set TSADAPTNONE as default adapt type
DMPlex: missed viewer change in synchronized output
Revert "Merge branch 'hzhang/ts-ex9busdmnetwork'"
TSAdapt: Update changes/dev.html
TSAdapt: Set default type for TSGLEE
TS tutorials ex11: make work with complex scalars
Bib: Added ref
TS ex18: Fix initializer
TS ex11: Fix M_PI
Plex ex1f90: FUCK FORTRAN
f2cblaslapack: remove duplicate xerbla.o and xerbla_array.o from lapack [they are already in blas]
TSAdapt: Refactor handling of default adapt type
TSAdapt: Update changes/dev.html
TSAdapt: Update manual
TSAdapt: Refactor interface and implementations
...

show more ...

Merged in dalcinl/ts-adapt-default-type (pull request #674)

TSAdapt: Refactor handling of default adapt type

Approved-by: BarryFSmith <bsmith@mcs.anl.gov>

TSAdapt: Refactor handling of default adapt type

* Let TS subtypes state its preference for adaptivity
* Methods without embedded error estimators prefer TSADAPTNONE
* If not set, use TS_EXACTFINALT

TSAdapt: Refactor handling of default adapt type

* Let TS subtypes state its preference for adaptivity
* Methods without embedded error estimators prefer TSADAPTNONE
* If not set, use TS_EXACTFINALTIME_MATCHSTEP when using adaptivity

* Remove command line option -ts_theta_adapt
* Use `-ts_adapt_type basic` to turn on adaptivity in TSTHETA

* Remove command line option -ts_alpha_adapt
* Remove routine TSAlphaUseAdapt() and TSAlpha2UseAdapt()
* Use `-ts_adapt_type basic` to turn on adaptivity in TSALPHA/TSALPHA2

show more ...

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-torus

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-torus

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages
update to latest hypre tag on github
fix 'inf' vs 'Inf' diff wrt vec_vec_utils_tagger_tutorials-ex1_8,9,18,19
MatSetOption(mat,MAT_IGNORE_ZERO_ENTRIES,PETSC_TRUE) no longer applies to zero values set or added to the matrix diagonal, they are now not ignored and are included in the matrix nonzero structure. This is useful for Jacobians passed to TS.
replace use/mention of depreciated -log_summary in many places
add extchem.py which was written years ago but never put in the distribution (hence it is broken).
petsc4py: update to snapshot with MatGetSubMatrices -> MatCreateSubMatrices etc API changes
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
PetscCMPLX: assume type punning is safe
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
...

Conflicts:
src/dm/impls/plex/examples/tests/ex1.c
src/dm/impls/plex/examples/tests/ex12.c

show more ...

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-tests-new

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stag

Merge branch 'knepley/fix-plex-example-logging' into knepley/feature-plex-tests-new

* knepley/fix-plex-example-logging: (151 commits)
Plex ex12: Added logging stages
Plex ex1: Added logging stages
update to latest hypre tag on github
fix 'inf' vs 'Inf' diff wrt vec_vec_utils_tagger_tutorials-ex1_8,9,18,19
MatSetOption(mat,MAT_IGNORE_ZERO_ENTRIES,PETSC_TRUE) no longer applies to zero values set or added to the matrix diagonal, they are now not ignored and are included in the matrix nonzero structure. This is useful for Jacobians passed to TS.
replace use/mention of depreciated -log_summary in many places
add extchem.py which was written years ago but never put in the distribution (hence it is broken).
petsc4py: update to snapshot with MatGetSubMatrices -> MatCreateSubMatrices etc API changes
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
PetscCMPLX: assume type punning is safe
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
...

Conflicts:
src/dm/impls/plex/examples/tests/ex12.c

show more ...

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes

Merge branch 'master' into knepley/feature-plex-pragmatic-parallel

* master: (1379 commits)
Minor fixes for tchem examples due to changes in PETSc infrastructure
update webpage about API changes
add help menu for MatCreateSubMatricesMPI()
rename struct Mat_SubMat -> Mat_SubSppt
add a little information to the manual about using tchem
rename MatCreateSubMatrixComposite -> MatCreateSubMatrixVirtual; Mat_SubMatrix -> Mat_SubVirtual
need to protect the \ passed on the makefile on my Mac
Bib: Updated ref
update src/mat/examples/tests/output/ex23_#.out
rename MatGetSubMat -> MatCreateSubMat
Mark MatCreateMPIAIJWithSplitArrays() and MatMPIAIJSetPreallocationCSR() with MAT_NO_OFF_PROC_ENTRIES
superlu: libray is installed in PREFIX/lib64 - fix this to use PREFIX/lib
backport fixes cc105cc3 2b35c90a - required for 3bf428d - that was backported from master - 80c96bb
'echo -n' fails on opensolaris/osx - so avoid using it.
fix diffs in nightlybuilds due to options in ~/.petscrc
add Kelley03 to src/docs/tex/petsc.bib
build: determine moudles, mpi.h used during buildtime and print in 'info'
fix analyzer warnings
fix build failure on opensolaris - where -lm from flibs is removed due to -lm in cxxlibs. But then - only flib gets used for some configure tests [blaslapack, parms]
config: prefer __restrict over C99 restrict keyword
...

show more ...

Merge branch 'maint'

Merged in barry/ts-error-explicit-method-ifunction (pull request #636)

If user provides TSSetIFunction() the TSSolve() should error out if explicit method is used

If user provides TSSetIFunction() the TSSolve() should error out if explicit method is used

Otherwise the user will get different (wrong) answers than they expect.

Funded-by: IMEX applied mathemati

If user provides TSSetIFunction() the TSSolve() should error out if explicit method is used

Otherwise the user will get different (wrong) answers than they expect.

Funded-by: IMEX applied mathematics
Time: .2 hours
Reported-by: Ed Bueler <elbueler@alaska.edu>

show more ...

Merge branch 'barry/remove-funct'

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-t

Remove the use and definition of __FUNCT__ throughout the code

Since all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETSc
Time: 1.5 hours
Thanks-to: Andreas Mang <andreas@ices.utexas.edu>

show more ...

Merge branch 'master' into stefano_zampini/feature-pcbddc-saddlepoint

Conflicts:
src/ksp/pc/impls/bddc/bddc.c
src/ksp/pc/impls/bddc/bddcgraph.c
src/ksp/pc/impls/bddc/bddcprivate.c

Merged in dalcinl/fix-tsrollback (pull request #456)

TS: Refactor TSStep() and TSRollBack()