Merge branch 'barry/2026-01-13/ftn-generation-for-context-functions' into 'main'

Fortran generation of interface definitions for functions that take and return context variables (void *ctx and PetC

Merge branch 'barry/2026-01-13/ftn-generation-for-context-functions' into 'main'

Fortran generation of interface definitions for functions that take and return context variables (void *ctx and PetCtx ctx)

See merge request petsc/petsc!8956

show more ...

Add automatic generated fortran support for setting and returning contexts

Major cleanup of the code for setting and returning application (previously called user) contexts
- PetscCtx ctx is now t

Add automatic generated fortran support for setting and returning contexts

Major cleanup of the code for setting and returning application (previously called user) contexts
- PetscCtx ctx is now the standard for passing in contexts
- PetscCtxRt ctx is the standard for passing out contexts, including context destroy routines based on PetscCtxDestroyFn

Both of these are typedef to void*

Also removed most use of user and userctx for context arguments now consistently named ctx

Improved documentation on PetscCtx and PetscCtxRt and on how to use contexts (including getting them) from Fortran

show more ...

Merge branch 'jolivet/clang-format-19' into 'main'

clang-format-19

See merge request petsc/petsc!7644

CI: update checkclangformat to use clang-format-19.1.0

Merge branch 'jolivet/clang-format-18' into 'main'

clang-format version 18

See merge request petsc/petsc!6902

checkbadSource: rules for PetscFunctionBegin and derivatives

Merge branch 'barry/2024-02-06/fix-tao-view-solution' into 'main'

Some Tao monitor options are incorrectly called viewers, yikes and more yikes

See merge request petsc/petsc!7266

Some Tao monitor options are incorrectly called viewers, yikes and more yikes

Correct ``-tao_view_gradient``, ``-tao_view_ls_residual``, ``-tao_view_solution``, and ``-tao_view_stepdirection`

Merge branch 'barry/2024-01-19/typedef-snes-functions' into 'main'

add typedef for functions passed to SNESSetFunction() etc to match approach in TS

See merge request petsc/petsc!7206

Change the use of the _Fn suffix to indicate a typedef of a function to just Fn

As determined on a vote on GitLab

Convert TS typedef functions to new style ending with _Fn

Commit-type: housekeeping, maintainability

Implement setting two distinct post-event steps

The two post-event steps are managed by:
TSSetPostEventStep(), -ts_event_post_event_step,
TSSetPostEventSecondStep(), -ts_event_post_event_second_step

Implement setting two distinct post-event steps

The two post-event steps are managed by:
TSSetPostEventStep(), -ts_event_post_event_step,
TSSetPostEventSecondStep(), -ts_event_post_event_second_step.

(The latter function and option are replacement for the original PETSc
TSSetPostEventIntervalStep(), -ts_event_post_eventinterval_step,
with some change of overall behaviour of 1st + 2nd steps).

Also, reduce the number of tests ~ 4 times.

show more ...

TSEvent: refactor and fix bugs, add TSSetPostEventStep()

Refactor the core algorithm for resolution of events: TSEventHandler()
and the helper functions, fixing the existing bugs.

Chang

TSEvent: refactor and fix bugs, add TSSetPostEventStep()

Refactor the core algorithm for resolution of events: TSEventHandler()
and the helper functions, fixing the existing bugs.

Change event indicator functions from PetscScalar to PetscReal.
Change the API of TSSetEventHandler(): in the user `indicator()` callback,
the 'fvalue' argument type changed from PetscScalar[] to PetscReal[].

Add TSSetPostEventStep(), deprecate TSSetPostEventIntervalStep().
Deprecate option -ts_event_post_eventinterval_step.

Fix bugs in interaction of TSEvent with tspan.
Add six new test examples.

Below are the examples of bugs fixed by this patch.
The source codes (ex3.c, ex3span.c, ex4.c, ex5.c) can be found
in src/ts/event/tests. To run them with the older Petsc versions,
one would need to comment out "#define NEW_VERSION".
Behaviour for three library versions is reported below:
* ORIG: current Petsc version, before the proposed patch.
* 6688: independently of the proposed patch, Merge Request 6688 was
developed, which fixed some bugs with zero-crossing directions.
* NEW : the proposed patch.

./ex3 -ts_monitor -ts_event_monitor -ts_view -ts_type beuler \
-ts_adapt_type basic -flg -V 1e9 -ts_adapt_dt_min 1e-6 -change5 1 -dir 1
* ORIG: fails to resolve 5 out of 6 events, and resolves 23 incorrect events.
* 6688: fails to exit the TSEvent iteration via the step size (bracket size)
criterion.
* NEW : ok, resolves all 6 events.

./ex4 -ts_adapt_type basic -ts_type rk -ts_dt 0.25 -ts_event_tol 1e-8 \
-dir 0 -ts_adapt_dt_min 1e-10 -ts_view -ts_monitor -ts_event_monitor
* ORIG: only reaches t = 0.0300236 after 10000 TS steps.
* 6688: only reaches t = 0.0300236 after 10000 TS steps.
* NEW : ok, reaches the final time t = 4.0 after 96 TS steps, resolving
all 16 events.

./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \
-ts_view -ts_dt 0.25 -flg -dir 0
* ORIG: only reaches t = 4.0 after 10000 TS steps, erroneously reports
event at t = 4.0 around 5000 times.
* 6688: only reaches t = 4.0 after 10000 TS steps.
* NEW : ok, reaches the final time t = 10.0 after 99 TS steps, resolving
all 34 events.

./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \
-ts_view -ts_dt 0.25 -flg -dir 1
* ORIG: fails, starts taking negative time steps, no events are correctly
resolved.
* 6688: ok, but slower: 90 TS steps to resolve all 17 events.
* NEW : ok, and faster: 48 TS steps to resolve all 17 events.

./ex5 -ts_monitor -ts_event_monitor -ts_type rk -ts_adapt_type basic \
-ts_view -ts_dt 0.25 -flg -dir -1
* ORIG: fails, starts taking 'nan' time steps.
* 6688: mostly fails, only reaches t = 4.99993 after 10000 TS steps.
* NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving
all 17 events.

The same run in parallel:
mpirun -n 2 ./ex5 -ts_monitor -ts_event_monitor -ts_type rk \
-ts_adapt_type basic -ts_view -ts_dt 0.25 -flg -dir -1
* ORIG: fails, starts taking negative time steps, exits with runtime error.
* 6688: mostly fails, only reaches t = 3, besides, the parallel run is not
consistent with the serial run (see above).
* NEW : ok, reaches the final time t = 10.0 after 74 TS steps, resolving
all 17 events.

./ex3span -ts_monitor -ts_event_monitor
* ORIG: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01,
5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01.
* 6688: (confused by events) misses tspan points: 4.02, 4.21, 4.98, 5.01,
5.21, 5.98, 6, 6.01, 6.02, 6.21, 6.99, 7.21, 8.01, 8.21, 9.01.
* NEW : ok.

./ex3span -ts_monitor -ts_event_monitor -ts_event_post_event_step 0.5
* ORIG: misses the majority of tspan points (except 0.01 and 0.21),
and also resolves the last event location at wrong time t = 9.21.
* 6688: misses the majority of tspan points (except 0.01 and 0.21),
and also resolves the last event location at wrong time t = 9.21.
* NEW : ok.

show more ...

Merge branch 'jolivet/rm-first-empty-line' into 'main'

Remove first and last empty lines

See merge request petsc/petsc!6892

Remove first and last empty lines

Merge branch 'jacobf/2022-12-10/petscerrorcode-nodiscard' into 'main'

Feature: Non-discardable PetscErrorCode

See merge request petsc/petsc!5923

Make PetscErrorCode a non-discardable enum

Merge branch 'jacobf/2023-01-13/modernize-cleanup-petscsys-h' into 'main'

Modernize and clean up petscsys.h

See merge request petsc/petsc!5976

Modernize and clean up petscsys.h

- Deprecate PETSC_NULL.
- Switch from preprocessor defines to anonymous enums for constant expressions.
- Surround macro arguments in ().
- Remove redundant casts.

Modernize and clean up petscsys.h

- Deprecate PETSC_NULL.
- Switch from preprocessor defines to anonymous enums for constant expressions.
- Surround macro arguments in ().
- Remove redundant casts.
- Clean up overly complex preprocessor defines in various PetscMem*() functions.

show more ...

Merge branch 'jacobf/2022-09-21/2-bike-2-shed' into 'main'

Feature: Bicycle Storage Facility 2

See merge request petsc/petsc!5661

source code format changes due to .clang-format changes

Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners

See merge request petsc/petsc!5557

Remove braces from one-liners

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format