place all the include statements at the topRepeated inclusion in multiple location, e.g. at the start of amodule or function is not needed. This becomes clear if all includes areoutside of the ac
place all the include statements at the topRepeated inclusion in multiple location, e.g. at the start of amodule or function is not needed. This becomes clear if all includes areoutside of the actual Fortran code.Added regex to check that with the help of @sbalay
show more ...
checkbadSource: enforce proper style in makefiles
Run fprettify
missing "s" for isascii and issundials
Remove explicitly listed empty files and switch to output/empty.out
Fix wrong case for PETSc
Brain dead fixes for useless casts
CI: enable compilation of examples in some stage-1 jobs
Fix missing initializer for member errors [-Werror=missing-field-initializers]
Use NULL or nullptr instead of casted 0
Fix MPIU_* routines to always return MPI error codes and thus be usable with PetscCallMPI()Introduce MPIU_Count to be used when MPI_Count is not available
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in th
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in the CI
Merge remote-tracking branch 'origin/release'
Minor fixes to AO manual pages
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGERPass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXXThe compiler will now automatically prevent you from using the wrong argument type for the first three bullets aboveThis will also require an update sowing with the new sowing branch this MR is using.
All constructors should do PetscAssertPointer on output objectReported-by: Blaise BourdinConstructors should not initialize the output to NULL upon entry, serves no purposeFix some formatting i
All constructors should do PetscAssertPointer on output objectReported-by: Blaise BourdinConstructors should not initialize the output to NULL upon entry, serves no purposeFix some formatting in constructors
Update to sowing version that supports PetscViewer and PetscObjectRemove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowingAlso handles the passing of null
Update to sowing version that supports PetscViewer and PetscObjectRemove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowingAlso handles the passing of null objects correctly
Merge branch 'barry/2024-04-13/fix-sowing-strings' into 'main'Update PETSc to use sowing bfort that handles string arguments and PETSC_NULL_INTSee merge request petsc/petsc!7480
docs fixes for release
Update source code removing all unneeded /*@C and associated manual stubs and interfaces
Docs: fix missing back ticks.
Remove carriage return in Petsc(Assert|Check)()git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'Suggested-by: Stefan
Remove carriage return in Petsc(Assert|Check)()git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'Suggested-by: Stefano Zampini
Remove multiple parentheses and extra semicolongit grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g
Remove multiple parentheses and extra semicolongit grep -l -E "\(\([a-zA-Z0-9_]+\)\(\*[a-zA-Z0-9_]+\)[, )]" | xargs sed -r -i'' 's#\(\(([a-zA-Z0-9_]+)\)\(\*([a-zA-Z0-9_]+)\)([, )])#\(\(\1\)\*\2\3#g'git grep -l -E "Petsc(.)*\(\(\*[a-zA-Z0-9_]*\)," | xargs sed -r -i'' 's#Petsc([a-zA-Z0-9_]*)\(\(\*([a-zA-Z0-9_]*)\), #Petsc\1(*\2, #g'git grep -l -E "([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)" | xargs sed -r -i'' 's#([\!\&\~\*\(]|\)\)|\([^,\*\(]+\**\))\(([a-zA-Z0-9_]+((\.|->)[a-zA-Z0-9_]+|\[[a-zA-Z0-9_ \%\+\*\-]+\])+)\)#\1\2#g'
Fix words appearing twice in a row for no good reason
Use PetscTryTypeMethod when possible
123456789