Merge branch 'jolivet/fix-style-one-liners' into 'main'

Remove braces from one-liners

See merge request petsc/petsc!5557

Remove braces from one-liners

Merge branch 'barry/2022-08-21/clang-format-source' into 'main'

format repository with clang-format

See merge request petsc/petsc!5541

clang-format: convert PETSc sources to comply with clang-format

Merge branch 'barry/2022-06-28/add-petsccallmethod' into 'main'

Introduce PetscTryTypeMethod and PetscUseTypeMethod to replace ad hoc use of (*obj->ops->method) in source

See merge request petsc/

Merge branch 'barry/2022-06-28/add-petsccallmethod' into 'main'

Introduce PetscTryTypeMethod and PetscUseTypeMethod to replace ad hoc use of (*obj->ops->method) in source

See merge request petsc/petsc!5376

show more ...

Convert setfromoptions methods over to PetscTryTypeMethod() approach

Flipped the order of the arguments for the function pointers (*setfromoptions)(PetscOptionItem*,obj); and friends to make them co

Convert setfromoptions methods over to PetscTryTypeMethod() approach

Flipped the order of the arguments for the function pointers (*setfromoptions)(PetscOptionItem*,obj); and friends to make them consistent with PetscTryTypeMethod() and all the other methods

Commit-type: refactorization
/spend 4h

show more ...

Merge branch 'barry/2022-07-20/fix-using-seterrq' into 'main'

Remove outdated use of if() SETERRQ

See merge request petsc/petsc!5457

Remove outdated use of if() SETERRQ

Commit-type: style
/spend 20m
Reported-by: clang-format

Merge branch 'psanan/docs-seealso-formatting' into 'main'

Docs: Fix man page .seealso entries missing spaces after commas

Closes #1176

See merge request petsc/petsc!5202

Docs: Fix man page .seealso entries missing spaces after commas

```python

import os
import re
import fileinput

START_PATTERN = re.compile(r"^( *\.seealso:? )(.*$)")
FIX_PATTERN = re.compile(r",([^

Docs: Fix man page .seealso entries missing spaces after commas

```python

import os
import re
import fileinput

START_PATTERN = re.compile(r"^( *\.seealso:? )(.*$)")
FIX_PATTERN = re.compile(r",([^ $\n])")

def _fix_comma(matchobj):
return "`, `%s" % matchobj.group(1)

def process_file(filename_full):
""" Find/fix commas w/o trailing spaces or newlines in .seealso blocks """
with fileinput.FileInput(filename_full, inplace=True) as the_file:
in_block = False
for line in the_file:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(START_PATTERN, line) # not stripped line
if match:
in_block = True
if in_block:
if re.search(FIX_PATTERN, line):
line_fixed = re.sub(FIX_PATTERN, _fix_comma, line)
print(line_fixed, end="") # prints to file
else:
print(line, end="") # prints to file
else:
print(line, end="") # prints to file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process files in local tree(s) """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Merge branch 'psanan/docs-sphinx-man-pages' into 'main'

Integrate Man Pages into Sphinx Docs

Closes #1132 and #1015

See merge request petsc/petsc!4989

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (wor

Docs: bulk add backticks to .seealso man page fields

```python
import os
import re
import fileinput

def _process_word(word):
comma = "," if word.endswith(",") else ""
return "`%s`%s" % (word.rstrip(","), comma)

def _process_stripped_line(line):
return " ".join(map(_process_word, line.split()))

start_pattern = re.compile(r"^( *\.seealso:? )(.*$)")

def process_file(filename_full):
with fileinput.FileInput(filename_full, inplace=True) as f:
in_block = False
for line in f:
line_stripped = line.strip()
# end ".seealso blocks" on a blank line or C-style comment close
line_modified = None
if not line_stripped:
in_block = False
elif line_stripped.endswith("*/"):
in_block = False
else:
match = re.match(start_pattern,
line) # not stripped line
if match:
indent = " " * len(match.group(1))
in_block = True
line_modified = match.group(
1) + _process_stripped_line(
match.group(2).strip())
elif in_block:
line_modified = indent + _process_stripped_line(
line_stripped)
if line_modified:
print(line_modified) # prints to the file
else:
print(line, end="") # prints to the file

BASE_DIRS = ["src", "include"]
EXT = [".c", ".cxx", ".cpp", ".cu", ".h", ".hpp", ".hxx"]
EXCLUDE_DIRS = ["tests", "tutorials", "ftn-auto", "ftn-custom", "benchmarks"]

def main():
""" Process everything """
for base in BASE_DIRS:
for root, dirs, files in os.walk(base):
for filename in files:
if os.path.splitext(filename)[1] in EXT:
filename_full = os.path.join(root, filename)
print("FILE ---", filename_full)
process_file(filename_full)
for exclude_dir in EXCLUDE_DIRS:
if exclude_dir in dirs:
dirs.remove(exclude_dir)

if __name__ == "__main__":
main()
```

show more ...

Merge remote-tracking branch 'origin/release'

Merge branch 'jczhang/fix-vecscat-multi-leaves' into 'release'

SF: fix a bug. When duplicating VecScatter, we missed to dup the allow_multi_leaves flag

See merge request petsc/petsc!5175

SF: fix a bug. When duplicating VecScatter, we missed to dup the allow_multi_leaves flag

Reported-by: "Hammond, Glenn E" <glenn.hammond@pnnl.gov>

Merge branch 'barry/2022-04-17/rm-petsccheckfalse-vec' into 'main'

Remove PetscCheckFalse() from the vec directory

See merge request petsc/petsc!5133

Merge branch 'barry/2022-04-10/nvhpc-warnings' into 'main'

Prevent warning of unsigned int change in cast of char to unsigned char for NVHPC compiler

See merge request petsc/petsc!5106

Cast enum to int when comparing for >= 0 because NVHPC compiler treats basic enums as
unsighed and thus produces warnings about pointless comparison of unsigned int to zero

/spend 45m

Remove PetscCheckFalse() from the vec directory

Commit-type: style-fix
/spend 35m

Merge branch 'barry/2022-04-01/fix-petsc-options-begin-end/release' into 'main'

Remove bogus error returns from Begin/End() macros

See merge request petsc/petsc!5069

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as Mat

Cleanup of introduction of PetscCall()

* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()

* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()

* fix many lingering ierr = XXX that arose from multiline function calls

* sync slepc/hpddm - to use snapshots with the same changes

Commit-type: error-checking, style-fix
/spend 8h

show more ...

Merge branch 'jolivet/feature-less-checkfalse' into 'main'

Dividing by four the number of PetscCheckFalse()

See merge request petsc/petsc!5072

Remove some PetscCheckFalse()

Merge branch 'barry/2022-03-30/fix-mpiu_allreduce' into 'main'

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

See merge request petsc/petsc!5052

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-

Fix mpiu_allreduce to always return PetscErrorCodes, never MPI error codes

Both for debug and optimized builds

Also removes shadow declaration errors from use of mpiu_allreduce

Commit-type: error-checking
Reported-by: Lisandro Dalcin <dalcinl@gmail.com>

show more ...