Difference between revisions of "PHASTA/Wish List"
From PHASTA Wiki
Line 7: | Line 7: | ||
*Write interface to allow Phasta to read and write both Sync IO and Posix | *Write interface to allow Phasta to read and write both Sync IO and Posix | ||
*Fix bug in Sync IO to allow serial IO. | *Fix bug in Sync IO to allow serial IO. | ||
− | *Modify common.h (and the rest of the code) to allow implicit none. | + | *Modify <code>common.h</code> (and the rest of the code) to allow <code>implicit none</code>. |
*Convert all Fortran to a separate language (such as C or Julia) | *Convert all Fortran to a separate language (such as C or Julia) | ||
*Cross Platform (Hey, I can dream) | *Cross Platform (Hey, I can dream) | ||
Line 27: | Line 27: | ||
** See <code>jrwrigh/volumetric-stg-DoxygenTest</code> branch for example. Open <code>docs/index.html</code> in a browser to see resulting code. | ** See <code>jrwrigh/volumetric-stg-DoxygenTest</code> branch for example. Open <code>docs/index.html</code> in a browser to see resulting code. | ||
** The compressible and incompressible libraries will (probably) need to be documented as [https://www.doxygen.nl/manual/external.html "external libraries"] (config options [https://www.doxygen.nl/manual/config.html#config_external here]) | ** The compressible and incompressible libraries will (probably) need to be documented as [https://www.doxygen.nl/manual/external.html "external libraries"] (config options [https://www.doxygen.nl/manual/config.html#config_external here]) | ||
+ | *Review code for use of <code>nshl</code> vs <code>nenl</code>. | ||
+ | **Things having to do with nodes (<code>xl</code>) or linear fields (<code>dwallocalized</code>) are nodal fields and are size <code>nenl</code>. | ||
+ | ** Other fields that would be interpolated by all of the shape functions on an element (e.g., <code>yl</code>, <code>acl</code>, ) or residuals (<code>rl</code>) are of size <code>nshl</code>. | ||
+ | **Similarly, at the global level nodal/linear fields are sized <code>numnp</code> while things that could be higher order are <code>nshg</code>. | ||
Revision as of 11:06, 17 August 2020
This page is intended to be a log of useful features to add to various tools such as Phasta and NSpre. Odds are that no one will ever actually implement anything listed on this page, but if you somehow find yourself with a little extra time, it's always here.
Phasta
- Standardize the Sync IO library to work as is across Phasta and Paraview.
- Get rid of the need to know a priori how many fields will need to be written when using Sync IO
- Write interface to allow Phasta to read and write both Sync IO and Posix
- Fix bug in Sync IO to allow serial IO.
- Modify
common.h
(and the rest of the code) to allowimplicit none
. - Convert all Fortran to a separate language (such as C or Julia)
- Cross Platform (Hey, I can dream)
- Add testing (unit and regression)
- See FortranTestGenerator to automatically generate unit tests from the code (and it's accompanying IEEE paper).
- Also possibly build up using libFRUIT for unit tests
- Convert all code to use
blk%_
instead of it's equivalents (npro
, etc.) - Split generation of
d2wall
from SA code into a separate module - Make timestep increaseable through
rerun-check
- Replace iterative do loop with while loop
- Implement style guide/formatter
- Convert to free-form Fortran
- Documentation via doxygen
- See
jrwrigh/volumetric-stg-DoxygenTest
branch for example. Opendocs/index.html
in a browser to see resulting code. - The compressible and incompressible libraries will (probably) need to be documented as "external libraries" (config options here)
- See
- Review code for use of
nshl
vsnenl
.- Things having to do with nodes (
xl
) or linear fields (dwallocalized
) are nodal fields and are sizenenl
. - Other fields that would be interpolated by all of the shape functions on an element (e.g.,
yl
,acl
, ) or residuals (rl
) are of sizenshl
. - Similarly, at the global level nodal/linear fields are sized
numnp
while things that could be higher order arenshg
.
- Things having to do with nodes (
NSpre
- Error checking to make sure that the size of the mesh contained in geom.sms is equal to the size of the mesh associated with restart.*.0.
- Ability to interpolate directly from a partitioned mesh.