fluids: Cleanup unused struct members

Many of these are set, but never actually used.

fluids: Remove coordinates from IFunction_NodalSgs

- Stragler from previous PR

deleted all the unused coordinate references that were throwing warnings

style cleanup

Potential energy removed from all state helpers so no more x (or dx) dependence for them. Interior integrals still need x for IDL but boundary elements don't so removed. This touches lots of qfuncti

Potential energy removed from all state helpers so no more x (or dx) dependence for them. Interior integrals still need x for IDL but boundary elements don't so removed. This touches lots of qfunctions that make state calls and a few problems as well

show more ...

interface - rename CEED_BASIS_COLLOCATED to CEED_BASIS_NONE

fluids: Add DMPlexCeedElemRestriction*Create

Replaces CreateRestrictionFromPlex and GetRestrictionForDomain

fluids: Correct PetscFunction{Return,BeginUser} placement

- Respect the PETSc standard for style (https://petsc.org/release/developers/style/#coding-conventions-and-style)

fluids: Remove misc comments

- Either by inaccuracy of unnecessary

fluids: Make function names in consistent format

- Mainly remove `_` and acronymns with more than 2 letters should
respect CamelCase (ie. `StgFunction` not `STGFunction`)

fluids: Add DMSetupByOrder_* helper function

Merge pull request #1298 from CEED/jrwrigh/taylor-green-vortex

Fluids: Add Taylor-Green vortex problem

fluids: Add Taylor-Green vortex problem

fluids: Calculate dXdx for strong BCs directly

ie. don't use q_data_sur

fluids: Use enum for mesh transformation flag

fluids: Remove old, unused STG method (non-Ceed)

- Remove the old method for STG that uses DMAddBoundary. Completely
superseded by Ceed implementation

fluids: Specify streamwise element length for STG

- Generally for non-DMPlex box meshes, where we can't query number of
box faces.

fluids: Explicit flag for blasius mesh modification

- So that blasius example can run using external meshes without any
attempt to modify them

fluids: Refactor gravity option

- Use `-gravity` instead of `-g`
- Enforce that the input should be a length 3 vector
- Update documentation

Misc: Also update documented default value for `mu`.

fix(fluids): Reset dim before reference_velocity option

If `-g` is not given, then
`PetscOptionsRealArray(..., "-g", ...)`
will set `dim` to zero. This then causes
`PetscOptionsScalarArray(..., "-re

fix(fluids): Reset dim before reference_velocity option

If `-g` is not given, then
`PetscOptionsRealArray(..., "-g", ...)`
will set `dim` to zero. This then causes
`PetscOptionsScalarArray(..., "-reference_velocity", ...)`
to not read any values.

show more ...

fluids: Add PetscCallCeed

fluids: Add user argument to problem print functions

PetscFE determines basis for examples/fluids/navierstokes (#1264)

* breaking lots of DL stuff to test PetscFE

* fixed missing header

* fluids: Remove unused `Involute` function

* fluids: Se

PetscFE determines basis for examples/fluids/navierstokes (#1264)

* breaking lots of DL stuff to test PetscFE

* fixed missing header

* fluids: Remove unused `Involute` function

* fluids: Set quadrature points for PetscFE

* fluids: Fix GetRestrictionForDomain, Use CreateBasisFromPlex

* fluids: Remove Q_sur arg from SetupStrongBC_Ceed

* fluids: Remove extra SetClosurePermutationTensor

* fluids: Correct quadrature order to auxillary DMs

- Should factor in q_extra

* fluids: Fix parent Restriction creation for spanstats

* fluids: Correct qdata creation for strong bcs

* fluids: Set tensor closer only for tensor-product elements

Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

* fluids: Make shocktube test less brittle

- Small, insignificant changes to the coordinate locations make a
dramatic difference to the initial condition
- For the test case, there is a node right at the midpoint of the
domain. Adding the epsilon fudge factor makes the if statement more
stable

* fluids: Fix SGS test

- Change the test so that it passes on all hardware. It's a very
sentitive test and the changes to the basis creation changed the
initial conditions *just* enough to make the test not happy. Should
really try and make this more robust at some point...

* fluids: Address misc PR comments

* fluids: Remove quad_mode arg from CreateBasisFromPlex

---------

Co-authored-by: James Wright <james@jameswright.xyz>
Co-authored-by: Jeremy L Thompson <jeremy@jeremylt.org>

show more ...

fluids - drop unneeded calls to CeedOperatorSetNumQuadraturePoints

fluids: Remove problem->bc function pointers

- Not needed, as essential boundary conditions go through
`DMPlexInsertBoundaryValues_NS` or
`DMPlexInsertBoundaryValues_StrongBC`