fluids: Use enum for turbulence statistics components

- Also change the filenames to be more specific
- Define num_comp_stats via TURB_NUM_COMPONENTS

Co-authored-by: Jed Brown <jed@jedbrown.org>

fluids: Change turb_spanstats CL option names

- Options controlling the actual TSMonitor are under
`ts_monitor_turbulence_spanstats_*`
- `stats_enable` removed in favor of
`ts_monitor_turbulence

fluids: Change turb_spanstats CL option names

- Options controlling the actual TSMonitor are under
`ts_monitor_turbulence_spanstats_*`
- `stats_enable` removed in favor of
`ts_monitor_turbulence_spanstats_viewer` being the statistics switch
- Related objects excluding the viewer (such as the dm and ksp) get the
prefix `turbulence_spanstats`
- Change the `stats_test` related functions and variables to use the
`mms` nomenclature, since they're method of manufactured solutions.

show more ...

fluids: Check result of statistics testing

fluids: Add stats collection QF

fluids: Add solution time to newtonian context

fluids: Mass QF for different number of components

- In order to avoid "Function defined, but not used" warnings, the
ReturnMassQFunction is used to return the correctly sized mass QF

Fix -Wextra-semi -Wmissing-field-initializers

examples/fluids: Riemann outflow using pressure and temperature

* This allows stable sustained and transient recirculation.

* short-wake domain recirculation behind cylinder has sustained
rec

examples/fluids: Riemann outflow using pressure and temperature

* This allows stable sustained and transient recirculation.

* short-wake domain recirculation behind cylinder has sustained
recirculation. If the exterior temperature is different, the
recirculation will bring in the wrong temperature, but at least
it's stable.
* nwave with slow background causes transient flow reversal when
strong acoustic hits boundary.
* Clean outflow and lid for Blasius

* I tried the 2 P_ext - P_int strategy from Mengaldo (constant density)
and with specified exterior temperature, but they disrupted the interior
flow and were not significantly less reflective.

* The methods I tried for extrapolating interior temperature were not
stable. Simple extrapolation of velocity worked best, and did not show
signs of instability, perhaps because the neighboring flow and implicit
solve ties it together.

* This commit adds support for softmax control of recirculation, but the
parameters were finnicky, solver nonlinearity was a concern, and I'm not
convinced it's ever better than just allowing recirculation.

show more ...

examples/fluids: remove duplicate typedef

Vortex shedding / flow past cylinder (#1082)

* add vortex shedding problem

* add file for the Qfunctions

* add yaml file

* update problem setup

* update IC qfunc

* update problem set

Vortex shedding / flow past cylinder (#1082)

* add vortex shedding problem

* add file for the Qfunctions

* add yaml file

* update problem setup

* update IC qfunc

* update problem setup

* update initial condition

* update yaml file

* add mesh file

* add vortexshedding to navierstokes.h

* register vortexshedding to cloptions.c

* update configuration/yaml file

* fix Min function

* examples/fluids: fix boundary condition labels for cylinder

$PhysicalNames
6
2 1 "inlet"
2 2 "outlet"
2 3 "top"
2 4 "bottom"
2 5 "cylinderwalls"
2 6 "frontandback"
$EndPhysicalNames

* update QFunctions in navierstokes.c

* update data and BC structs in navierstokes.h

* update vortexshedding.c

* update states

* update IC in vortexshedding.h

* add freestream BC to cloptions

* updates in setuplibceed.c

* include freestream BC in example

* cleanup duplicate variable names

* rename variables as freestream

* clean-up some warning messages

* clean up example

* add cylinder.geo

* label physical volume

* examples/fluids: fix cylinder mesh and add vortexshedding defaults

* update gravity vector

* examples/fluids: match domain to Shakib, get vortex street

* update to quadratic mesh

* clean up yaml file

* delete vortexshedding.c and vortexshedding.h

* remove vortexshedding from register

* update yaml file

* examples/fluids: Newtonian "still" initial condition

Reinstate outflow boundaries that were previously removed so that
existing tests can pass.

* examples/fluids: freestream inherits reference state

Fix freestream context reference counting bug.

* examples/fluids: avoid designated initializer in kernel code (breaks CUDA)

* add Shakib91 to references

* remove cylinder.geo and cylinder.msh

* wip:add documentation for vortex shedding

* update path to cylinder.msh

* add subdirectory for meshes

* parameterize cylinder.geo

* some fixes in cylinder.geo

* Fix cylinder.geo file

* examples/fluids: fix up mesh parametrization

Fix cylinder size (the function is Sqrt, not sqrt) and parametrize
resolution and aspect.

* examples/fluids: fix build after broken merge from main

* update Shakib1991 in references

* wip:docs for vortex shedding

* remove TODO comment

* reformulate docs

* fix docs

* delete cylinder.msh file

* work on documentation

* add vortex runtime options

* examples/fluids: update vortex shedding docs and mesh

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

examples/fluids: remove C99 designated initializers for use with CUDA

nvrtc does not support this construct.

minor - assorted formatting fixes

style: Prettyify fluids after clang-format switch

Mainly rearrange the input/output variable declarations for QFunctions

style: remove obsolete (with clang-format) INDENT comments

examples/fluids: freestream options and documentation

* Collect options under -freestream_ prefix and use HLLC by default.
* newtonianwave.yaml: equal aspect, monitoring options

examples/fluids: switch freestream to HLLC

examples/fluids: consolidate HLL and add HLLC

add HLLC Riemann solver

add HLLC riemann solver

fix(fluids): Correct size of epicenter array

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - re

Switch to clang-format (#1051)

* style - switch to clang-format

* ci - use newer libxsmm

* action - update format action

* format - consistent use of {} for multi-line if/for

* make - remove stray newline

* make - simpler 'make format' target

* ci - use newer libxsmm

* doc - minor release note claification

* minor - minor fix

* minor - minor fix

* minor - minor fix

* minor - minor fix

* make format

* format - less aggressive alignment rules

* tidy - check for argument name mismatches

* fix newline

* format - mirror Ratel update to .clang-format

* fix merge error

* fix merge conflict

* fix merge error

* drop style in .phony list

* Update .clang-format

Co-authored-by: Jed Brown <jed@jedbrown.org>

* apply updated format

Co-authored-by: Jed Brown <jed@jedbrown.org>

show more ...

Merge pull request #1080 from CEED/ade/riemann-bcs

HLL Flux for Riemann BCs

examples/fluids: remove stray ceed/types.h (breaking GPU)

fluids: Add missing license header to stab_types.h

fluids: Move freestream bc setup to function

- This will allow it to be called from other problems more easily (ie.
for the Blasius problem)