Remove the last of the use of horizontal lines --- as seperators. With modern code development systems they are not needed and just an eye-sore
Remove unneeded blank lines
checkbadSource: enforce proper style in makefiles
Docs: MatColoring fix
Remove unnecessary braces around one-linersgit grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\
Remove unnecessary braces around one-linersgit grep -lE "[ ]*(if|for|while) \(.*\) {[^;]*;[^;]*}$" -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | xargs sed -i '' -E 's#([ ]*)(if|for|while) \((.*)\) {([^;]*);([^;]*)}$#\1\2 \(\3\)\4;\5#'
show more ...
One-liners from petsc/petsc!5344 and petsc/petsc!5557Slightly reworked regular expressiongit ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do cat
One-liners from petsc/petsc!5344 and petsc/petsc!5557Slightly reworked regular expressiongit ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}done
missing "s" for isascii and issundials
Use PetscBool instead of PetscInt for setupcalledPetscInt was used in some structs, but the underlying logic requires only Booleans. Also removed an unused variable and unified capitalization.
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90impl.h files. Also move uses of f90 to ftn when simple
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous ve
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous versions!- also clean up inconsistent PETSc code detected by new Fortran generation tools- drop use of bfort- automatically generate all the Fortran PETSc objects, enums etc from the include files- generate most of the Fortran interface definitions and functions from the source code- simplify the number and organization of Fortran modulesCo-authored-by: Jose E. Roman <jroman@dsic.upv.es>
Merge remote-tracking branch 'origin/release'
Improve some manual pages in KSP/SNES
Brain dead fixes for useless casts
SPARSEPACKgenrcm: fix asan warnings# > /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:50:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# >
SPARSEPACKgenrcm: fix asan warnings# > /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:50:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:50:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:66:5: runtime error: applying non-zero offset to non-null pointer 0xfffffffffffffffc produced null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:66:5 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/fnroot.c:46:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/fnroot.c:46:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/fnroot.c:49:3: runtime error: applying non-zero offset to non-null pointer 0xfffffffffffffffc produced null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/fnroot.c:49:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/rootls.c:39:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/rootls.c:39:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:67:5: runtime error: applying non-zero offset to non-null pointer 0xfffffffffffffffc produced null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/genrcm.c:67:5 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/rcm.c:58:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/rcm.c:58:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/rcm.c:61:3: runtime error: applying non-zero offset to non-null pointer 0xfffffffffffffffc produced null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/rcm.c:61:3 in# > /home/szampini/Devel/petsc/src/mat/graphops/order/degree.c:43:3: runtime error: applying non-zero offset 18446744073709551612 to null pointer# > SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/szampini/Devel/petsc/src/mat/graphops/order/degree.c:43:3 in
CI: update checkclangformat to use clang-format-19.1.0
Remove unneeded parentheses
Merge branch 'barry/2024-09-18/fix-some-clang-tidy' into 'main'Fix some code issues exposed by make clang-tidySee merge request petsc/petsc!7845
Fix some code issues exposed by make clang-tidy
Fix -Wextra-semi-stmtsrc/mat/graphops/color/impls/greedy/greedy.c:479:3: warning: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Wextra-semi-stmt] 479
Fix -Wextra-semi-stmtsrc/mat/graphops/color/impls/greedy/greedy.c:479:3: warning: empty expression statement has no effect; remove unnecessary ';' to silence this warning [-Wextra-semi-stmt] 479 | ; | ^See also: https://gitlab.com/petsc/petsc/-/merge_requests/7833
Fix MPIU_* routines to always return MPI error codes and thus be usable with PetscCallMPI()Introduce MPIU_Count to be used when MPI_Count is not available
Fixes for clang-tidy
Change from deprecated PETSC_MAX/MIN_INT to PETSC_INT_MAX/MINCommit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, exampleFunded
Change from deprecated PETSC_MAX/MIN_INT to PETSC_INT_MAX/MINCommit-type: i.e. error-checking, optimization, bug-fix, portability-fix, testing-fix, style-fix, feature, documentation, exampleFunded-by:Project:Time: hoursReported-by:Thanks-to:Development Tools: Vim, Emacs, Eclipse
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in th
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in the CI
Fix usage of deprecated PETSC_DEFAULT
123