Do not scatter to the same vector at the same timeIn vecscatter, the target vector is write-locked
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be unif
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be uniformly used or maintained.Thus, remove all .keywords: fields, and a following blank line, if present.This is accomplished with GNU sed (gsed on OS X), with the following commands.*Warning* that this type of command can corrupt a .git directory,so be cautious in reusing or modifying these commands. They first lookfor and delete matching lines with a following line consisting of only whitespace,and then delete any remaining matching lines. find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find src/ -type f -exec gsed -i '/keywords:/d' {} + find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find include/ -type f -exec gsed -i '/keywords:/d' {} +Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed
show more ...
The SNESNASM nonlinear preconditioner doesn't ever use the KSP solver thereforshould never turn on the usesksp flag. The setting of this flag made the SNESASPIN solverthat uses the SNESNASM solver
The SNESNASM nonlinear preconditioner doesn't ever use the KSP solver thereforshould never turn on the usesksp flag. The setting of this flag made the SNESASPIN solverthat uses the SNESNASM solver incorrectly have SNESNASM process the options for theKSP and view it in SNESView() which could lead to users incorrectly believing thesolver was being used. Also added more text to the manual pages for these objectsto clarify how they function and interact with the Jacobian.Commit-type: bug-fix, documentation
Support domain errors in SNESComputeJacobian
doc fixes
Merge branch 'maint'
Fixed incorrect formatting in SNESASPIN manual page.Commit-type: documentationThanks-to: Richard Tran Mills <rmills@rmills.org>
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \(
Man pages: add newlines after "Notes:"This allows for proper formatting from sowing.On OS X (using gsed, not the default BSD sed), from the PETSc root directory: find src include -type f \( -name "*.c" -or -name "*.h" -or -name "*.cxx" \) | xargs gsed -i 's/Notes\s*:\s*\(\w.*\)/Notes:\n \1/'This adds a newline and 4 spaces whenever "Notes:" is followed by any "word" character, in any .c, .h, or .cxx file in src/ or include/
Fix many dead assignments, mostly due to missing CHKERRQ(ierr);Commit-type: style-fixReported-by: clang static analyzer
Improvements to SNESNASM: - honour -snes_nasm_damping (was previously ignored) - allow the user to set a weight (to average contributions on overlaps)
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information aft
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information after the general info while all other solvers printed it before (right after the name of the type is printed)2) KSPView consistently printed the name of the subtype on EACH line of the subtypes output as did a few of the PC and SNES viewers. Since they are all printed indented directly below the subtype name there is no reason to print this information on each line3) TSView printed output about number of linear solvers and SNES even for explicit methods, which is goofy.4) a few other minor formatting and consistency issues where fix.Commit-type: style-fix, featureTime: 16 hours
Add utility functions to fetch subsneses for NASM, modelled after SNESComposite
Increment the tab level, so that we can actually read the output
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-t
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-to: Andreas Mang <andreas@ices.utexas.edu>
remove use of illegal I in PETSc C exampleAdd example to tests in makefile, fix memory leak in example, cleanup some minor code formattingTime: .2 hoursReported-by: Lulu Liu <lulu.liu@kaust.edu.
remove use of illegal I in PETSc C exampleAdd example to tests in makefile, fix memory leak in example, cleanup some minor code formattingTime: .2 hoursReported-by: Lulu Liu <lulu.liu@kaust.edu.sa>
SNES: Add flag indicating if final residual is always computedAlthough SNESSolve_XXX always updates the solution variable, it may notbe the case that the residual in vec_func is the residual at th
SNES: Add flag indicating if final residual is always computedAlthough SNESSolve_XXX always updates the solution variable, it may notbe the case that the residual in vec_func is the residual at the newsolution. Track this behaviour explicitly for all concreteimplementations. We will use this in SNESSolve_FAS to determine if theresidual must be computed before transferring it between levels.
missing seealso for NASM
Merge branch 'barry/fix-source-clang'
Added static to a variety of KSP and SNES methodsFound agmres directory not listed in the makefile so added it and fixed some codes to get it to compile
a variety of fixes for issues detected by the clang static analyzerReported-by: clang static analyzer
A few corrections for items detected by the clang static analyzerReported-by: clang static analyzer
a couple of fixes suggested by clang analyzeradd missing error checkingminor formatting fixes
Fixes for issues found with clang static analyzer,mostly set but unused variablesTime: 1 hour
labeled a variety of additional internal functions as staticto prevent them from being publically available in the library
12345678