Cleanup of introduction of PetscCall()* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()* rename for consistency certain XXXBegin()/End() macros such as Mat
Cleanup of introduction of PetscCall()* remove bogus error flags from XXXBegin()/End() macros such as PetscOptionsBegin()/End()* rename for consistency certain XXXBegin()/End() macros such as MatPreallocateInitialize()/Finalize()* fix many lingering ierr = XXX that arose from multiline function calls* sync slepc/hpddm - to use snapshots with the same changesCommit-type: error-checking, style-fix/spend 8h
show more ...
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be addit
Do not wrap PetscTryMethod() PetscUseMethod() in PetscCallIt produces shadow declarations and also serves no purpose since these macros do the appropriate error checking alreadyThere may be additions needed for running with a static error checkerCommit-type: error-checking/spend 15mReported-by:Lisandro Dalcin <dalcinl@gmail.com>
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
chkerr and friends wrapped
doc: more fixes to remove build warnings
doc: fix References: sectionNotation:. * - textor. year - text
make PetscInfo() variadic
Remove all double blank lines from sourceCommit-type: petsc-style/2h
Turn on checkbadSource test to generate an error when found; fix all source code that causes errorsCommit-type: portability-fix, testing-fix, style-fix, feature, maintainability/spend 1.5h
Merge from doc-fixes branch
Fixes for doctext update
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be unif
Man pages: remove .keywords: fieldsThis field is recognized by doctext from Sowing (http://wgropp.cs.illinois.edu/projects/software/sowing/doctext/node20.htm#Node20),but it doesn't seem to be uniformly used or maintained.Thus, remove all .keywords: fields, and a following blank line, if present.This is accomplished with GNU sed (gsed on OS X), with the following commands.*Warning* that this type of command can corrupt a .git directory,so be cautious in reusing or modifying these commands. They first lookfor and delete matching lines with a following line consisting of only whitespace,and then delete any remaining matching lines. find src/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find src/ -type f -exec gsed -i '/keywords:/d' {} + find include/ -type f -exec gsed -i '/keywords:/ {N; /\n\s*$/d}' {} + find include/ -type f -exec gsed -i '/keywords:/d' {} +Hints on the sed command obtained from: https://unix.stackexchange.com/questions/100754/how-to-delete-a-specific-line-and-the-following-blank-line-using-gnu-sed
Fixes for TSView to add proper tabbing1) add PetscViewerASCIIPushTab() PetscViewerASCIIPopTab() for SNESView inside TSView()2) make sure usessnes is properly set and unset depending on if the TS m
Fixes for TSView to add proper tabbing1) add PetscViewerASCIIPushTab() PetscViewerASCIIPopTab() for SNESView inside TSView()2) make sure usessnes is properly set and unset depending on if the TS method uses SNES3) fix output for two TS examples that do not use SNESCommit-type: bug-fixReported-by: Alp Dener <adener@anl.gov>Thanks-to: Todd Munson <tmunson@mcs.anl.gov>
Fix various compiler warnings and add PetscFunctionBegin
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information aft
Make ASCII PC/KSP/SNES/TSView() code and output in a standard styleThe code that prints the ASCII view for solvers was occasionally inconsistent:1) TSView printed the type specific information after the general info while all other solvers printed it before (right after the name of the type is printed)2) KSPView consistently printed the name of the subtype on EACH line of the subtypes output as did a few of the PC and SNES viewers. Since they are all printed indented directly below the subtype name there is no reason to print this information on each line3) TSView printed output about number of linear solvers and SNES even for explicit methods, which is goofy.4) a few other minor formatting and consistency issues where fix.Commit-type: style-fix, featureTime: 16 hours
TSAdapt: Refactor handling of default adapt type* Let TS subtypes state its preference for adaptivity* Methods without embedded error estimators prefer TSADAPTNONE* If not set, use TS_EXACTFINALT
TSAdapt: Refactor handling of default adapt type* Let TS subtypes state its preference for adaptivity* Methods without embedded error estimators prefer TSADAPTNONE* If not set, use TS_EXACTFINALTIME_MATCHSTEP when using adaptivity* Remove command line option -ts_theta_adapt* Use `-ts_adapt_type basic` to turn on adaptivity in TSTHETA* Remove command line option -ts_alpha_adapt* Remove routine TSAlphaUseAdapt() and TSAlpha2UseAdapt()* Use `-ts_adapt_type basic` to turn on adaptivity in TSALPHA/TSALPHA2
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-t
Remove the use and definition of __FUNCT__ throughout the codeSince all modern C/C++ compilers provide this functionality we no longer need to provide it manually in PETScTime: 1.5 hoursThanks-to: Andreas Mang <andreas@ices.utexas.edu>
TS: Refactor TSStep() and TSRollBack()* TSStep() handles the step counter increment, and not TSStep_XXX().* TSRollBack() handles the step counter decrement.* Removed ``time_step_prev`` from the T
TS: Refactor TSStep() and TSRollBack()* TSStep() handles the step counter increment, and not TSStep_XXX().* TSRollBack() handles the step counter decrement.* Removed ``time_step_prev`` from the TS structure. New code should use ts->ptime - ts->ptime_prev to determine the previous time step size.* Removed unused ``time_step_orig`` from the TS structure.* Removed unused ``time_step_since_decrease`` from the TS structure.* Minor update bouncing ball test examples.* Regenerate some test examples output.
TS: Fix function declarations and visibility* Most of these fixes where spotted by GCC -Wmissing-declarations
TS: Move calls to TSPreStep() from implementation to interface* Make the semantics symmetric with TSPostStep()* Handle rolled back steps appropriately* If a callback is ever needed to run at the
TS: Move calls to TSPreStep() from implementation to interface* Make the semantics symmetric with TSPostStep()* Handle rolled back steps appropriately* If a callback is ever needed to run at the begining of each TSStep() (including rolled back steps and step rejections), we can add a new API to support this particular need (BTW, patches welcome!)
fixed up formatting of references in manualpages to consistent styleReferences:+ 1. - ref1. 2. - ref2- 3. - ref3previously the formatting was varied and ugly
Begin renaming the PetscOptions objects for the future where PetscOptions will not be a singleton
added convergence criteria for TSPSEUDO and updated some test examples to use these to generate same results with double and single precision
Merge branch 'master' into pr263/PierreBdR/ts-domain-error-in-stage/master
Merge branch 'maint'
1234567891011