checkbadSource: enforce proper style in makefiles
distinguish Boolean and IntegerMPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Namethis flag "iflg" (was used somewhere already).Use MPI_LAND instead of MPI_BAND for logical op
distinguish Boolean and IntegerMPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Namethis flag "iflg" (was used somewhere already).Use MPI_LAND instead of MPI_BAND for logical operations instead ofMPI_MIN, MPI_MAX, and MPI_LAND.Note: Most of the previous code was probably working as intended, I didthe changes when debugging error related to the use of standard C Bool andkept them because it took me a while to understand that MPI has integerflags and PETSc has Booleans. Using different names makes this clear,but was and is not done consistently.
show more ...
Remove the last of the uses of $ in the first line of formatted manual pages
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90impl.h files. Also move uses of f90 to ftn when simple
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous ve
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous versions!- also clean up inconsistent PETSc code detected by new Fortran generation tools- drop use of bfort- automatically generate all the Fortran PETSc objects, enums etc from the include files- generate most of the Fortran interface definitions and functions from the source code- simplify the number and organization of Fortran modulesCo-authored-by: Jose E. Roman <jroman@dsic.upv.es>
Mat: avoid overflow when loading a MatSeqDense
Remove unneeded parentheses
Fixes for clang-tidy
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in th
Add to CI compilers flags '-Wconversion', '-Wno-sign-conversion', '-Wno-float-conversion', '-Wno-implicit-float-conversion']Also fix the code to repository to compile cleanly with these flags in the CI
Merge remote-tracking branch 'origin/release'
Fix bug in PetscViewerBinaryWriteReadAll() thatprevented saving dense matrices whose number of entries on MPI rank 0 is greater than PETSC_MPI_INT_MAX byremoving unneeded PetscCall(PetscMPIIntCast
Fix bug in PetscViewerBinaryWriteReadAll() thatprevented saving dense matrices whose number of entries on MPI rank 0 is greater than PETSC_MPI_INT_MAX byremoving unneeded PetscCall(PetscMPIIntCast(count, &cnt)); on rank 0.Also removed unneeded potentially large malloc when used with on one MPI rankReported-by: Sreeram R Venkat <srvenkat@utexas.edu>Code still does not work if any MPI process besides rank 0 has a matrix with a number of entries greater than PETSC_MPI_INT_MAX
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routinesReported-by: James WrightThanks-to: Jeremy L Thompson
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGERPass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXXThe compiler will now automatically prevent you from using the wrong argument type for the first three bullets aboveThis will also require an update sowing with the new sowing branch this MR is using.
Update source code removing all unneeded /*@C and associated manual stubs and interfaces
CI: update to clang-format-18
Remove carriage return in Petsc(Assert|Check)()git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'Suggested-by: Stefan
Remove carriage return in Petsc(Assert|Check)()git grep -l -E "Petsc(Assert|Check)\(.*\\\n\"[,)]" | xargs sed -r -i'' 's#Petsc(Assert|Check)\((.*)\\n"([,)])#Petsc\1\(\2\"\3#g'Suggested-by: Stefano Zampini
checkbadSource: rules for PetscFunctionBegin and derivatives
Fix words appearing twice in a row for no good reason
LIBBASE is no longer used in make so remove it
Rename rules.doc and rules.utils because GitLab treats the former as a MS Word document.Thanks-to: Jed Brown
Some objects such as PETSC_VIEWER_STDOUT_WORLD cannot be destroyed by users.Reported-by: maitri ksh <maitri.ksh@gmail.com>
... and apply it
Rename PetscValidPointer -> PetscAssertPointer
Deploy new PetscValidPointer, remove PetscValidXXXPointer
Lint apply: sys
123456789