distinguish Boolean and IntegerMPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Namethis flag "iflg" (was used somewhere already).Use MPI_LAND instead of MPI_BAND for logical op
distinguish Boolean and IntegerMPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Namethis flag "iflg" (was used somewhere already).Use MPI_LAND instead of MPI_BAND for logical operations instead ofMPI_MIN, MPI_MAX, and MPI_LAND.Note: Most of the previous code was probably working as intended, I didthe changes when debugging error related to the use of standard C Bool andkept them because it took me a while to understand that MPI has integerflags and PETSc has Booleans. Using different names makes this clear,but was and is not done consistently.
show more ...
One-liners from petsc/petsc!5344 and petsc/petsc!5557Slightly reworked regular expressiongit ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do cat
One-liners from petsc/petsc!5344 and petsc/petsc!5557Slightly reworked regular expressiongit ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}done
missing "s" for isascii and issundials
Fix wrong case for PETSc
Fix manual pages related to FortranRemove a couple of dead Fortran bindings
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90
Minor cleanup of Fortran binding stuff to simplify future maintainanceThere is no distinction between F90 and non-F90 code so combine ftn-custom and f90-custom directories and fortranimpl.h and f90impl.h files. Also move uses of f90 to ftn when simple
Fortran: fix PETSC_HAVE_FORTRAN_UNDERSCORE defsAnd remove FORTRANDOUBLEUNDERSCORE, cleanup PETSC_HAVE_FORTRAN_UNDERSCORE_UNDERSCORERevert PETSC_VIEWER_STDOUT_BROKEN from 5022eb3e26e9dbfdd711345ef
Fortran: fix PETSC_HAVE_FORTRAN_UNDERSCORE defsAnd remove FORTRANDOUBLEUNDERSCORE, cleanup PETSC_HAVE_FORTRAN_UNDERSCORE_UNDERSCORERevert PETSC_VIEWER_STDOUT_BROKEN from 5022eb3e26e9dbfdd711345efc14d09b0dee953f
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous ve
Fortran 90: fully embrace After 34 years!- deprecate use of 'F90' in Fortran function names- use Fortran pointers when appropriate- the new Fortran API is not backward compatible with previous versions!- also clean up inconsistent PETSc code detected by new Fortran generation tools- drop use of bfort- automatically generate all the Fortran PETSc objects, enums etc from the include files- generate most of the Fortran interface definitions and functions from the source code- simplify the number and organization of Fortran modulesCo-authored-by: Jose E. Roman <jroman@dsic.upv.es>
Fixes for clang-tidy
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routinesReported-by: James WrightThanks-to: Jeremy L Thompson
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of
This requires some changes to user FORTRAN codePass PETSC_NULL_XXX_ARRAY when passing a NULL as an argument that is expecting an arrayPass PETSC_NULL_ENUM when argument returns an enum instead of PETSC_NULL_INTEGERPass arrays (and not scalar values) when the argument is expecting an array; this means replace, for example, the argument v with [v]Use PetscObjectIsNull(obj) to check if the object is NULL, instead of obj == PETSC_NULL_XXXThe compiler will now automatically prevent you from using the wrong argument type for the first three bullets aboveThis will also require an update sowing with the new sowing branch this MR is using.
Update source code removing all unneeded /*@C and associated manual stubs and interfaces
LIBBASE is no longer used in make so remove it
Rename rules.doc and rules.utils because GitLab treats the former as a MS Word document.Thanks-to: Jed Brown
Remove first and last empty lines
Convert all header guards to pragma once
Merge branch 'barry/2023-08-10/cannot-destroy-persistant-objects' into 'main'(1) Fix error return codes for PetscHeaderCreate/Destroy() Cannot use || on them (2) do not allow destroying PETSC_VIEWE
Merge branch 'barry/2023-08-10/cannot-destroy-persistant-objects' into 'main'(1) Fix error return codes for PetscHeaderCreate/Destroy() Cannot use || on them (2) do not allow destroying PETSC_VIEWER_STDOUT_SELF etcSee merge request petsc/petsc!6804
Some objects such as PETSC_VIEWER_STDOUT_WORLD cannot be destroyed by users.Reported-by: maitri ksh <maitri.ksh@gmail.com>
Prune some PetscViewer internals:1. Make functions used only within a single TU static2. Make private functions used only within PETSc either PETSC_INTERN orPETSC_SINGLE_LIBRARY_INTERN3. Apply t
Prune some PetscViewer internals:1. Make functions used only within a single TU static2. Make private functions used only within PETSc either PETSC_INTERN orPETSC_SINGLE_LIBRARY_INTERN3. Apply the same treatment to variables
Rename PetscValidPointer -> PetscAssertPointer
Manual linter fixes: sys
Lint apply: sys
HAVE_FORTRAN should be USE_FORTRAN_BINDINGS since it is about generating the Fortran bindings, not about if the Fortran compiler exists
Fix trivial typos etc in some manual pagesAlso remove manual page for SNESNGSFunction since it does not exist
Fix manual pages in viewers subdirectory of sys
123456